MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Update notification not working

    Scheduled Pinned Locked Moved Bug Hunt
    7 Posts 3 Posters 4.2k Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • tosti007T Offline
      tosti007 Module Developer
      last edited by

      I am not sure if I am the only one so I thought it would be better to open a topic here instead.
      The problem is with the default updatenotification. After doing quite some testing I found out that there is quite a big problem.
      In the node_helper.js function configureModules there is a loop that goes through all the modules that aren’t default ones. In this loop there is a variable made named git and it’s function getRemotes is called with some kind of callback function. The problem here is that that callback function is never called. This results in the simpleGits array to be empty and then the preformFetch doesn’t have much to work with.
      Lastly the preformFetch isn’t declared properly inside the object. It currently is preformFetch() {//whatever}, and should be preformFetch: function () {//whatever}.
      Is anyone able to reproduce this problem or is it just me (windows 10)?

      TLDR; updatenotification > node_helper.js > lines 33-44 broken, someone fix?

      If there is anything don't hesitate to contact me!
      ProfileSwitcher, TouchNotifications

      strawberry 3.141S 1 Reply Last reply Reply Quote 0
      • strawberry 3.141S Offline
        strawberry 3.141 Project Sponsor Module Developer @tosti007
        last edited by

        @tosti007 if you want and have the time you can compare it with my mobile module, this has pretty much the same functionality and works for me. Maybe you’ll find the issue.

        Please create a github issue if you need help, so I can keep track

        tosti007T 1 Reply Last reply Reply Quote 0
        • tosti007T Offline
          tosti007 Module Developer @strawberry 3.141
          last edited by

          @strawberry-3.141 looked through your post and github page, to which module are you referring? (link? :) I had struggles finding it)

          If there is anything don't hesitate to contact me!
          ProfileSwitcher, TouchNotifications

          strawberry 3.141S 1 Reply Last reply Reply Quote 0
          • strawberry 3.141S Offline
            strawberry 3.141 Project Sponsor Module Developer @tosti007
            last edited by

            @tosti007 it starts here https://github.com/fewieden/MMM-Mobile/blob/c0739ceb43f303af02886abcd560033acbbba4c4/node_helper.js#L67

            Please create a github issue if you need help, so I can keep track

            tosti007T N 2 Replies Last reply Reply Quote 0
            • tosti007T Offline
              tosti007 Module Developer @strawberry 3.141
              last edited by

              @strawberry-3.141 thank you! I will check it out :)

              If there is anything don't hesitate to contact me!
              ProfileSwitcher, TouchNotifications

              1 Reply Last reply Reply Quote 0
              • N Offline
                nobita @strawberry 3.141
                last edited by

                @strawberry-3.141 said in Update notification not working:

                @tosti007 it starts here https://github.com/fewieden/MMM-Mobile/blob/c0739ceb43f303af02886abcd560033acbbba4c4/node_helper.js#L67

                what is different MMM-Mobile VS phone_notification

                tosti007T 1 Reply Last reply Reply Quote 0
                • tosti007T Offline
                  tosti007 Module Developer @nobita
                  last edited by

                  @nobita MMM-Mobile is for his app he is making

                  If there is anything don't hesitate to contact me!
                  ProfileSwitcher, TouchNotifications

                  1 Reply Last reply Reply Quote 0
                  • 1 / 1
                  • First post
                    Last post
                  Enjoying MagicMirror? Please consider a donation!
                  MagicMirror created by Michael Teeuw.
                  Forum managed by Sam, technical setup by Karsten.
                  This forum is using NodeBB as its core | Contributors
                  Contact | Privacy Policy