Test suite for MagicMirror²

roramirez

I mention this here if someone can help

If use moment-timezone for a test this fail

Fail in Travis: https://travis-ci.org/roramirez/MagicMirror/builds/220155902
Commit example: https://github.com/roramirez/MagicMirror/commit/05d7c9556e773bf2b941035953200ff327efb476

roramirez

Hi Guys, are you still alive?

Sometimes the build failed, an example here
https://travis-ci.org/MichMich/MagicMirror/jobs/227577643

Someone have some idea how to fix this?

cc @qistoph @strawberry-3-141 @morozgrafix

qistoph

@roramirez sorry, haven’t had much time to spend on MagicMirror lately.

My guess is that some of the tests take too long. Especially the ones actually starting MM and not just load a module.

I imagine Travis runs the tests in some sort of container with multiple containers running on the same system. If there is some heavy load at the same time as the MM test is run this might slow down our test with a certain factor. Seeing the difference in the usual runtime between tests (couple of ms vs multiple seconds) makes me think some of our tests are on the heavier end. Having a multiple second test delayed by a factor, say, 2 makes it easily run 5 seconds. Hitting the 5 sec maximum (see log).

Two possibilities I see to fix this:

Reduce the runtime of long running tests
Increase the allowed runtime before timeout

Hopefully this helps.

Best regards and thanks for keeping this thread alive!

roramirez

@qistoph Well I’ve testing de CircleCI vs Travis.

For same Build
Failed: https://travis-ci.org/roramirez/MagicMirror/builds/234342109
Sucess: https://circleci.com/gh/roramirez/MagicMirror/6

qistoph

@roramirez
Except for one of the errors I think all can still be explained by my last post.

roramirez

@qistoph said in Test suite for MagicMirror²:

Except for one of the errors I think all can still be explained by my last post.

Yes, you’re rigth. Can you help in this area?

roramirez

Yay! After a long fight the test are passing in Travis CI

https://github.com/MichMich/MagicMirror/pull/953

Cato

I’m trying to find some information on testing in Magic Mirror for devs/contributors but it’s (too) hard to find. I can’t find any related forum, it’s not mentioned in the “MagicMirror² Module Development Documentation”, and not directly mentioned in any README-ish files on GitHub.

Of course, some of this can be deduced from the source code, but a small “Getting Started” guide would help more people getting … eh started. :-)

I’m living in Visual Studio as my day job, but not so much with writing tests, so my knowledge of other tools are limited. What I need is some information on software requirements and where tests should be and how testing is done.

roramirez

@Cato Hi!, The documentation for tests are living only in test source ;) This is something. We need to an better documentation.

Are you interested to do it? https://trello.com/c/UwqL27A3/29-add-documentation-of-testsuite

I’m not a very good at writing documentation.

But in short terms,

The tests are living in tests directory, there two kind of test, unit and e2e.

We are using mocha and spectron`, the last one is for the tests of e2e. For every e2e test is using a configuration file. When the test run load the configuration file and we check expected result of the MagicMirror instance in Electron mode.

You can using the follow sentences to run testsuite

Unit test: npm run test:unit
E2e tests: npm run test:e2e
Unit + e2e: npm test

If you can run especific test you need execute mocha from your path where is installed, in my case inside of MagicMirror directorio. Example of running the specific unit test for calendar functions.

NODE_ENV=test ./node_modules/mocha/bin/mocha tests/unit/functions/calendar_spec.js

Result:

  Functions into modules/default/calendar/calendar.js
    capFirst
      ✓ for 'rodrigo' should return 'Rodrigo'
      ✓ for '123m' should return '123m'
      ✓ for 'magic mirror' should return 'Magic mirror'
      ✓ for ',a' should return ',a'
      ✓ for 'ñandú' should return 'Ñandú'
    shorten
      ✓ for ' String with whitespace at the beginning that needs trimming' should return 'String with whit…'
      ✓ for 'long string that needs shortening' should return 'long string that…'
      ✓ for 'short string' should return 'short string'
      ✓ for 'long string with no maxLength defined' should return 'long string with no maxLength defined'
      ✓ should return an empty string if shorten is called with a non-string
      ✓ should not shorten the string if shorten is called with a non-number maxLength
      ✓ should wrap the string instead of shorten it if shorten is called with wrapEvents = true (with maxLength defined as 20)
      ✓ should wrap the string instead of shorten it if shorten is called with wrapEvents = true (without maxLength defined, default 25)


  13 passing (29ms)

If need something is not clear let me know.