Compliments: RemoteFile Configuration

jacktar

Hi…
I don’t consider myself to be a novice but setting up a remote compliments file is proving to be a real challenge.
Unfortunately, IMO the documentation isn’t that great when targetting a remote file - I’ve tried all sorts of config lines but to no avail.

e.g.

remoteFile: 'http://localhost:8080/compliments.json'
remoteFile: 'http://localhost:8080/modules/compliments.json'

for localhost, also read 127.0.0.1 and its assigned IPv4 address - I even moved the file into different directories in the vain hope it was a webserver permissions problem.

This is the (current) error in the debug window using localhost…

Access to XMLHttpRequest at 'http://localhost:8080/compliments.json' from origin 'http://0.0.0.0:8080' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
compliments.js:134
GET http://localhost:8080/compliments.json net::ERR_FAILED

Similarly, I also tried…

remoteFile: 'file://home/pi/MagicMirror/compliments.json'

ALL ATTEMPTS to target a filesystem file (compliments.json) fail …

compliments.js:134 GET http://0.0.0.0:8080/modules/default/compliments/file://home/pi/MagicMirror/compliments.json 404 (Not Found)

I can only assume my notation is wrong somewhere/somehow!
Incidentally, the file formatting appears to be correct so I’m convinced it’s the way I’m trying to ‘point’ the system at the json file.

If anyone can help, I’d appreciate it. Not much hair left to pull out

lavolp3

@jacktar said in Compliments: RemoteFile Configuration:

compliments.js:134 GET http://0.0.0.0:8080/modules/default/compliments/file://home/pi/MagicMirror/compliments.json 404 (Not Found)

You see the problem in the error message.
The variable remoteFilegets appended to an existing path which is http://0.0.0.0:8080/modules/default/compliments/.

You only need to put in the name of the file without a path and put your file into the compliments folder.

lavolp3

@jacktar Here is the underlying function

	/* complimentFile(callback)
	 * Retrieve a file from the local filesystem
	 */
	complimentFile: function (callback) {
		var xobj = new XMLHttpRequest(),
			isRemote = this.config.remoteFile.indexOf("http://") === 0 || this.config.remoteFile.indexOf("https://") === 0,
			path = isRemote ? this.config.remoteFile : this.file(this.config.remoteFile);
		xobj.overrideMimeType("application/json");
		xobj.open("GET", path, true);
		xobj.onreadystatechange = function () {
			if (xobj.readyState === 4 && xobj.status === 200) {
				callback(xobj.responseText);
			}
		};
		xobj.send(null);
	},

Whenever you use a “http://” or “https://” path it takes the path as you have provided. If not it converts it to an absolute path using the this.file(this.config.remoteFile) method. This method uses the modules directory (like you can see in my post above) and appends the path you have given

sdetweil

@lavolp3 another thing to say is

the MagicMirror provided web server assumes

modules is the root
express is listening/watching for modules as the base path

http://localhost:8080/modules/…

the file can be anywhere further down

jacktar

Ok, thanks. Got that sorted now
Hopefully this will help others with the same dilemma.
I had read a post referencing the use of file://
notation which, apparently, is a red-herring.

Just for clarity to others, a local compliments.json
file should be located in /pi/MagicMirror/modules/default/compliments/ directory and referenced using only the file name in the config file.

e.g. remoteFile: 'compliments.json'

kayakbabe

@jacktar said in Compliments: RemoteFile Configuration:

Just for clarity to others, a local compliments.json
file should be located in /pi/MagicMirror/modules/default/compliments/ directory and referenced using only the file name in the config file.
e.g. remoteFile: ‘compliments.json’

So… what happens if we update the compliments module? Do our customizations in the compliments.json file get wiped out?
can we put the compliments.json somewhere else to protect it?

sdetweil

@kayakbabe yes they will be lost.
.NEVER edit the source files we provide.

the design is that all your setting go in config.js
and custom.css for colors etc.

module :"compliments",
position:"....",
config:{
    compliments:{
               morning:[],
                afternoon:[],
              etc
     }
}

Assassins

You can look here