Are you tired of editing config.js, or have trouble doing it, see my new module

sdetweil

@doogy_rev see email for downloading fix

doogy_rev

@sdetweil Works like a champ! Thank you for looking in to this and fixing.

sdetweil

I posted a new release the other day, which finally fixes compliments the right way, and enables other module authors to leverage the same capabilities.
documented in the readme.

Socrates

I love the idea of this module, not sure why i missed it out before. Anywho now that i am trying to set it up, i have installed the module (did not use sudo).
Inserted this much code with no modification.

        {
                module:"MMM-Config",
                position:"bottom_right",  // the QR code (if requested) will appear here
                config:{

                }

And when i go to the URL i see a blank page.

sdetweil

@Socrates SOOOOO much fun, because there are no types in javascript and no standards for modules, i have to discover and guess the author’s intent.

sometimes i have a bug, sometimes they do weird unexpected things
can you look at the console where you do npm start?

if you use pm2, then

pn2 logs --lines=xxxx

where xxxx is a number of lines to display, default 15
I’ve tested w a lot of modules, but not all

can u give me a list of all the modules in your config.js

grep "module:" ~/MagicMirror/config/config.js | uniq | sort -h

you didn’t see it cause its not listed in the modules list

would you be willing to send me
a copy of your config.js, xxx out apikeys, private data urls, but make sure to leave the structure

from the the module folder, the
defaults.js
and the schema3.json —/ again edit out private things (near the bottom)

i do not share info sent to me, ever,
you can also attach the cleaned files to an issue on the module github page

if emailing
.js files have to be renamed by adding .txt to the end

defaults and schema3 are constructed from your installed modules

me email is the same userid as here at gmail.

sdetweil

@Socrates i really want to look at this problem.

MarcLandis

@sdetweil I get the same blank page and the reason is that it errors on buildschema4.js.

The reason is the compliments module:

compliments: {
anytime: [“Hey there sexy!”],
morning: [“Good morning, handsome!”, “Enjoy your day!”, “How was your sleep?”],
afternoon: [“Hello, beauty!”, “You look sexy!”, “Looking good today!”],
evening: [“Wow, you look hot!”, “You look nice!”, “Hi, sexy!”],
“…-01-01”: [“Happy new year!”]
},

sdetweil

@MarcLandis thanks…

in July I changed the processing for compliments… it worked before and the new process changed it to a different approach but still works…

can you do

in the module folder
ls schemas -laF

there should be 4 files related to compliments

these two handle the correction for the possible . in the js object type

-rw-rw-r-- 1 sam sam 2882 Jun 29 07:32 compliments_converter.js
-rw-rw-r-- 1 sam sam 9006 Jul 6 19:14 compliments.schema.json

and these two that improve the form look and feel and handling

-rw-rw-r-- 1 sam sam 381 Jun 28 18:01 compliments_extension.css
-rw-rw-r-- 1 sam sam 1980 Jul 6 19:10 compliments_extension.js

MarcLandis

@sdetweil

-rw-r–r-- 1 dirk dirk 2882 Sep 13 15:23 compliments_converter.js
-rw-r–r-- 1 dirk dirk 381 Sep 13 15:23 compliments_extension.css
-rw-r–r-- 1 dirk dirk 1980 Sep 13 15:23 compliments_extension.js
-rw-r–r-- 1 dirk dirk 9006 Sep 13 15:23 compliments.schema.json

I just did a fresh install of the module, to test something myself

sdetweil

@MarcLandis gosh I hate git changing file dates…

SO, can you do this for me

in the module folder do

node scripts/buildschema4.js …/defaults.js debug >somefile.txt 2>&1

and send me somefile.txt

I’d have you attach it to an issue, but it shows every line from config.js
same id at gmail… and issue attachments are public

MarcLandis

@sdetweil I created a new issue on github and uploaded the file after removing some sensitive information.

sdetweil

@MarcLandis great… thanks

pushed fix to the with_unused_fix branch

git pull
git checkout with_unused_fix
and run the buildschema4 test again

MarcLandis

@sdetweil

throws an error:

/home/dirk/MagicMirror/modules/MMM-Config/scripts/buildschema4.js:750
if(module_scripts[m.module] !== undefined ){
^

MarcLandis

@MarcLandis said in Are you tired of editing config.js, or have trouble doing it, see my new module:

@sdetweil

throws an error:

/home/dirk/MagicMirror/modules/MMM-Config/scripts/buildschema4.js:750
if(module_scripts[m.module] !== undefined ){
^

@sdetweil

fixed it myself but ran into the next exception:

calling module data converter script for module=compliments
/home/dirk/MagicMirror/modules/MMM-Config/schemas/compliments_converter.js:24
		Object.keys(config_data.compliments).forEach(c =>{
		                        ^

TypeError: Cannot read properties of undefined (reading 'compliments')
    at Object.converter (/home/dirk/MagicMirror/modules/MMM-Config/schemas/compliments_converter.js:24:27)
    at /home/dirk/MagicMirror/modules/MMM-Config/scripts/buildschema4.js:754:49

sdetweil

@MarcLandis sorry, try again, git pull…

MarcLandis

@MarcLandis said in Are you tired of editing config.js, or have trouble doing it, see my new module:

@MarcLandis said in Are you tired of editing config.js, or have trouble doing it, see my new module:

@sdetweil

throws an error:

/home/dirk/MagicMirror/modules/MMM-Config/scripts/buildschema4.js:750
if(module_scripts[m.module] !== undefined ){
^

@sdetweil

fixed it myself but ran into the next exception:
calling module data converter script for module=compliments
/home/dirk/MagicMirror/modules/MMM-Config/schemas/compliments_converter.js:24
		Object.keys(config_data.compliments).forEach(c =>{
		                        ^

TypeError: Cannot read properties of undefined (reading 'compliments')
    at Object.converter (/home/dirk/MagicMirror/modules/MMM-Config/schemas/compliments_converter.js:24:27)
    at /home/dirk/MagicMirror/modules/MMM-Config/scripts/buildschema4.js:754:49

I f… up

After git pull I have an exception in one of my not published modules. Going to check that first.

sdetweil

@MarcLandis ok i have grandchild lunch at school, back in a couple hours

sdetweil

@MarcLandis change this

unused_module.module

to this

unused_module

MarcLandis

@sdetweil I got the command running. There is also an issue when the default calendar module is not used. I fixed it by changing the following in buildschema4.js line 1050

// if the default calendar module is not used, tt will be empty and getValueObject will fail
    if (tt !== undefined && tt.length > 0) {
      module_properties = getValueObject(m, tt);
    }

Maybe you have a better fix ready :)

sdetweil

@MarcLandis thanks git pull on the new branch again …

I didn’t see this particular error with the latest