Updated to 2.17 but MM not launching

[Wenike]

Instead, I have a window labeled Electron running with nothing displayed. I did a git pull && npm install to do the update and had to remove both instances of package-lock.json (in the root MM folder and in the vendor subfolder) to do the update and I don’t remember modifying those. Is there some additional steps I need to do to make Electron behave?

[swvalenti]

Try using Sam scripts

https://github.com/sdetweil/MagicMirror_scripts

[sdetweil]

@swvalenti thx…

@Wenike also not listed (ever) on the MM site

for every module that has a package.json file do npm install

note that its possible that IF you had to add request back in on 2.16, it will be gone on 2.17 again

NOTE : because u already did the ‘ugrade’, you will need to use force instead of apply on the upgrade script

[Stoffbeuteluwe]

Hi, need help too

i have installed the update and when i start the mirror …

[02.10.2021 10:25.40.721] [ERROR] WARNING! Could not load config file. Starting with default configuration. Error found: Error: Cannot find module 'request'
Require stack:
- /Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/vendor/ical.js/node-ical.js
- /Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/vendor/ical.js/index.js
- /Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/calendarfetcher.js
- /Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/node_helper.js
- /Users/patrickhahn/MagicMirror/js/app.js
- /Users/patrickhahn/MagicMirror/js/electron.js
- /Users/patrickhahn/MagicMirror/node_modules/electron/dist/Electron.app/Contents/Resources/default_app.asar/main.js
- 
[02.10.2021 10:25.40.722] [LOG]   Loading module helpers ...
[02.10.2021 10:25.40.722] [LOG]   No helper found for module: alert.
[02.10.2021 10:25.40.722] [LOG]   Initializing new module helper ...
[02.10.2021 10:25.40.723] [LOG]   Module helper loaded: MMM-Remote-Control
[02.10.2021 10:25.40.723] [LOG]   Initializing new module helper ...
[02.10.2021 10:25.40.723] [LOG]   Module helper loaded: updatenotification
[02.10.2021 10:25.40.723] [LOG]   No helper found for module: MMM-Snow.
[02.10.2021 10:25.40.723] [LOG]   No helper found for module: MMM-WordClock.
[02.10.2021 10:25.40.723] [LOG]   No helper found for module: clock.
[02.10.2021 10:25.40.723] [LOG]   No helper found for module: calendar_monthly.
[02.10.2021 10:25.40.723] [LOG]   Initializing new module helper ...
[02.10.2021 10:25.40.723] [LOG]   Module helper loaded: calendar
[02.10.2021 10:25.40.725] [ERROR] App threw an error during load
[02.10.2021 10:25.40.726] [ERROR] Error: Cannot find module 'request'
Require stack:
- /Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/vendor/ical.js/node-ical.js
- /Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/vendor/ical.js/index.js
- /Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/calendarfetcher.js
- /Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/node_helper.js
- /Users/patrickhahn/MagicMirror/js/app.js
- /Users/patrickhahn/MagicMirror/js/electron.js
- /Users/patrickhahn/MagicMirror/node_modules/electron/dist/Electron.app/Contents/Resources/default_app.asar/main.js
- 
    at Module._resolveFilename (internal/modules/cjs/loader.js:887:15)
    at Function.n._resolveFilename (electron/js2c/browser_init.js:257:1128)
    at Function.Module._resolveFilename (/Users/patrickhahn/MagicMirror/node_modules/module-alias/index.js:49:29)
    at Module._load (internal/modules/cjs/loader.js:732:27)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
    at Module.require (internal/modules/cjs/loader.js:959:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/vendor/ical.js/node-ical.js:2:15)
    at Module._compile (internal/modules/cjs/loader.js:1078:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1108:10)
[02.10.2021 10:25.40.726] [ERROR] Whoops! There was an uncaught exception...
[02.10.2021 10:25.40.729] [ERROR] Error: Cannot find module 'request'
Require stack:
- /Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/vendor/ical.js/node-ical.js
- /Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/vendor/ical.js/index.js
- /Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/calendarfetcher.js
- /Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/node_helper.js
- /Users/patrickhahn/MagicMirror/js/app.js
- /Users/patrickhahn/MagicMirror/js/electron.js
- /Users/patrickhahn/MagicMirror/node_modules/electron/dist/Electron.app/Contents/Resources/default_app.asar/main.js
- 
    at Module._resolveFilename (internal/modules/cjs/loader.js:887:15)
    at Function.n._resolveFilename (electron/js2c/browser_init.js:257:1128)
    at Function.Module._resolveFilename (/Users/patrickhahn/MagicMirror/node_modules/module-alias/index.js:49:29)
    at Module._load (internal/modules/cjs/loader.js:732:27)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
    at Module.require (internal/modules/cjs/loader.js:959:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/vendor/ical.js/node-ical.js:2:15)
    at Module._compile (internal/modules/cjs/loader.js:1078:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1108:10) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/vendor/ical.js/node-ical.js',
    '/Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/vendor/ical.js/index.js',
    '/Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/calendarfetcher.js',
    '/Users/patrickhahn/MagicMirror/modules/MMM-MyCalendar/node_helper.js',
    '/Users/patrickhahn/MagicMirror/js/app.js',
    '/Users/patrickhahn/MagicMirror/js/electron.js',
    '/Users/patrickhahn/MagicMirror/node_modules/electron/dist/Electron.app/Contents/Resources/default_app.asar/main.js',
    undefined
  ]
}

thanks for helping

[sdetweil]

@stoffbeuteluwe said in Updated to 2.17 but MM not launching:

Cannot find module ‘request’

same problem for the last few months. and last release

see

https://forum.magicmirror.builders/topic/15666/add-request-to-modules

[OberfragGER]

Happens to me to.

MMM-SystemStats stops MM from working. reinstall and everything are not working so i had to quit using both MMM-SystemStats Modules.

[sdetweil]

@oberfragger did u look for the errors to decide what to do?

[OberfragGER]

@sdetweil Uuups.
Sorry for the “short” information. I did´nt realised that i sent the topic.

Both “MMM-SystemStats” seems to unmantained and both are stopping MM from starting. I just uncommented them in the config.js and openend an issue.

/home/pi/.pm2/logs/mm-error.log last 15 lines: 0|mm | at require 
(internal/modules/cjs/helpers.js:88:18) 0|mm | at Object.<anonymous> (/home/pi/MagicMirror/modules/MMM-SystemS tats/node_helper.js:13:15) 0|mm | at Module._compile (internal/modules/cjs/loader.js:1078:30) 0|mm | at Object.Module._extensions..js (internal/modules/cjs/loader.j s:1108:10) { 0|mm | code: 'MODULE_NOT_FOUND', 0|mm | requireStack: [ 0|mm | '/home/pi/MagicMirror/modules/MMM-SystemStats/node_helper.js', 0|mm | '/home/pi/MagicMirror/js/app.js', 0|mm | '/home/pi/MagicMirror/js/electron.js', 0|mm | '/home/pi/MagicMirror/node_modules/electron/dist/resources/defa ult_app.asar/main.js', 0|mm | undefined 0|mm | ] 0|mm | } 0|mm | [04.10.2021 13:13.47.982] [ERROR] MagicMirror will not quit, but it might be a good idea to check why this happened. Maybe no internet connection? 0|mm | [04.10.2021 13:13.47.982] [ERROR] If you think this really is an is sue, please open an issue on GitHub: https://github.com/MichMich/MagicMirror/iss ues

I dont have any clus what i cloud do more.

[sdetweil]

@oberfragger it says module not found

we deleted a bunch of older libraries because one was discontinued (deprecated) due to a security problem not going to be fixed

many mm modules used them but didn’t document the usage. oops

I don’t see the name of the library

but looking at the node_helper.js shows

require('request')

which is the trouble lib

u can add it back for this module , do

npm init -y
npm install request -- save

[OberfragGER]

@sdetweil said in Updated to 2.17 but MM not launching:

``|

Thanks a lot. That did the job for me!

[Stoffbeuteluwe]

@sdetweil

Hi Sam, i have to do this for 11 modules :grinning_face_with_big_eyes: …but that’s not the problem it takes a little time…but do I have to do all this again on every next MM Update?:dizzy_face:

Greeting from Germany

[Stoffbeuteluwe]

The Mirror works but there are some errors…

[14.10.2021 21:09.11.218] [ERROR] (node:48778) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
(Use `Electron --trace-warnings ...` to show where the warning was created)
[14.10.2021 21:09.11.218] [ERROR] (node:48778) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency
[14.10.2021 21:09.11.218] [ERROR] (node:48778) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency
[14.10.2021 21:09.11.218] [ERROR] (node:48778) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency
[14.10.2021 21:09.11.218] [ERROR] (node:48778) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency
[14.10.2021 21:09.11.218] [ERROR] (node:48778) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency
[14.10.2021 21:09.11.218] [ERROR] (node:48778) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency
[14.10.2021 21:09.11.218] [ERROR] (node:48778) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'find' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'head' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'set' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'test' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'to' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency
[14.10.2021 21:09.11.219] [ERROR] (node:48778) Warning: Accessing non-existent property 'which' of module exports inside circular dependency

[sdetweil]

@stoffbeuteluwe said in Updated to 2.17 but MM not launching:

…but do I have to do all this again on every next MM Update

if you do the

npm init

in the module folder before npm install request (or whatever is missing)
then that library will be loaded in the module node_modules list

if NOT, then it looks for the 1st node_modules folder up the directory tree , finds one under MagicMirror and installs the module there

BUT…

on the next update, npm will check and see that this library was not required by MM, and so delete it, (security, so someone can’t sneak libraries into the installed folder)…

so… answer to your question is ‘maybe’…

[sdetweil]

@stoffbeuteluwe said in Updated to 2.17 but MM not launching:

The Mirror works but there are some errors…

how did u do the upgrade?

can u tell me

node -v
npm -v

output?

this version of electron needs node 14. my script does NOT upgrade node

[Stoffbeuteluwe]

@sdetweil when I’m home from work I will tell you….thanks in advance

[Stoffbeuteluwe]

@sdetweil Hi…
git pull & npm install

node -v v14.17.3
npm -v 6.14.13

[sdetweil]

@stoffbeuteluwe ok, thx… did u use my upgrade script?

if not, I would go thru every module (not defaults) and look for package.json

if present, in the module folder I would

rm package-lock.json
rm -rf node_modules
npm install

to reload the dependencies based on the new MM.
(this is what my upgrade script does)

after that, I would disable one module at a time to find the culprit…

[Stoffbeuteluwe]

@sdetweil said in Updated to 2.17 but MM not launching:

npm install

Ok thank you Sam i will try…

[sdetweil]

@stoffbeuteluwe u could use my upgrade script with force

to accomplish the same thing

I would disable modules to find it first, and then check after redoing npm install

[Stoffbeuteluwe]

@sdetweil do you think the error came from a module?