not able to profileswitch/schedule LocalTransport module

dfuerst

i am using CFenner’s LocalTransport module, which is perfectly what i need for displaying the train departures leaving the village i live in.

i use MMM-Buttons with MMM-ProfileSwitcher to hide all modules by pressing a physical button.
Unfortunately this doesn’t work with the LocalTransport module. Module is always shown!

Is there anyone who can fix this for the LocalTransport modul or can recommend an other module showing the same and at which CLASSES can be used?

tosti007

Alright so I found the problem and it turned out to be a mistake in the Localtransport module. I have send him a pull request and updated my README with a fix. Have fun with the modules :)

I will copy paste it the README text here as well:

The MagicMirror-LocalTransport-Module module does not work (without a fix) with the [MMM-ProfileSwitcher].
This due to his code overwriting a variable that it a default variable used by the MagicMirror Framework and my code need this. Luckily this problem can be solved fairly easily with any text editor.

Go to the module’s main file localtransport.js and replace the occurences of this.data with this.info.

Note: There should be three occurences on lines 170, 204 and 209.

Jopyth

@dfuerst I think it is a bug in MMM-ProfileSwitcher, I was also experiencing it. There is currently no other module providing this functionality as far as I know, but it will probably be fixed soon, maybe I will look into this myself on the weekend, if @tosti007 has not fixed it by then. :)

tosti007

@Jopyth thank you for mentioning me :) else I wouldn’t have seen this post.

@dfuerst that’s odd. I will have a look at it in the weekend. I currently don’t have that much time (that’s also why I respond late). I will let you know when I found the solution.

dfuerst

@tosti007 thanks in advance

Jopyth

@dfuerst @tosti007 Ok, turns out I made a mistake with my notifications. It is now working with all modules I want it to work. Maybe I can check Localtransport tomorrow.

tosti007

@dfuerst Unfortunately I did not have as much time this weekend as I hoped it would have. However @Jopyth came up with a fix that should solve this. (Thank you @Jopyth) Pull the new changes and your problem should be solved :D

Edit: I gave it a quick test and it seems to be working fine!

dfuerst

did a “git pull”, now it isn’t working anymore at all. (no action after button longpress)
do i have to do something special after a git pull?

dfuerst

because the new version didn’t work anymore i reinstalled VERSION 2 from your REPO:
now its working again , of course not hiding the localtransport module.
any ideas why this version starts upon button press and the 8hours old one not?

tosti007

@dfuerst hmm, ouch. First of all sorry for the inconvenience. If you have the most up-to-date version set useLockStrings to false does it work like the original version 2?

dfuerst

@tosti007 it did nothing.

dfuerst

i mean, the newest version did nothing.
after copying the code of the previous version into the .js file it worked again, of course not hiding localtransport.

many thanks for your effort

tosti007

@dfuerst that’s unfortunate. There is another problem currently going on, since I used code that isn’t supported on all browsers. My first thought now is that it might be related. I will fix this soon and hope that this was the issue. What browser are you using?

dfuerst

@tosti007 i use a RPi3 with standard Raspbian.
i always test via “pm2 start mm”

tosti007

@dfuerst I fixed that backwards compatibility, but this does unfortunatly not solve the problem (tested it). I did found the reason why it doesn’t work, however I do not have a quickfix for this. I will look at it in the following days after doing some research.

dfuerst

ok, again thanks for your effort

tosti007

Alright so I found the problem and it turned out to be a mistake in the Localtransport module. I have send him a pull request and updated my README with a fix. Have fun with the modules :)

I will copy paste it the README text here as well:

The MagicMirror-LocalTransport-Module module does not work (without a fix) with the [MMM-ProfileSwitcher].
This due to his code overwriting a variable that it a default variable used by the MagicMirror Framework and my code need this. Luckily this problem can be solved fairly easily with any text editor.

Go to the module’s main file localtransport.js and replace the occurences of this.data with this.info.

Note: There should be three occurences on lines 170, 204 and 209.

dfuerst

@tosti007
many thanks
tested it already and works now like a charme.
Might this also solve the incompatibility of LocalTransport with the FacialRecognition module? i guess so

tosti007

@dfuerst Yes it does, FacialRecognition also uses classes (which are saved in this.data)

tosti007

My pull request was just merged with master so you should be able to use them together out of the box now without having to modify his module! :D