[MMM-ValuesByNotification] Display the payloads of notifications with titles and icons

BKeyport

Thanks again, man. :)

I might not have to work up my own module to get the notifications. 🤣

BKeyport

I’m using the example scripts in CommandToNotification using a BME280. I’m trying to keep the temperature in F to two digits, as the script or BME module is producing LONG temperature values. (76.0000000000000000000000001)

Using the configuration below, I’m not getting any rounding on output. The “valueFormat” is directly from your README.md.

		{
			module: "MMM-ValuesByNotification", // https://github.com/Tom-Hirschberger/MMM-ValuesByNotification
			position: "top_bar",
			config: {
				animationSpeed: 0,
				updateInterval: 15,
				groups: [
					{
						items: [
							{
								notification: "WEATHERLINK", 
								values: [
									{
										valueTitle: "Closet",
										valueUnit: "°F",
										jsonpath: "data.conditions[1].temp_in",
										naValue: "0",
									},
								]
							},
						]
					},
					{
						items: [
							{
								notification: "TEMPROOM",
								itemTitle: "Room",
								values: [
									{
										valueTitle: "Temp",
										valueUnit: "°F",
										naValue: "0",
										valueFormat: "Number(${value}).toFixed(2)",
										jsonpath: "temperature_f",
									},
								],
							},
						]
					}, 
				]
			},
		},

wishmaster270

@BKeyport
Hi,

that’s definitly a bug. It is related to the problem you described in the issue on github.
I found a fix already but i need a moment to solve it proper.
As a quickfix you can change line 299 in MMM-ValuesByNotification.js from

						value = value.replace(/(?:\r\n|\r|\n)/g, newlineReplacement)

to

						value = String(value).replace(/(?:\r\n|\r|\n)/g, newlineReplacement)

wishmaster270

@BKeyport
Just released version 0.0.8 of the module which should fix both issues

BKeyport

@wishmaster270 Submitted a pull - please tell me what you think… I didn’t update the documentation however. I figured you could handle that, as I’m a horrible documentation writer.

🤣🤣🤣

wishmaster270

@BKeyport Hi, and thanks for the contribution. I only had a view moments to look at the changes.
Currently the changes do not look very critical and I will be happy to merge them.
I only want to make sure there is no more universal way (especially for the space) feature.

Documentation is one of my favourites (Not). But it should no big deal to add it.

I will try to do a deeper look the code the next days and will merge as fast as I can.