v2.22.0 | default calendar: no symbols with customEvents

[sdetweil]

@JDIBBY I changed one of my test cal setups to use custom events, copying your data but changing the trigger text

        calendars: [
        {
          url: "http://localhost:8090/modules/default/calendar/woot.ics",
          symbol: "calendar",
          color: "#efefef",
          name: "Rags Calendar",

        }
        ],
          customEvents: [
            { keyword: 'Weekly', symbol: 'file-signature' },
            { keyword: 'Every', symbol: 'champagne-glasses' },
          ],

and see this

[kai]

@sdetweil looks great - that’s the way I’d like to have it. :grinning_face:
So you didn’t specify a symbol class for the customEvents at all? I have had no success with this so far…

[sdetweil]

@kai no, exactly as I posted. are you sure those are the phrases in your calendar subject?

I had a problem once before, and had Two spaces between words in the calendar event, and only one in the events stucture…

[DaveChild]

I’ve been having the same problem. In mine the fas fa-fw fa- prefix was missing, so I changed my config to this:

customEvents: [
    {keyword: "Games", symbol: "dice fas fa-fw fa-dice"},
    {keyword: "Rugby", symbol: "running fas fa-fw fa-running"},
    {keyword: "Guitar", symbol: "guitar fas fa-fw fa-guitar"}
],

I duplicated the “dice” at the start so it keeps working when the bug is fixed. And the icons appear now.

[sdetweil]

@DaveChild hm… that is the symbolPrefix variable in 2.22

[DaveChild]

@sdetweil I’ve not delved far into the code but it looks to me like the symbolsForEvent function in calendar.js is getting the default symbol with the default class, but then overwriting that default with the symbol from customerEvents - but not applying the default class to it.

This might be fixed with applying this.getCalendarPropertyAsArray to ev.symbol in the line symbols[0] = ev.symbol;.

I’d do a PR myself but I have nowhere near enough experience tinkering with MagicMirror to be pushing code to a default module :). But I think that’s where the problem is, and my solution will work around that issue crudely for the moment.

[sdetweil]

@DaveChild cool. I’ll give that a look

[DaveChild]

@sdetweil I did a quick PR anyway, even if it’s not perfect, it’s better there’s a starting point for a fix than make someone repeat tracking it down to where I got to.

[lmhmm]

@sdetweil Yes I’ve got the same issue after upgrading to 2.22 no symbols even trying solution here. Be nice to get this resolved

[sdetweil]

@lmhmm Dave found it and provided a fix for next release. (April 1)

you could look at what he did and change your code,

of git pull and check the develop branch. see the instructions pinned to the top of this topic about testing fixes.

[sdetweil]

@DaveChild awesome. I saw all the GitHub traffic. great work

[lmhmm]

@sdetweil I really don’t understand the answer so will just wait for the next release. Or do I just hit pull the default calendar module? Not sure how to apply fix.

[kai]

Hi @DaveChild, @sdetweil,
thank you very much for your effort and your research!!!
I’ll use @DaveChild’s prefix solution until the next release; the custom icons are now displayed within the calendar.
Many, many thanks to you and all who so tirelessly develop the MM and keep it alive!
May the code be with you
-kai

[sdetweil]

@lmhmm you cannot just update one default module. it’s all or nothing.

mm uses the git source code mgmt system

this provides for different version of code concurrently.
mm uses the master branch as the current running code
and the develop branch to accumulate updates between releases.

if u follow the steps in the test fixes topic

https://forum.magicmirror.builders/topic/14327/testing-new-fixes-or-solving-current-problems-with-next-release-code

you can pull down the develop branch and try it out.

if you don’t know what this means and cannot try it then u have to wait. mm releases a new version every 90 days

[karsten13]

@sdetweil said in v2.22.0 | default calendar: no symbols with customEvents:

you can pull down the develop branch and try it out.

the fix is not on develop because it is not merged yet but it should not take a long time …

[lmhmm]

@karsten13 Thanks I’ll wait for the solution rather than totally mess my mirror up …

[karsten13]

@lmhmm

meanwhile the fix is merged on develop. You can try the develop branch or wait for official release in April.

[lmhmm]

@karsten13 I don’t understand your responses as they are not accompanied by any instructions so for now to avoid disaster I’ll wait thanks.

[sdetweil]

@lmhmm at the top of the troubleshooting section are instructions for using the develop branch to test fixes pending future delivery

https://forum.magicmirror.builders/topic/14327/testing-new-fixes-or-solving-current-problems-with-next-release-code

if you use my upgrade script to migrate versions. it will detect develop branch being active and switch back to mater

[lmhmm]

@sdetweil

SOLVED! Upgraded to 2.22.0 then put the fa/fas bit after symbol. It works again as before. Phweee! Just for the clueless like me!