v2.22.0 | default calendar: no symbols with customEvents

[sdetweil]

@kai no, exactly as I posted. are you sure those are the phrases in your calendar subject?

I had a problem once before, and had Two spaces between words in the calendar event, and only one in the events stucture…

[DaveChild]

I’ve been having the same problem. In mine the fas fa-fw fa- prefix was missing, so I changed my config to this:

customEvents: [
    {keyword: "Games", symbol: "dice fas fa-fw fa-dice"},
    {keyword: "Rugby", symbol: "running fas fa-fw fa-running"},
    {keyword: "Guitar", symbol: "guitar fas fa-fw fa-guitar"}
],

I duplicated the “dice” at the start so it keeps working when the bug is fixed. And the icons appear now.

[sdetweil]

@DaveChild hm… that is the symbolPrefix variable in 2.22

[DaveChild]

@sdetweil I’ve not delved far into the code but it looks to me like the symbolsForEvent function in calendar.js is getting the default symbol with the default class, but then overwriting that default with the symbol from customerEvents - but not applying the default class to it.

This might be fixed with applying this.getCalendarPropertyAsArray to ev.symbol in the line symbols[0] = ev.symbol;.

I’d do a PR myself but I have nowhere near enough experience tinkering with MagicMirror to be pushing code to a default module :). But I think that’s where the problem is, and my solution will work around that issue crudely for the moment.

[sdetweil]

@DaveChild cool. I’ll give that a look

[DaveChild]

@sdetweil I did a quick PR anyway, even if it’s not perfect, it’s better there’s a starting point for a fix than make someone repeat tracking it down to where I got to.

[lmhmm]

@sdetweil Yes I’ve got the same issue after upgrading to 2.22 no symbols even trying solution here. Be nice to get this resolved

[sdetweil]

@lmhmm Dave found it and provided a fix for next release. (April 1)

you could look at what he did and change your code,

of git pull and check the develop branch. see the instructions pinned to the top of this topic about testing fixes.

[sdetweil]

@DaveChild awesome. I saw all the GitHub traffic. great work

[lmhmm]

@sdetweil I really don’t understand the answer so will just wait for the next release. Or do I just hit pull the default calendar module? Not sure how to apply fix.