MMM-SystemMonitor

btastic

@BKeyport I will probably take a thing or two, but I think the code can be written a bit better by todays standards. The project is almost 6 years old and was probably refactored a few times. No offense towards @MMRIZE - thats probably one reason he does not want to develop it further without rewriting it.

MMRIZE

@btastic You are right. Cheer up for your work!
I wish a new module which can be more flexible and modular with modern techniques, and especially, not dedicated to RPI(recently I never work with it), but I have not enough time and interest to do so…

btastic

@MMRIZE Thank you.

I want to make it OS independant too, but that will be a bit harder I think. I don’t have that much time either. But will work on it in the foreseeable future.

Richard238

Installed, added to config.js

		{
            module: 'MMM-SystemMonitor',
            position: 'bottom_right',
            config: {
                updateInterval: 60000,
                cpuThermalZone: 0,
                units: config.units,
            }
        },

MM fails to load.
Comment those lines out, MM is OK. What have I missed?

sdetweil

@Richard238 what is the end of the last prior module

Richard238

@sdetweil

It’s the currently misbehaving weather forecast:

		{
			module: 'weather',
			position: 'top_right',
			header: 'Weather Forecast for: ',
			config: {
				type: 'forecast',
				location: 'nnnnnnnnn',
				locationID: '11111111',  //ID from https://www.openweathermap.org
				apiKey: 'aaaa444444444444444444'
			}
		},

		//{
            //module: 'MMM-SystemMonitor',
            //position: 'bottom_right',
            //config: {
                //updateInterval: 60000,

sdetweil

@Richard238 what is the error?

npm run config:check

Richard238

@sdetweil said in MMM-SystemMonitor:

npm run config:check

pi@mmv2:~ $ npm run config:check 
npm error code ENOENT
npm error syscall open
npm error path /home/pi/package.json
npm error errno -2
npm error enoent Could not read package.json: Error: ENOENT: no such file or directory, open '/home/pi/package.json'
npm error enoent This is related to npm not being able to find a file.
npm error enoent
npm error A complete log of this run can be found in: /home/pi/.npm/_logs/2025-02-02T19_09_35_627Z-debug-0.log
pi@mmv2:~ $

sdetweil

@Richard238 in the MagicMirror folder

Richard238

@sdetweil

[2025-02-02 21:35:32.330] [INFO]  Checking modules structure configuration ... 
[2025-02-02 21:35:32.511] [ERROR] Cannot read properties of undefined (reading 'units')

Module says:

units: config.units,

And also tried with

units: metric,

Which failed with:

[ERROR] metric is not defined

config.js towards the beginning says:

units: 'metric',