MMM-SystemMonitor

[BKeyport]

@btastic to double down on what @MMRIZE said - taking over someone else’s archived module is an exceptional way to learn how to do things. I Would highly encourage it, as the author has directly said he’s okay with it. I did that with a module myself. Taught me so much about javascript working out bugs in an existing module and adding my own flair (and I really should get back on it for one bit…)

[btastic]

@BKeyport I will probably take a thing or two, but I think the code can be written a bit better by todays standards. The project is almost 6 years old and was probably refactored a few times. No offense towards @MMRIZE - thats probably one reason he does not want to develop it further without rewriting it.

[MMRIZE]

@btastic You are right. Cheer up for your work!
I wish a new module which can be more flexible and modular with modern techniques, and especially, not dedicated to RPI(recently I never work with it), but I have not enough time and interest to do so…

[btastic]

@MMRIZE Thank you.

I want to make it OS independant too, but that will be a bit harder I think. I don’t have that much time either. But will work on it in the foreseeable future.

[Richard238]

Installed, added to config.js

		{
            module: 'MMM-SystemMonitor',
            position: 'bottom_right',
            config: {
                updateInterval: 60000,
                cpuThermalZone: 0,
                units: config.units,
            }
        },

MM fails to load.
Comment those lines out, MM is OK. What have I missed?

[sdetweil]

@Richard238 what is the end of the last prior module

[Richard238]

@sdetweil

It’s the currently misbehaving weather forecast:

		{
			module: 'weather',
			position: 'top_right',
			header: 'Weather Forecast for: ',
			config: {
				type: 'forecast',
				location: 'nnnnnnnnn',
				locationID: '11111111',  //ID from https://www.openweathermap.org
				apiKey: 'aaaa444444444444444444'
			}
		},

		//{
            //module: 'MMM-SystemMonitor',
            //position: 'bottom_right',
            //config: {
                //updateInterval: 60000,

[sdetweil]

@Richard238 what is the error?

npm run config:check

[Richard238]

@sdetweil said in MMM-SystemMonitor:

npm run config:check

pi@mmv2:~ $ npm run config:check 
npm error code ENOENT
npm error syscall open
npm error path /home/pi/package.json
npm error errno -2
npm error enoent Could not read package.json: Error: ENOENT: no such file or directory, open '/home/pi/package.json'
npm error enoent This is related to npm not being able to find a file.
npm error enoent
npm error A complete log of this run can be found in: /home/pi/.npm/_logs/2025-02-02T19_09_35_627Z-debug-0.log
pi@mmv2:~ $ 

[sdetweil]

@Richard238 in the MagicMirror folder

[Richard238]

@sdetweil

[2025-02-02 21:35:32.330] [INFO]  Checking modules structure configuration ... 
[2025-02-02 21:35:32.511] [ERROR] Cannot read properties of undefined (reading 'units') 

Module says:

units: config.units,

And also tried with

units: metric,

Which failed with:

[ERROR] metric is not defined 

config.js towards the beginning says:

units: 'metric',

[sdetweil]

@Richard238 to the right of :

Numbers and true/false do not need quotes
Any thing that has a letter needs quotes

[Richard238]

@sdetweil

I don’t understand, sorry?

[sdetweil]

@Richard238 in config.js all properties are

name : value

The value, to the right of the colon (:)
If a number or tr/false
Does not need quotes

If it contains a letter or symbol
It needs quotes

units : metric
To the right is metric
It has letters, so needs quotes

[Richard238]

@sdetweil

That’s fixed it.

Module in config.js

units: 'config.units'

config.js before modules

was

units: 'metric',

Changed it to

units: "metric",

Quite how Free Memory can be 128% I’ve no idea, that’s for another day.
For now, it’s working. Thank you!

[sdetweil]

@Richard238 cool. Single or double quotes don’t matter as long as they are matched

Be careful on quotes and copying from the forum

If the quotes are curved, they are word processing style and Javascript doesn’t understand them
" or ’

If they are vertical, they are good

" or  '

[Richard238]

@sdetweil said in MMM-SystemMonitor:

Single or double quotes don’t matter as long as they are matched

JS lesson #1 :-)

[mebster5]

@btastic

I’m new to MM and just been putting together my board over the last week.

I’ve used your module and think it’s great.

One thing I did find is that your default way of grabbing diskspace had the device hard coded.

I made this change to node_helper.js:

async.apply(exec, "df -h /|grep dev|awk '{print $4}'"),

That looked for the root partition and was able to then return the correct value for me.

[sdetweil]

@mebster5 submit that as a pr