Update is not working..I need help please

Stoffbeuteluwe

> magicmirror@2.25.0 start
> DISPLAY="${DISPLAY:=:0}" ./node_modules/.bin/electron js/electron.js

[09.10.2023 21:11.47.231] [LOG]   Starting MagicMirror: v2.25.0
[09.10.2023 21:11.47.231] [LOG]   Loading config ...
[09.10.2023 21:11.47.232] [DEBUG] config template file not exists, no envsubst
[09.10.2023 21:11.47.233] [LOG]   Loading module helpers ...
[09.10.2023 21:11.47.233] [LOG]   No helper found for module: alert.
[09.10.2023 21:11.47.257] [LOG]   Initializing new module helper ...
[09.10.2023 21:11.47.257] [LOG]   Module helper loaded: MMM-Remote-Control
[09.10.2023 21:11.47.258] [LOG]   Initializing new module helper ...
[09.10.2023 21:11.47.258] [LOG]   Module helper loaded: updatenotification
[09.10.2023 21:11.47.258] [LOG]   No helper found for module: MMM-Snow.
[09.10.2023 21:11.47.258] [LOG]   No helper found for module: MMM-MyWordClock.
[09.10.2023 21:11.47.258] [LOG]   No helper found for module: clock.
[09.10.2023 21:11.47.258] [LOG]   No helper found for module: calendar_monthly.
[09.10.2023 21:11.47.275] [LOG]   Initializing new module helper ...
[09.10.2023 21:11.47.275] [LOG]   Module helper loaded: calendar
[09.10.2023 21:11.47.276] [ERROR] (node:78446) UnhandledPromiseRejectionWarning: Error: Cannot find module 'fetch'
Require stack:
- /Users/patrickhahn/MM/modules/MMM-MyCalendar/calendarfetcher.js
- /Users/patrickhahn/MM/modules/MMM-MyCalendar/node_helper.js
- /Users/patrickhahn/MM/js/app.js
- /Users/patrickhahn/MM/js/electron.js
- /Users/patrickhahn/MM/node_modules/electron/dist/Electron.app/Contents/Resources/default_app.asar/main.js
- 
    at node:internal/modules/cjs/loader:1084:15
    at Function.<anonymous> (node:electron/js2c/browser_init:2:117419)
    at Module._resolveFilename (/Users/patrickhahn/MM/node_modules/module-alias/index.js:49:29)
    at node:internal/modules/cjs/loader:929:27
    at Function._load (node:electron/js2c/asar_bundle:2:13327)
    at Module.require (node:internal/modules/cjs/loader:1150:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at Object.<anonymous> (/Users/patrickhahn/MM/modules/MMM-MyCalendar/calendarfetcher.js:11:15)
    at Module._compile (node:internal/modules/cjs/loader:1271:14)
    at Object..js (node:internal/modules/cjs/loader:1326:10)
    at Module.load (node:internal/modules/cjs/loader:1126:32)
    at node:internal/modules/cjs/loader:967:12
    at Function._load (node:electron/js2c/asar_bundle:2:13327)
    at Module.require (node:internal/modules/cjs/loader:1150:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at Object.<anonymous> (/Users/patrickhahn/MM/modules/MMM-MyCalendar/node_helper.js:8:25)
(Use `Electron --trace-warnings ...` to show where the warning was created)
[09.10.2023 21:11.47.276] [ERROR] (node:78446) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
2023-10-09 21:11:47.294 Electron[78446:1242307] WARNING: Secure coding is not enabled for restorable state! Enable secure coding by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState: and returning YES.
/Users/patrickhahn/MM/node_modules/electron/dist/Electron.app/Contents/MacOS/Electron exited with signal SIGINT

sdetweil

@Stoffbeuteluwe said in Update is not working..I need help please:

Cannot find module ‘fetch’

yes, and the module doesn’t provide a package.json, so npm install can’t fix it…

BUT fetch is provided in the base node 18 and 20… SO

edit the
/Users/patrickhahn/MM/modules/MMM-MyCalendar/calendarfetcher.js

and comment out the line (11) , by adding // to the start of the line

const fetch = require("fetch");

Stoffbeuteluwe

@sdetweil
i have done this

/* MagicMirror²
 * Node Helper: Calendar - CalendarFetcher
 *
 * By Michael Teeuw https://michaelteeuw.nl
 * MIT Licensed.
 */
const CalendarUtils = require("./calendarutils");
const Log = require("logger");
const NodeHelper = require("node_helper");
const ical = require("node-ical");
//const fetch = require("fetch");
const digest = require("digest-fetch");
const https = require("https");

/**
 *
 * @param {string} url The url of the calendar to fetch
 * @param {number} reloadInterval Time in ms the calendar is fetched again
 * @param {string[]} excludedEvents An array of words / phrases from event titles that will be excluded from being shown.
 * @param {number} maximumEntries The maximum number of events fetched.
 * @param {number} maximumNumberOfDays The maximum number of days an event should be in the future.
 * @param {object} auth The object containing options for authentication against the calendar.
 * @param {boolean} includePastEvents If true events from the past maximumNumberOfDays will be fetched too
 * @param {boolean} selfSignedCert If true, the server certificate is not verified against the list of supplied CAs.
 * @class
 */

but it still does not work

sdetweil

@Stoffbeuteluwe you are on the wrong level of code

neither are there in 2.25

do

cd ~/MagicMirror
git checkout modules/default/calendar/calendarfetcher.js

then

git status

show the results

karsten13

@sdetweil

MMM-MyCalendar is a mess, the author copied (meanwhile old) versions of our code into his repo, so the problem is calendarfetcher.js of the module.

Stoffbeuteluwe

@sdetweil said in Update is not working..I need help please:

git status

patrickhahn@Mac-mini MM % git checkout modules/default/calendar/calendarfetcher.js
Updated 0 paths from the index
patrickhahn@Mac-mini MM % git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	css/icons/
	new_package.json
	run-start.sh

nothing added to commit but untracked files present (use "git add" to track)
patrickhahn@Mac-mini MM %

sdetweil

@Stoffbeuteluwe ok, now do

cd ~/MagicMirror
git pull
npm run install-mm

Stoffbeuteluwe

@sdetweil it is still the same problem…

sdetweil

@Stoffbeuteluwe can you show me the output of

git status
git pull

Stoffbeuteluwe

@sdetweil

patrickhahn@Mac-mini MM % git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	css/icons/
	new_package.json
	run-start.sh

nothing added to commit but untracked files present (use "git add" to track)
patrickhahn@Mac-mini MM % git pull
Already up to date.
patrickhahn@Mac-mini MM % patrickhahn@Mac-mini MM % git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        css/icons/
        new_package.json
        run-start.sh

nothing added to commit but untracked files present (use "git add" to track)
patrickhahn@Mac-mini MM %