Read the statement by Michael Teeuw here.
Automatic checking of all MagicMirror² modules
-
@Jalibu said in Automatic checking of all MagicMirror² modules:
hmm… if this is the cornerstone for a proper MagicMirror Appstore, then I should consider renaming all my modules to start with the letter “A” to attract more attention on the landing page :-D
Yeah, I’m already have some ideas about the default sort order (like a combination of stars, issues and activity), this will prevent that :beaming_face_with_smiling_eyes:
-
In the last few days I have worked on some details on the site. So if you’re interested, take a look: https://kristjanesperanto.github.io/MagicMirror-3rd-Party-Modules/.
And there is now a little statistics table on the results page: https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/blob/main/result.md#statistics
I have also created a few PRs based on the list for some modules. Most of them have already been accepted :-)
-
@KristjanESPERANTO Looks good. Just out of interest, which image does it select as the thumbnail? Just noticed 2 of the modules of mines does not have the correct images. Both Growatt modules are the ones I am referring to.
-
@KristjanESPERANTO Stats were great, fixed most of the issues identified in my modules. Majority package.json issues.
Great work @KristjanESPERANTO
-
could we separate out the cosmetic issues (MagicMirror vs the one with the superscript 2, as I don’t know how to make that happen in my text editor…) and its useless
and this is misleading
MMM-AareGuru by buge There is no package.json. We need this file to gather information about the module.there is no need for a package,json… as this module does all its work inside the modulename.js
there is no functional requirement as there is no node_helper.js -
@KristjanESPERANTO
additionally… a module I forked was marked as present and attributed to me, but I never posted it… MMM-Alexa (and I deleted it from your list… and it is NOT present in the master list )and one of my modules (the only one I have ever posted) is not present in the master list , and I did not remove it
MMM-SleepWake.
-
@mumblebaj said in Automatic checking of all MagicMirror² modules:
Just out of interest, which image does it select as the thumbnail?
If the script doesn’t find an image with ‘screenshot’ or ‘example’ at the beginning of the name it takes the first it finds .
The prerequisite for the whole thing is that a free license is specified in the
package.json. If there is nopackage.jsonand no free license, no image will be searched.Stats were great, fixed most of the issues identified in my modules.
Nice, thank you! I just updated the list and a lot of issues disappeared 👏
@sdetweil said in Automatic checking of all MagicMirror² modules:
I don’t know how to make that happen in my text editor
On my keyboard it’s just +
and its useless
I think it’s worth striving to call things by their proper names, so I don’t find the test useless. Feel free to just ignore it :-)
there is no need for a package,json… as this module does all its work inside the modulename.js there is no functional requirement
You are right, functionally there is no need for this. However, the file is a good source of information that is interesting for the website - e.g. keywords.
MMM-Alexa
Do you know if the original module (https://github.com/sakirtemel/MMM-alexa) still works? Otherwise I should mark it as outdated.
and one of my modules (the only one I have ever posted) is not present in the master list , and I did not remove it. MMM-SleepWake
I’ve added it now :-)
-
@KristjanESPERANTO I have no info on MMM-Alexa or why i forked it
-
@sdetweil said in Automatic checking of all MagicMirror² modules:
and this is misleading
There is no package.json. We need this file to gather information about the module.I added ‘for the website’ at the end of the sentence. I hope that this is clearer.
Thanks for the feedback :-)
-
@KristjanESPERANTO I have no website.
