MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Automatic checking of all MagicMirror² modules

    Scheduled Pinned Locked Moved Development
    83 Posts 9 Posters 83.9k Views 10 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • BKeyportB Offline
      BKeyport Module Developer @KristjanESPERANTO
      last edited by

      @KristjanESPERANTO You know, this is turning more and more into a NPM type project.

      Perhaps it’s time to work on getting MM into the NPM ecosystem instead?

      The "E" in "Javascript" stands for "Easy"

      S karsten13K 2 Replies Last reply Reply Quote 0
      • S Offline
        sdetweil @BKeyport
        last edited by

        @BKeyport mm is already there but old

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        1 Reply Last reply Reply Quote 0
        • karsten13K Offline
          karsten13 @BKeyport
          last edited by

          @BKeyport

          see https://github.com/MichMich/MagicMirror/issues/2876

          S 1 Reply Last reply Reply Quote 0
          • S Offline
            sdetweil @karsten13
            last edited by

            @karsten13

            https://www.npmjs.com/package/magicmirror

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            BKeyportB 1 Reply Last reply Reply Quote 0
            • BKeyportB Offline
              BKeyport Module Developer @sdetweil
              last edited by

              I’ve over simplified as I tend to do.

              What I was thinking of was more along the lines of how Homebridge is doing things. Full on NPM integrations across the board. GUI installer/maintainer. bonus points for GUI configuration tool on their “plugins” etc. Can still get into the weeds if you want to mess with operations under the hood.

              I honestly think it’s time, but I’ve got nowhere near the skill to do it.
              MMM-Config on steroids.

              The pieces are there - we’re just missing the core.

              https://github.com/homebridge/homebridge-raspbian-image/wiki/Getting-Started#step-5-install-and-configure-plugins

              Setting the core up would build in a natural module checking system and weed out the unmaintained stuff for new users, because new users won’t want to install stuff that has no GUI settings and/or unmaintained wouldn’t show in the official repository/search anymore.

              The "E" in "Javascript" stands for "Easy"

              karsten13K 1 Reply Last reply Reply Quote 0
              • karsten13K Offline
                karsten13 @BKeyport
                last edited by

                @BKeyport

                sounds pretty much like what mmpm does

                S 1 Reply Last reply Reply Quote 0
                • S Offline
                  sdetweil @karsten13
                  last edited by sdetweil

                  @karsten13 mmpm doesn’t do config editing
                  and to do config editing in a reliable way, we need programming standards too.

                  Sam

                  How to add modules

                  learning how to use browser developers window for css changes

                  BKeyportB 1 Reply Last reply Reply Quote 0
                  • BKeyportB Offline
                    BKeyport Module Developer @sdetweil
                    last edited by

                    @sdetweil We already have some standards in place (node_helper.js, naming conventions, package.json, etc) - what’s one more (config-schema.json) for the programmer? Think along the lines of the schema.json file used in MMM-Config.

                    Programmer creates the GUI settings page, using API into a specific file. It’s up to the core to insert result into the main config file. if GUI file isn’t there, then resort to a web based editor.

                    https://github.com/homebridge/homebridge/wiki/Verified-Plugins describes the process in homebridge’s case. Provide a reward, and bam - We’ve got easier access to the project, making it more widespread, and it completely eclipses the automatic checking process here.

                    Reward for the programmer is rather simple. A badge set thusly - everywhere - in the built in plugin manager’s search, on websites, etc. 725c9b2e-1442-4642-b75e-141f393a87f4-image.png

                    Example - No GUI settings page file (the dead module): 497832aa-62f3-4bf5-aee0-9475eed1cee0-image.png

                    Example - GUI settings page file (my reworked module with more functionality):
                    5e94c71f-2419-4ac8-bdcc-1c48f867acef-image.png

                    and the resulting config (I believe they use JSON rather than JS):
                    63f41904-ff06-4146-9a49-d1988b1bb237-image.png

                    The "E" in "Javascript" stands for "Easy"

                    S 1 Reply Last reply Reply Quote 0
                    • S Offline
                      sdetweil @BKeyport
                      last edited by

                      @BKeyport I believe we use js because you can have comments, json does not support comments

                      Sam

                      How to add modules

                      learning how to use browser developers window for css changes

                      BKeyportB 1 Reply Last reply Reply Quote 0
                      • BKeyportB Offline
                        BKeyport Module Developer @sdetweil
                        last edited by

                        @sdetweil It don’t matter how it’s done, honestly. JS, JSON - Same diff in my book… I’d just love to see it get simpler, and wrap up some of these projects into one.

                        The "E" in "Javascript" stands for "Easy"

                        S 1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 3
                        • 4
                        • 5
                        • 6
                        • 7
                        • 8
                        • 9
                        • 6 / 9
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy