MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    MMM-PGA Not Working

    Scheduled Pinned Locked Moved Sport
    13 Posts 4 Posters 1.8k Views 4 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • D Offline
      dathbe @mumblebaj
      last edited by

      @mumblebaj i posted an issue with a fix in your repository. do you mind taking a look so we can merge the two lines?
      https://github.com/mumblebaj/MMM-PGA/issues/2

      mumblebajM 2 Replies Last reply Reply Quote 0
      • mumblebajM Offline
        mumblebaj Module Developer @dathbe
        last edited by

        @dathbe Hi. Unfortunately I did not get those notifications. You can submit a PR and I will review for you.

        Check out my modules at: https://github.com/mumblebaj?tab=repositories
        Check my blog-post: https://mumblebaj.xyz/

        D 1 Reply Last reply Reply Quote 0
        • D Offline
          dathbe @mumblebaj
          last edited by

          @mumblebaj No problem. I had the same problem on my repositories until I realized that I have to actively sign up for alerts. You can do that by clicking on the “Watch” icon at the top of the repository page, and then clicking either “All Activity” or “Custom” (and then selecting “Issues” and Pull Requests").

          I’ve submitted a PR.

          I will also submit a couple others to fix some console errors and get rid of the node-fetch dependency, though those issues are not breaking, so less important.

          mumblebajM 2 Replies Last reply Reply Quote 0
          • mumblebajM Offline
            mumblebaj Module Developer @dathbe
            last edited by

            @dathbe I have updated and pushed update v1.3.2. Please test and advise.

            Check out my modules at: https://github.com/mumblebaj?tab=repositories
            Check my blog-post: https://mumblebaj.xyz/

            1 Reply Last reply Reply Quote 0
            • mumblebajM Offline
              mumblebaj Module Developer @dathbe
              last edited by

              @dathbe I replaced node-fetch a while back. Maybe do a git pull first.

              Check out my modules at: https://github.com/mumblebaj?tab=repositories
              Check my blog-post: https://mumblebaj.xyz/

              1 Reply Last reply Reply Quote 0
              • mumblebajM Offline
                mumblebaj Module Developer @dathbe
                last edited by

                @dathbe I have cleaned up a bit of the old code and done some changes. Before submitting the PR, do a git pull and test first.

                Check out my modules at: https://github.com/mumblebaj?tab=repositories
                Check my blog-post: https://mumblebaj.xyz/

                mumblebajM 1 Reply Last reply Reply Quote 0
                • mumblebajM Offline
                  mumblebaj Module Developer @mumblebaj
                  last edited by

                  Handing over the module

                  I have recently not had time to look after this module and I think that @dathbe will do a much better job looking after the module going forward.

                  Here is a link to his fork: MMM-PGA. I have updated the 3rd Party Modules to point to his fork.

                  I will archive my fork of the module this weekend.

                  Check out my modules at: https://github.com/mumblebaj?tab=repositories
                  Check my blog-post: https://mumblebaj.xyz/

                  1 Reply Last reply Reply Quote 1
                  • 1
                  • 2
                  • 2 / 2
                  • First post
                    Last post
                  Enjoying MagicMirror? Please consider a donation!
                  MagicMirror created by Michael Teeuw.
                  Forum managed by Sam, technical setup by Karsten.
                  This forum is using NodeBB as its core | Contributors
                  Contact | Privacy Policy