Read the statement by Michael Teeuw here.
birthdaylist - discontinued ?
-
@sdetweil
:-) yes for sure.
But I had assumed that the already given output (from other modules as well) will change … -
@rkorell i added some debug for suspending, resuming, and getdom() if suspended
git pull to update
add debug:true
to the config optionsyou will see the output from mmm-logging
who calls before we suspend ?
-
@sdetweil said i added some debug for suspending, resuming, and getdom() if suspended
git pull to update
add debug:true
to the config optionsyou will see the output from mmm-logging
who calls before we suspend ?
Dear Sam,
thanks a lot.pi@smarthome:~/MagicMirror/modules/birthdaylist $ git pull hint: Pulling without specifying how to reconcile divergent branches is hint: discouraged. You can squelch this message by running one of the following hint: commands sometime before your next pull: hint: hint: git config pull.rebase false # merge (the default strategy) hint: git config pull.rebase true # rebase hint: git config pull.ff only # fast-forward only hint: hint: You can replace "git config" with "git config --global" to set a default hint: preference for all repositories. You can also pass --rebase, --no-rebase, hint: or --ff-only on the command line to override the configured default per hint: invocation. remote: Enumerating objects: 5, done. remote: Counting objects: 100% (5/5), done. remote: Compressing objects: 100% (1/1), done. remote: Total 3 (delta 2), reused 3 (delta 2), pack-reused 0 (from 0) Unpacking objects: 100% (3/3), 419 bytes | 32.00 KiB/s, done. From https://github.com/sdetweil/birthdaylist 0fcfb8c..0c16aeb master -> origin/master Updating 0fcfb8c..0c16aeb Fast-forward birthdaylist.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
git pull has worked, debug is enabled.
Surprisingly enough today in the morning birthdaylist is NOT disappeared.
This exactly is the kind of error I like most: Unpredictable and not reproducable :-(Thanks anyway for your really great support (I’m pretty sure you do have more than enough other things to do …)
Checking the console output the “debug” switch works - a lot more of information is showing up.
Several module notifications are received from your module and broadcasted in log.
One single “conspicuousness”: undefined is in init! in line 48 of birthdaylist.js :(Log.log(this.name + " is in init!");)
The “suspended” status (and therefore “hidden” (??) ) is reached several times - I guess caused by MMM-Pir ? - at least it corresponds definitely with turning off the screen by MMM-Pir.
Warmest regards,
Ralf -
The suspending call seems indeed to come from MMM-Pir.
But there is always a resuming…birthdaylist received a module notification: MMM_PIR-SCREEN_POWERSTATUS from sender: MMM-Pir birthdaylist.js:337 birthdaylist suspending birthdaylist.js:108 birthdaylist received a module notification: CURRENTWEATHER_TYPE from sender: weather birthdaylist.js:108 birthdaylist received a module notification: WEATHER_UPDATED from sender: weather birthdaylist.js:108 birthdaylist received a module notification: WEATHER_UPDATED from sender: weather birthdaylist.js:108 birthdaylist received a module notification: CURRENTWEATHER_TYPE from sender: weather birthdaylist.js:108 birthdaylist received a module notification: WEATHER_UPDATED from sender: weather birthdaylist.js:108 birthdaylist received a module notification: WEATHER_UPDATED from sender: weather birthdaylist.js:108 birthdaylist received a module notification: CALL_DISCONNECTED from sender: MMM-FRITZ-Box-Callmonitor-py3 birthdaylist.js:108 birthdaylist received a module notification: MMM_PIR-SCREEN_POWERSTATUS from sender: MMM-Pir birthdaylist.js:345 birthdaylist resuming birthdaylist.js:108 birthdaylist received a module notification: CURRENTWEATHER_TYPE from sender: weather birthdaylist.js:108 birthdaylist received a module notification: WEATHER_UPDATED from sender: weather birthdaylist.js:108 birthdaylist received a module notification: WEATHER_UPDATED from sender: weather birthdaylist.js:337 birthdaylist suspending 2birthdaylist.js:108 birthdaylist received a module notification: MMM_PIR-SCREEN_POWERSTATUS from sender: MMM-Pir birthdaylist.js:345 birthdaylist resuming
I assume that we have to wait until birthdaylist disappears and then check the written logs afterwards if there is something different (I guess: NOT :-(. )
Regards,
Ralf -
@rkorell right we have to wait, thanks for the great info
ill look at the init time message
-
@rkorell notifications are broadcast. so every module gets every broadcast.
thats why you have to check if the broadcast is for you , but logging them all can give an idea what is going on.
if clock seconds was enabled you would see a notification for that too
-
@sdetweil clock seconds are enabled, as far as I know …
at least I haven’t found a parameter to enable/disable seconds
and second hand is shown … -
@rkorell you are using the analog clock, not digital
this for digital
displaySeconds Display seconds. Possible values: true or false Default value: true
and I didn’t see this change
sendNotifications Enable notifications for elapsed time. Used to be always done send prio to v2.23 Possible values: true, or false Default value: false
-
@sdetweil Yeah…
You’re right.
I’ve set this - my type of clock is set to “both” because I like sunset and day of week information.This causes an error in your module…
birthdaylist.js:398 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'startsWith') at Class.getBD_DAY_from_Date (birthdaylist.js:398:9) at Class.getDom (birthdaylist.js:462:154) at main.js:132:35 at new Promise (<anonymous>) at updateDom (main.js:112:10) at Object.updateDom (main.js:669:4) at Class.updateDom (module.js:341:6) at Class.socketNotificationReceived (birthdaylist.js:328:9) at module.js:240:9 at Socket.<anonymous> (socketclient.js:32:4)
Not sure if this corresponds with the displaySeconds parameter but seen this error first time…
Regards,
Ralf -
No, obviously NOT…
I’ve now added “sendNotifications: true” to config.
Mirror reloads and your module starts without this error message.