birthdaylist - discontinued ?

rkorell

Dear Sam @sdetweil ,
no hurry.
It is definitely not urgent!

Have a safe trip!
I’ve added MMM-logging but cannot see a difference …

Warmest regards,
Ralf

sdetweil

@rkorell have not added messages yet

rkorell

@sdetweil
:-) yes for sure.
But I had assumed that the already given output (from other modules as well) will change …

sdetweil

@rkorell i added some debug for suspending, resuming, and getdom() if suspended

git pull to update

add debug:true
to the config options

you will see the output from mmm-logging

who calls before we suspend ?

rkorell

@sdetweil said i added some debug for suspending, resuming, and getdom() if suspended

git pull to update

add debug:true
to the config options

you will see the output from mmm-logging

who calls before we suspend ?

Dear Sam,
thanks a lot.

pi@smarthome:~/MagicMirror/modules/birthdaylist $ git pull
hint: Pulling without specifying how to reconcile divergent branches is
hint: discouraged. You can squelch this message by running one of the following
hint: commands sometime before your next pull:
hint: 
hint:   git config pull.rebase false  # merge (the default strategy)
hint:   git config pull.rebase true   # rebase
hint:   git config pull.ff only       # fast-forward only
hint: 
hint: You can replace "git config" with "git config --global" to set a default
hint: preference for all repositories. You can also pass --rebase, --no-rebase,
hint: or --ff-only on the command line to override the configured default per
hint: invocation.
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (1/1), done.
remote: Total 3 (delta 2), reused 3 (delta 2), pack-reused 0 (from 0)
Unpacking objects: 100% (3/3), 419 bytes | 32.00 KiB/s, done.
From https://github.com/sdetweil/birthdaylist
   0fcfb8c..0c16aeb  master     -> origin/master
Updating 0fcfb8c..0c16aeb
Fast-forward
 birthdaylist.js | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

git pull has worked, debug is enabled.
Surprisingly enough today in the morning birthdaylist is NOT disappeared.
This exactly is the kind of error I like most: Unpredictable and not reproducable :-(

Thanks anyway for your really great support (I’m pretty sure you do have more than enough other things to do …)

Checking the console output the “debug” switch works - a lot more of information is showing up.
Several module notifications are received from your module and broadcasted in log.
One single “conspicuousness”: undefined is in init! in line 48 of birthdaylist.js :

(Log.log(this.name + " is in init!");)

The “suspended” status (and therefore “hidden” (??) ) is reached several times - I guess caused by MMM-Pir ? - at least it corresponds definitely with turning off the screen by MMM-Pir.

Warmest regards,
Ralf

rkorell

The suspending call seems indeed to come from MMM-Pir.
But there is always a resuming…

birthdaylist received a module notification: MMM_PIR-SCREEN_POWERSTATUS from sender: MMM-Pir
birthdaylist.js:337 birthdaylist suspending
birthdaylist.js:108 birthdaylist received a module notification: CURRENTWEATHER_TYPE from sender: weather
birthdaylist.js:108 birthdaylist received a module notification: WEATHER_UPDATED from sender: weather
birthdaylist.js:108 birthdaylist received a module notification: WEATHER_UPDATED from sender: weather
birthdaylist.js:108 birthdaylist received a module notification: CURRENTWEATHER_TYPE from sender: weather
birthdaylist.js:108 birthdaylist received a module notification: WEATHER_UPDATED from sender: weather
birthdaylist.js:108 birthdaylist received a module notification: WEATHER_UPDATED from sender: weather
birthdaylist.js:108 birthdaylist received a module notification: CALL_DISCONNECTED from sender: MMM-FRITZ-Box-Callmonitor-py3
birthdaylist.js:108 birthdaylist received a module notification: MMM_PIR-SCREEN_POWERSTATUS from sender: MMM-Pir
birthdaylist.js:345 birthdaylist resuming
birthdaylist.js:108 birthdaylist received a module notification: CURRENTWEATHER_TYPE from sender: weather
birthdaylist.js:108 birthdaylist received a module notification: WEATHER_UPDATED from sender: weather
birthdaylist.js:108 birthdaylist received a module notification: WEATHER_UPDATED from sender: weather
birthdaylist.js:337 birthdaylist suspending
2birthdaylist.js:108 birthdaylist received a module notification: MMM_PIR-SCREEN_POWERSTATUS from sender: MMM-Pir
birthdaylist.js:345 birthdaylist resuming

I assume that we have to wait until birthdaylist disappears and then check the written logs afterwards if there is something different (I guess: NOT :-(. )

Regards,
Ralf

sdetweil

@rkorell right we have to wait, thanks for the great info

ill look at the init time message

sdetweil

@rkorell notifications are broadcast. so every module gets every broadcast.

thats why you have to check if the broadcast is for you , but logging them all can give an idea what is going on.

if clock seconds was enabled you would see a notification for that too

rkorell

@sdetweil clock seconds are enabled, as far as I know …
at least I haven’t found a parameter to enable/disable seconds
and second hand is shown …

sdetweil

@rkorell you are using the analog clock, not digital

this for digital

displaySeconds	Display seconds.

Possible values: true or false
Default value: true

and I didn’t see this change

sendNotifications	Enable notifications for elapsed time. Used to be always done send prio to v2.23

Possible values: true, or false
Default value: false

rkorell

@sdetweil Yeah…
You’re right.
I’ve set this - my type of clock is set to “both” because I like sunset and day of week information.

This causes an error in your module…

birthdaylist.js:398 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'startsWith')
    at Class.getBD_DAY_from_Date (birthdaylist.js:398:9)
    at Class.getDom (birthdaylist.js:462:154)
    at main.js:132:35
    at new Promise (<anonymous>)
    at updateDom (main.js:112:10)
    at Object.updateDom (main.js:669:4)
    at Class.updateDom (module.js:341:6)
    at Class.socketNotificationReceived (birthdaylist.js:328:9)
    at module.js:240:9
    at Socket.<anonymous> (socketclient.js:32:4)

Not sure if this corresponds with the displaySeconds parameter but seen this error first time…

Regards,
Ralf

rkorell

No, obviously NOT…
I’ve now added “sendNotifications: true” to config.
Mirror reloads and your module starts without this error message.

sdetweil

@rkorell can i see your birthdaylist config

and the date portion of one birthday from the list, which order the date info is in

and this error is trying to check if tye month part starts w a 0
and i figure out which date separator you used
/, or :, or just not ,
and then i split the date with the separator i discovered, they all HAVE to be the same separator and order

rkorell

@sdetweil yes, for sure

birth, name
17/01/1965,Carola
31/12/1963, Ralf
27/01/1993, Lennart
11/07/1987, Levin 
28/07/1985, Katharina
4/1/1953,Norbert L.
18/3/1939,Jürgen
22/3/1996,Chrizzy
27/3/1985,Hochzeitstag
31/3/2012,Hannah
31/3/2022,Nilo
11/4/1974,Claas
26/4/1965,Ralf B.
30/4/1989,Rahel
7/5/2020,Mathilda
27/5/1994,Elaine
10/6/1960,Melanie
5/2/1965,Stefan
26/5/2002,Leonie
4/1/2004,Carolin
10/6/95, 2.Hochzeitstag
10/6/1964,Petra B
23/6/1984,Colin
29/7/1995,Jassi
29/7/1955,Shirley P.
20/7/2001,Helene
5/8/1963,Harald
16/9/1997,Shirley Pi.
20/9/1965,Heiko D.
15/8/1967,Uta
23/8/2019,Emil
17/11/68,Susanne
27/9/1987,Severin
9/11/1948,Marianne
12/11/1967,Silvia
27/11/1956,Martina L.

rkorell

Ahh…
in the code listing it shows up a difference …
“10/6/95, 2. Hochzeitstag”
with an additional space and a dot…
is this a problem?
I can change the taxt and delete space if nacessary (althoug I mean I’ve read that you are truncing entries …
But the dot could be eliminated if useful.

Ralf

rkorell

interesting enough the error shows up first time as I reported - the list is always the same - literally unchanged until first day of installation…

sdetweil

@rkorell nvm i see it… let me look at it

sdetweil

@rkorell I don’t see the error… can you show me the bdlist config

also, that line of code would only happen is there WAS a birthday to display
and your list doesn’t have one for tomorrow or later (in this month)
are for next month…

still don’t see the error…
my code strips off the extra leading space on the name field.

rkorell

@sdetweil indeed - should have done this at the begin, sorry:

// Geburtstagsliste 
// Gelesen wird: ~/MagicMirror/modules/birthdaylist/data/bdl.csv

		{ 
	        
	        module: "birthdaylist",
	        disabled: false,
	        position:'top_right',  
	        config: {
						dimmEntries: false,  // true: dims entries and the associated symbol when the date has expired. false: dont display entries and the associated symbol when the date has expired.
						initialLoadDelay: 0, // How many seconds to wait on a fresh start up.
						updateDelay: 5,      // How many seconds after midnight before a refresh
						currentMonthOnly: false,  // will show birthdays for the current month only if true
						maxEntries: 3,	     // maximum entries to show, default is all
						dateFormat: '',	     // date format for birthday (default is none), could be 'Do' for 'Sep 12th'
						ageFormat:'',	     // some format string for the persons age, '[ n ]'  n will be replace by age value
						withMonth: true ,    // then true, add the month display as part of the date field, 
						debug:true,
	                }
		},

warmest regards,
Ralf

rkorell

Stefan, Jürgen and Chrizzy are shown - which is correct, as far as I understand the parameters.