MMM-FRITZ-Box-Callmonitor-py3 and MMM-Callmonitor-Current-Call

[xIExodusIx]

@sdetweil

What have I to do next?
Can I edit my commit? I would like to give mor information and correct some typing errors.

[sdetweil]

@xIExodusIx no , cannot edit a “commit”

you can make another

change files
test
git status
git add
git commit
git push

same workflow each time

[xIExodusIx]

@sdetweil

okay :-)

Thank you very, very much for your help.

[rkorell]

Dear @xIExodusIx ,
do you think it’s possible to get your re-compiled code?
I’m really curious - because the current call monitor is “nice” but the improvements you had described seemed to be really promising…

Thanks a lot.
Warmest regards,
Ralf

[xIExodusIx]

@rkorell

Hi Ralf,
if you search within the MM2 modules for “armybean” and find the module “MMM-Callmonitor-Current-Call” click on the right side in the description on “MMM-FRITZ-Box-Callmonitor”.
On the next screen click on the right side on “25 Forks” there you will find my Fork “xIExodusIx / MMM-FRITZ-Box-Callmonitor-py3”.
You can “git clone it” using “git clone https://github.com/xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git” in the /MagicMirror/modules folder. That should do all for you. After that follow th instrucktions given by “Paviro or Dr.Torchwood” they are almost the same.
I havs only merged the Versions from Paviro and armybeen and drtorchwood together, I did not compile the module new. Paviro did the aase Module, armybean added the (colored) direction arrows and drtorchwood made the module work with python3.
If you wnt to have the colored direction arrows you have to add “showOutgoing: true, and colorEnabled: true,” at the modulesection “MMM-FRITZ-Box-Callmonitor.py” in the /MagicMirror/config/config.js. Same if you use armybeans “MMM-Callmonitor-Current-Call”.
I hope this is understanding for you.

Have fun with it.
Carsten

[rkorell]

@xIExodusIx said

Have fun with it.

Dear Carsten, indeed - I DO have fun!

It’s really, really nice and works like a charm!
Thanks a LOT for your great work.

For future releases (if I interpret the above thread and Sam’s (@sdetweil 's) hints and advices correctly) you can edit the “README.md” file locally in your directory.
There you can include your own input/changes and own hints for installing (e.g. correct the git clone-link) - and AFTER these changes in documentation do the git push-thing …

Thank you very much for your effort!

Warmest regards,
Ralf

[rkorell]

@xIExodusIx
Short additional information (may useful for others who would like to use Carsten’s modification):
If one already have “MMM-FRITZ-Box-Callmonitor-py3” installed and up-and-running:
In this special case a git pull “git clone https://github.com/xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git” will not work - because the target directory $HOME/MagicMirror/modules/MMM-FRITZ-Box-Callmonitor-py3 already exists!

So it is neccessary to put the existing direcotry away.
You can do this simply with “rm -rf MMM-FRITZ-Box-Callmonitor-py3”.
Because I’m a friend of “security” I had decided to simply rename the old directory to keep it for recovering purposes if something bad happens…
“mv MMM-FRITZ-Box-Callmonitor-py3 MMM-FRITZ-Box-Callmonitor-py3.old” will do the trick.

(both commands are valid if you are in the $HOME/MagicMirror/modules directory …)

Regards,
Ralf

[xIExodusIx]

@rkorell

Hi Ralf,
I’m glad to read this, I thoght it could only work for me.

I will try to do what you said and edit the READ.ME file to put my changes in to it. I’m sadly could not code, what I did was only compare the different versions and merge the differences in a, for me, logical way together, and surprisingly, it worked.

I personally own a FritzBox 7590AX that distinguishes between 4 types of calls, “incomming, outgoing, missed and blocked”. I would like to have the “blocked” calls also been handled and showed up in the module “MMM-FRITZ-Box-Callmonitor-py3” but I don’t know how to do this. I want these blocked calls handled by the module, because I have a large blocklist of callers that I don’t want to get in touch with. They try to cheat me for mony or peronal data. I got up to 15 calls a day of these unwanted calls.

Do you have any Ideas?

Regards
Carsten

[rkorell]

@xIExodusIx Dear Carsten,

I’m not that good in object-oriented programming…
The main problem for me in this module is the three-layer approach - so I’m not sure what happens when and where.
In addition I’m not familiar with the used libraries…

From my understanding the base layer “fritz_access.py” should handle your request.
In this python program you can find the class FritzAccess which handles the queries to AVM Fritzbox.
One of the calls used is “GetCallList” - in the second definition of the object:

    def download_recent_calls(self, directory = "data"):
        result = self.fc.call_action("X_AVM-DE_OnTel", "GetCallList")
        filename = os.path.join(directory, "calls.xml")
        self.forward_file(result["NewCallListURL"], filename)

I can imagine (I don’t know!) that there is another call-function “GetBlockedCallList” or something similar.

This has to be clarified.
If such a call exists, you need an entry in the FritzAccess class for this and than a function which takes care about.

In the second layer “node-helper.js” line 13ff

const CALL_TYPE = Object.freeze({
	INCOMING: "1",
	MISSED: "2",
	OUTGOING: "3"
})

Must be extended for fourth call_type - “BLOCKED”
and the function setupMonitor() (line 73ff) must get an additional "monitor.on(“blocked” … "

In the third layer (“MMM-FRITZ-Box-Callmonitor-py3.js”) you have to adopt the “socketNotificationReceived:” function (line 90ff) and handle the “BLOCKED” condition.

This all from my very basic understanding, how theses modules are impelmented in general.

Unfortunately my knowledge is currently not deep enough to be more concrete, sorry for this!

May another user can step in here.
Because you at least was able to reconfigure code out of three different repositories - may these little hints are enough for you…

Warmest regards and good luck!
Ralf

[xIExodusIx]

@rkorell
Hi Ralf,

I did not touch the file “fritz_access.py” by now, but what I already did was edeting the files “MMM-FRITZ-Box-Callmonitor-py3.js” and “node-helper.js”.
In the file “node-helper.js” I already added:
const CALL_TYPE = Object.freeze({
INCOMING: “1”,
MISSED: “2”,
OUTGOING: “3”,
BLOCKED: “4”
})
and tried this (now comented out because it did not work):
//Call blocked
//monitor.on(“blocked”, function (call) {
// var name = self.ownNumbers.includes(call.caller) ? self.getName(call.called) : self.getName(call.caller);
// var direction = self.ownNumbers.includes(call.caller) ? “out” : “in”;
// self.sendSocketNotification(“blocked”, { “caller”: name, “direction”: direction });
//});
and this (also now comented out):
for (var index in callArray) {
var call = callArray[index];
var type = call.Type[0];
//Try to handle blocked calls this is new from “if to else” delete all lines from “if to else” if it not works!
//if var name = type == CALL_TYPE.BLOCKED || type == CALL_TYPE.INCOMING ? self.getName(call.Caller[0]) : self.getName(call.Called[0]);
// var duration = call.Duration[0];
// if (type == CALL_TYPE.INCOMING && self.config.deviceFilter && self.config.deviceFilter.indexOf(call.Device[0]) > -1) {
// continue;
//} else
//From here the original script is ongoing
var name = type == CALL_TYPE.MISSED || type == CALL_TYPE.INCOMING ? self.getName(call.Caller[0]) : self.getName(call.Called[0]);
var duration = call.Duration[0];
if (type == CALL_TYPE.INCOMING && self.config.deviceFilter && self.config.deviceFilter.indexOf(call.Device[0]) > -1) {
continue;
}
In the file “MMM-FRITZ-Box-Callmonitor-py3” I did already this:
const CALL_TYPE = Object.freeze({
INCOMING: “1”,
MISSED: “2”,
OUTGOING: “3”,
BLOCKED: “4” //New entry! to handle blocked calls
})
and tried this:
//Handle blocked calls
//if (notification === “blocked”) {
//Send notification for currentCall module
// this.sendNotification(“CALL_BLOCKED”, payload.caller);
//Remove alert from UI when call is connected
// this.sendNotification(“HIDE_ALERT”);
// this.activeAlert = null;
//}
But that all does not work so I comented it out again.
Thats my problem I can’t code and I dont really understand what I’m doing, all I can do is “Try and Error”!

But thanks a lot for your help. :-)

Carsten

[rkorell]

@xIExodusIx Yeahh…
You figured out the exact same idea and made more out of this than I’m able to do.
But for sure you have to start at the python script - the python script “feeds” node-helper.
And if node-helper don’t get info about “blocked” - your If-clause is never true so your new code couldn’t be reached.
And for setting the python script correctly you have to identify how the AVM/Fritz interface works…

Regards,
Ralf

[xIExodusIx]

@rkorell

I have almost 2 hours googled for the right name of the function for the blocked calls, but did not find anythig about that.
And I found some smaller errors in the funktion of the module. E.g. it should delete the alert (the big popup on the gui of the MM when a call comes in) when I answer this call. But that does not work.
This should do the job in the "MMM-FRITZ-Box-Callmonitor-py3:
if (notification === “connected”) {
//Send notification for currentCall module
this.sendNotification(“CALL_CONNECTED”, payload);

		//Remove alert only on connect if it is the current alert shown
		if (this.activeAlert === payload) {
			//Remove alert from UI when call is connected
			this.sendNotification("HIDE_ALERT");
			this.activeAlert = null;
		}
	}

but it dosn’t work.

As I already said: I can’t code :-(

Regards,
Carsten

[rkorell]

@xIExodusIx Yes, I identified this “bug” as well and couldn’t find the mistake…
As I mentioned - I couldn’t code (this) as well …

Regards,
Ralf

[xIExodusIx]

@rkorell

I think it is something with the syntax, maybe it has changed somehow in python3, or a wrong set “,” or “;” so the modulescript could not run correct, but it is enough to let the module almost run as expected.
For that I have not enough experience to figure that out.

Would be nice if there were the possebility of a testing enviroment for MS-Windows, so that I could test the scripts. For editing I could use VS-Code.

[rkorell]

@xIExodusIx said in MMM-FRITZ-Box-Callmonitor-py3 and MMM-Callmonitor-Current-Call:

testing enviroment for MS-Windows,

For Python you can use this …

Regards,
Ralf

[xIExodusIx]

@rkorell

Hi Ralf,
I found out that the correct entry for handle “blocked calls” is “10”, not “4”, I found that on “https://fritzconnection.readthedocs.io/en/1.14.0/sources/library_modules.html”
Slowly I understand how the module works and what the entire entries do, but without understandig the syntax and how to code. I will not come further.

Regards
Carsten

[rkorell]

@xIExodusIx
Dear Carsten,

quick question: For several reasons yesterday I had checked the log files during startup of my MagicMirror.

Unfortunately there is an error related to your pimped module:

[ERROR] ERROR! Could not find main module js file for MMM-FRITZ-Box-Callmonitor-py3_drtorchwood

The module works (!?) but may there is something that don’t work?

Is there a submodule which is not loaded to git?

Thanks for any hint!

[xIExodusIx]

@rkorell said in MMM-FRITZ-Box-Callmonitor-py3 and MMM-Callmonitor-Current-Call:

MMM-FRITZ-Box-Callmonitor-py3

Hi Ralf,
I have searched all my log-files in “.pm2/logs/” for that string, but I didn’t find anything related to that error. I don’t have this error in my pm2 log-files.
Are there more log-files I can check, if so where can I find them?
I’m sure you have checked your MagicMirror/config/config.js if there is a type missmatch.

Reguards
Carrsten

[rkorell]

@xIExodusIx It’s in the PM2 logs, yes.
I guess you have some code parked in an additional file “py3_drtorchwood” which is present on your system but not on mine …
especially drtorchwood isn’t present on my system at all.
Will dig into code lateron …
Thanks for your double check.

Regards,
Ralf

[xIExodusIx]

@rkorell

Hi Ralf,
sorry it took a while to answer, what I did until now is:
I updated python on my raspberry pi 4 bookworm 64bit, to python 3.13.2 and I overworked the module MMM-FRITZ-Box Callmonitor-py3, it now handles almost all unwanted (blocked) calls, that are in your FritzBox callist for blocked calls, and shows them in the callist on your MM2.
But it can’t handle blocked numbers that are in the “area list”, that means numbers that begins with e.g. 0031* (+31*) all numbers from, in this example, Netherlands, they appear as “SIP:ownnumber” with a red X in the callist of your MM2. I can’t find out how to fetch the whole correct number that ist displayed in the FritzBox gui under incomming calls.
And I can’t find out how to let the alert “Incomming Call” disappear for that blocked calls.
Everything else should work as expected, for me it does.

Regards,
Carsten