MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    MMM-FRITZ-Box-Callmonitor-py3 and MMM-Callmonitor-Current-Call

    Scheduled Pinned Locked Moved Utilities
    47 Posts 3 Posters 8.4k Views 4 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • X Offline
      xIExodusIx @rkorell
      last edited by

      @rkorell

      Hi Ralf,
      Yes the message box disappears now when a call is in progress, and no I did not push my modificated code to github by now.
      But sadly I can’t find out how to let the massage box disapper when a call is incomming that will be blocked. So the message box is displayed over hours on the screen, to let it disappear I have to connect to my MM2 using “RealVNC Viewer” and mouseclick on the message box, then it disappears. This is not satisfying.

      With the update of python to version 3.13.2 I made a failure, that was not a good idea, so I have to reinstall my MM2 from scratch, what I’m doing right now. If this is done and all runs like I want again, I will push my modified code to githup. If this is done I will inform you.

      I will continue to work on the module to eliminate the last few problems. I hope I can do it.

      As I said I can’t code was and is this the truth, all I have done is to try to copy existing code lines change them a little bit and paste it where I thought it could be the right place, then pushed the entirely .js file up to my MM2 and tested it. If it doesn’t work I tried an other way and tested it again. So all I do is “Try and Error”, not really coding! But VSCode helps a lot.

      Regards
      Carsten

      1 Reply Last reply Reply Quote 0
      • X Offline
        xIExodusIx @rkorell
        last edited by

        @rkorell

        Hi Ralf,
        I just pushed up my reworked version of the module “MMM-FRITZ-Box-Callmonitor-py3” to github.
        I hope it works for you too.

        Regards
        Carsten

        R 1 Reply Last reply Reply Quote 1
        • R Offline
          rkorell @xIExodusIx
          last edited by

          @xIExodusIx Dear Carsten, this is awesome!
          Thanks a LOT!
          Currently - in my installation - the Info Box which is signalling the call is not a „message-box“ and disappears when call is ended.
          Did you modify this -then I would hesitate to install newest version…
          Thanks a lot for your effort!
          Warmest regards,
          Ralf

          X 1 Reply Last reply Reply Quote 0
          • X Offline
            xIExodusIx @rkorell
            last edited by

            @rkorell said in MMM-FRITZ-Box-Callmonitor-py3 and MMM-Callmonitor-Current-Call:

            Currently - in my installation - the Info Box which is signalling the call is not a „message-box“ and disappears when call is ended.
            Did you modify this -then I would hesitate to install newest version…
            Thanks a lot for your effort!

            Hi Ralf,
            I did not change the appearance of the message-box, in the module it is an alert, I only tried to let it disappear right when you answer the incomming call, because on my MM2 the message box blurres the background and I can not clearly see all other modules and the “MMM-Current-Call” module, that also shows me if the current call is incomming or outgoing, but now the message box disappears when the incomming call is answered.
            The MMM-Current-Call" module makes only sense if you have more then one telephon-line, so you can see how many people are talking right now, and if the calls are incomming or outgoing.

            Hope that will help you to decide.

            Regards
            Carsten

            R 1 Reply Last reply Reply Quote 1
            • R Offline
              rkorell @xIExodusIx
              last edited by

              @xIExodusIx Thanks again, this helps!
              Regards,
              Ralf

              X 1 Reply Last reply Reply Quote 0
              • X Offline
                xIExodusIx @rkorell
                last edited by xIExodusIx

                @rkorell

                I played a little bit around with the colors and changed also the appearance of missed calls, the missed calls now will be displayed in color “magenta” with a “star”. You can edit the colors by yourself by editing the “MMM-Fritz-Box-Callmonitor-py3.js” file, you can’t miss these entrys.
                I also edited the README.md file again.
                I will push these changes to github at my next update, but I have to test a little bit more because I have to wait for the unwanted calls that are in my blocked “phonenumber range list”, and I don’t know when these unwanted calls are incomming.
                But hopefully I got most of the annoying problems under control. :-)

                Regards
                Carsten

                R 1 Reply Last reply Reply Quote 0
                • R Offline
                  rkorell @xIExodusIx
                  last edited by

                  @xIExodusIx It’s good practise to keep style information not in the *.js code but in the CSS file of module - than everybody can make persistent changes to style related issues in custom.css which will not been overwritten by module updates…

                  Warm regards,
                  Ralf

                  X 1 Reply Last reply Reply Quote 0
                  • X Offline
                    xIExodusIx @rkorell
                    last edited by xIExodusIx

                    @rkorell

                    Yes, I know, but I don’t know how to transfer this code-lines to the .css file, the code for appaerance and color were in the module.js file before I began to try to get it work. I only modified them.

                    The last two problems I have with the module is, to show the correct number in the callist, not “sip:myown number”, when an incomming call is blocket by the “number range list” and to hide the alert of these calls.

                    On these problems I still work.

                    Regards
                    Carsten

                    R 1 Reply Last reply Reply Quote 1
                    • R Offline
                      rkorell @xIExodusIx
                      last edited by

                      @xIExodusIx Dear Carsten,
                      quick feedback for you: Just installed your newest version.
                      And - to my big surprise - it works like I would like to have…
                      I only have installed "MMM-FRITZ-Box-Callmonitor-py3 " - to be 100% clear, may there is the difference.
                      But with only this module incoming calls are displayed/signalled (grey’ish / white color) and the message box disappears either when the call is taken or if the caller hangs up.
                      This exactly is what I would like to have.
                      You definitely have done something magical because the initial code holds the message box until call is ended.
                      THANKS!!!

                      You ARE a coder :-)

                      Warmest greetings to Hamburg (as your git-account now reveals),
                      Ralf

                      For the CSS stuff - my apologies…
                      I cannot guide here, as well. I’ve seen your color coding in dependency from call-type.
                      I GUESS you can solve this with case-dependent CSS-attributes and so avoid the complete “switch”-clause.
                      But this is far beyond my own capabilities - may Sam (@sdetweil ) can lead through this…

                      1 Reply Last reply Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 4
                      • 5
                      • 2 / 5
                      • First post
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy