MMM-cryptocurrency - v1.4

matteodanelli

@cowboysdude Thank you for suggestion! I fixed according to guidelines :)

hazmartin

Hi, loving the module. Have you managed to get multiple currencies showing in a list?

matteodanelli

@hazmartin Hi, I am working on it and I look forward to have it implemented very soon.
I’ll ping you when ready.

Klizzy

hello @matteodanelli , thank you for you work!
I submitted a pull request to your Repo and it now has multi currency support, translations, styling and Formatting.
Tomorrow i wanted to add some more comments to explain more parts of the code.
You can add it to you code if you want to. I just wanted to finish my MagicMirror and have an overview on multiple currencies. Thats the reason why i could no longer wait 😅

Here you can see it https://github.com/matteodanelli/MMM-cryptocurrency/pull/1

Here is the forked repo with the charges if you want to test it:
https://github.com/Klizzy/MMM-cryptocurrency

matteodanelli

Project updated with multiple currencies support and percentage change in the last 24 hours.
Thank you @Klizzy for you contribution!

SpecialRob

Hello

I just git cloned the newest version and updated the config file as per your instructions. (21MAY17) It is working perfectly and pulling the current data.

I was snooping through the various js files and don’t see how to add the header line above the currency listing

CRYPTO CURRENCY (Dim text with a line below it)

Is this a config option somewhere?

Klizzy

@SpecialRob
do you mean a dividing line between the table header and data, or do you don’t have any data in the Table header (Currency, Price, 24h Change) ?

a dividing line is not implemented at the moment. But today i finished another feature for this module, so i can add the dividing line. If @matteodanelli accepts my pull request you can update it in a couple of days.

If you don’t have any data in the table header, i need to know in which language settings you’re running the mirror.

SpecialRob

@Klizzy

Thanks for the reply

No, I do not have any table header data at all (english), nor a dividing line like the graphic shown for the module.

It just jumps to a table listing the currency and price.

Now that I am adding more and more stuff to my screen, it would be nice to have separators to keep it uncluttered. Not a huge deal, just my OCD flaring up ;)

matteodanelli

Hi @SpecialRob,
I think I didn’t get the point.
In my module, there is not a line separator between header and data.
Also, language of the module is set to english and you don’t see header values? So strange :)

Can you please post a screenshot of what you see?
Looking forward to help you.

matteodanelli

Hello guys,
I’ve updated project making optional the possibility to show currency changes in time.
Also, you can select which interval to see between one of the following: 1 hour, 1 day or 1 week. None of them is required.

Leave me feedback ;)