MMM-MyCommute

requiemmg

Raised an issue. Seems like the problem comes with the use of MMM-Pages, so on every reload of the page, the module is loaded and the requests are sent again, even if the data is still up to date. @qistoph was so nice to make a fork to address this issue.

sdetweil

@requiemmg yep, separate instance on every page.

requiemmg

This makes it clear why I had about 50.000 requests, which made my $400 starting balance void…well, with the new fork and some config modifications, this is much better.

mumblebaj

@requiemmg What I have found is if you run the module in the fixed section of MMM-pages it only does the calls every so often as you set them to i.e. the MMM-Openinghours module I run in fixed as I refresh it every 4hrs.

requiemmg

@mumblebaj Right, but in my design it doesn’t fit in this section. Anyhow, @qistoph made a test fork (https://github.com/qistoph/MMM-MyCommute/tree/issue17) which only makes requests if the data is outdated (=longer than set pollFrequency). See the issue thread (https://github.com/qistoph/MMM-MyCommute/issues/17) for further details

lavolp3

It seems @qistoph 's fork is more up to date than the original repo.

I just pushed a PR to the original repo AND to the @qistoph fork.
It provides an origin option to every destination so you can show commuting back home.
Just set any point as ‘origin’ and your home address as ‘destination’

lavolp3

@lavolp3 nevermind, it is already integrated in @qistoph fork it seems :-)
Just not documented in the readme.

matt216

Hi all.
Wondering if there’s a way to hide the arrival time? Can’t see an option in the config.
Thanks

matt216

Additional question - the startTime option doesn’t seem to be working correctly for me. The module doesn’t display in the morning on the pi/mirror, even after the specified startTime. Weirdly, when I browse to the mirror from my laptop or phone (http://ip:8080) that seems to trigger the module to display on the pi.
Any ideas there?!

sdetweil

@matt216 said in MMM-MyCommute:

Weirdly, when I browse to the mirror from my laptop or phone (http://ip:8080) that seems to trigger the module to display on the pi.
Any ideas there?!

this means the module is not written for multiple browser instances.

when the helper sends data back, it sends data back to ALL connected clients at the same time.
the clients need to check if the message is for them , but the helper needs info on the request to do it… so the modulename.js has to change too…