MMM-MyScoreboard

vinp

@homerj99 I just realized that the logos for NHL can be taken right from the ESPN feed. I have updated my code to include that change (VGS should show up next time they play) To get latest: do a “git pull” after you CD into the MMM-MyScoreboard directory. thanks!

BKeyport

hey, @vinp -

I filed this as an issue on the main fork - was wondering if you’d be interested in adding this for me, as I’m just a beginner in javascript and don’t fully understand what’s going on here.

For leagues that are currently “Out of Season” or off for the day, can we get output like “[league name] - No games scheduled” - This would prevent blank screens in my case, where I have MMM-Carousel running to page between sports.

“MLB - No Games Scheduled”
“NBA - No Games Scheduled”
“NCAAF - No Games Scheduled”
etc.

vinp

Yeah that’s a good one. I also use the carousel and see this happening. I can take a look maybe this weekend.

j.e.f.f

Hey all.

The Sportsnet feed has been fixed. This will fix issues with NHL, NFL, CFL, MLS and MLB.

I’ve tested this with NHL and NFL and so far it looks good. Let me know if you run into issues with other sports.

Jeff

j.e.f.f

@bkeyport said in MMM-MyScoreboard:

hey, @vinp -

I filed this as an issue on the main fork - was wondering if you’d be interested in adding this for me, as I’m just a beginner in javascript and don’t fully understand what’s going on here.

For leagues that are currently “Out of Season” or off for the day, can we get output like “[league name] - No games scheduled” - This would prevent blank screens in my case, where I have MMM-Carousel running to page between sports.

“MLB - No Games Scheduled”
“NBA - No Games Scheduled”
“NCAAF - No Games Scheduled”
etc.

My module is intended to use as little space as possible. When no games are scheduled for your current config, either because the sport is out of season or there are simply no games scheduled for that particular day, the sport is completely hidden to reclaim space.

BKeyport

Right, and I’m suggesting an optional change to that, so that I can eliminate the blank screens… I’d love to see a simple one line “NCAAF - No games scheduled” item available if selected by the user.

If I was any good at JS, I’d do it myself, but adulting has kept me away from hobby programming.

cyberphox

This post is deleted!

cyberphox

This post is deleted!

BKeyport

So, I did end up forking it (Off of VInP’s fork), if for nothing else to try and figure out how to do things.

https://github.com/BKeyport/MMM-MyScoreboard

All I’ve changed so far from VinP’s changes is line 454 - “var anyGames = true;” instead of “false”

This results in the headers showing, which in my config results in no blank screens.

vinp

@bkeyport Good! Always neat to try it on your own. I’ve seen and learned a lot from different MM devs. I’ve made changes to mine to show a “No scores to display” message if there are NO sports to display at all. All you need to do, if you use my fork is to add showNoSportsText: true in the config for the module. git pull of course too :) I do agree with @j-e-f-f, to try to keep the module as small as possible.