Read the statement by Michael Teeuw here.
MMM-MyScoreboard
-
@bkeyport ssh into your Pi and then “cd” into where you have MagicMirror/modules then run:
rmdir MMM-MyScoreboard
while you are still in the /modules folder, do a clone of my repository : git clone https://github.com/vincep5/MMM-MyScoreboard.git
Lastly run:
cd MMM-MyScoreboard
npm install -
@vinp
I had to use
sudo rm -rf MMM-MyScoreboard
as the directory was not empty.And had to also throw a
npm cache clean
prior tonpm install
to get rid of the install errors regarding “Failed to parse json”When my MagicMirror starts I see the header, then it disappears and it is not populating any of today’s NFL games. Configuration is the same as I was using before the issues started. Aside from the data sources nothing else changed in this fork right?
-
@wedee Sportsnet changed their feed. Unfortunately the new one is quite different in format so it’s taking me a bit of time to write a fix. Hopefully I’ll have a release soon.
-
@j-e-f-f
Thanks for the reply. Look forward to the update. -
Just noticed in NHL Scores that Vegas Knights Logo was not appearing, just the abbreviation of VGS appearing, I copied the logo and renamed it VGS, logo now appearing, perhaps due to ESPN labeling? Just thought I would share
-
@wedee thanks for the corrected steps. I will look on Thanksgiving if mine shows NFL. Nothing major should have changed. Rams were updated to to be LAR. Outside that my fork was primairly to add more soccer leagues. I do have NHL and NBA on my setup at home
-
@homerj99 I just realized that the logos for NHL can be taken right from the ESPN feed. I have updated my code to include that change (VGS should show up next time they play) To get latest: do a “git pull” after you CD into the MMM-MyScoreboard directory. thanks!
-
hey, @vinp -
I filed this as an issue on the main fork - was wondering if you’d be interested in adding this for me, as I’m just a beginner in javascript and don’t fully understand what’s going on here.
For leagues that are currently “Out of Season” or off for the day, can we get output like “[league name] - No games scheduled” - This would prevent blank screens in my case, where I have MMM-Carousel running to page between sports.
“MLB - No Games Scheduled”
“NBA - No Games Scheduled”
“NCAAF - No Games Scheduled”
etc. -
Yeah that’s a good one. I also use the carousel and see this happening. I can take a look maybe this weekend.
-
Hey all.
The Sportsnet feed has been fixed. This will fix issues with NHL, NFL, CFL, MLS and MLB.
I’ve tested this with NHL and NFL and so far it looks good. Let me know if you run into issues with other sports.
- Jeff
-
@bkeyport said in MMM-MyScoreboard:
hey, @vinp -
I filed this as an issue on the main fork - was wondering if you’d be interested in adding this for me, as I’m just a beginner in javascript and don’t fully understand what’s going on here.
For leagues that are currently “Out of Season” or off for the day, can we get output like “[league name] - No games scheduled” - This would prevent blank screens in my case, where I have MMM-Carousel running to page between sports.
“MLB - No Games Scheduled”
“NBA - No Games Scheduled”
“NCAAF - No Games Scheduled”
etc.My module is intended to use as little space as possible. When no games are scheduled for your current config, either because the sport is out of season or there are simply no games scheduled for that particular day, the sport is completely hidden to reclaim space.
-
Right, and I’m suggesting an optional change to that, so that I can eliminate the blank screens… I’d love to see a simple one line “NCAAF - No games scheduled” item available if selected by the user.
If I was any good at JS, I’d do it myself, but adulting has kept me away from hobby programming.
-
This post is deleted! -
This post is deleted! -
So, I did end up forking it (Off of VInP’s fork), if for nothing else to try and figure out how to do things.
https://github.com/BKeyport/MMM-MyScoreboard
All I’ve changed so far from VinP’s changes is line 454 - “var anyGames = true;” instead of “false”
This results in the headers showing, which in my config results in no blank screens.
-
@bkeyport Good! Always neat to try it on your own. I’ve seen and learned a lot from different MM devs. I’ve made changes to mine to show a “No scores to display” message if there are NO sports to display at all. All you need to do, if you use my fork is to add showNoSportsText: true in the config for the module. git pull of course too :) I do agree with @j-e-f-f, to try to keep the module as small as possible.
-
@vinp But that’s the fun of doing this…you get to build something that you want as a user. Generally speaking most developers don’t mind helping you if you ask…others not so much LOL
I try to help people with my modules but in all honesty I’m not going to completely rewrite something for one person… doesn’t make sense to do that. BUT yes I have had people do a fork then I help them get what they need for their own personal mirror :)
That’s the entire reason for the “MagicMirror project”… some people see “MagicMirror” but forget the word ‘project’ LOL I have told people that this is the project you want as it offers so many options, way more than the others.
-
Cool, Thanks, Vince - I’ve merged your updates into my fork, and I’m playing with it now. Thinking about playing around with the other (what I would consider) improvement cases I wanna do, having two or three modules to show scoreboards that are all different does irritate me to no end… :)
-
FWIW, I seem to have a legit bug - the group “Pac-12” seems to go random on teams in NCAAF. (using my fork of VinP’s fork of the module), I’ve overridden it by putting all the teams in individually for now.
-
Vince, Your mod works perfectly - once I undo mine.
Thanks for the head start to see how it’s modified. Will be fun to learn.
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login