Read the statement by Michael Teeuw here.
MMM-Strava
-
Not as yet I’m afraid.
Hoping to work on it in the coming weeks - work and other commitments permitting.
PRs welcome from those who might have the know how 😉
-
@ianperrin said in MMM-Strava:
No as yet I’m afraid.
Hoping to work on it in the coming weeks - work and other commitments permitting.
PRs welcome from those who might have the know how 😉
No worries, take your time. Meanwhile i just update manually
-
@zerodegree79 , @Val07300, @ctatos (and others I may have missed).
A new (beta) version of the module with support for Strava’s new authentication flow is available.
Much of the code for the module has been re-written/re-factored and includes a number of changes to the original module including
- Support for multiple instances of the module
- The table and chart and now generated via templates (rather than javascript)
- A helper is included to simplify the initial authentication with Strava
chart
mode now supports either therecent
andytd
values in theperiod
option- The stats displayed in
table
mode are configurable via thestats
option - To support the new authentication flow, the
client_id
andclient_secret
must be included in the config in place of the deprecatedstrava_id
andaccess_token
options. The legacy options can still be used, but will trigger an alert on the mirror when the module is loaded and it is recommended they are removed.
Please note - the module no longer supports multiple athlete id’s in one module instance. Multiple instances can be added to the config file to achieve similar results.
Notes for beta testers
This functionality is only available in the develop branch of the github repository at this time. Once any issues have been fixed, the master branch will be updated.
To test the refresh token functionality and the new authentication flow in the Magic Mirror, you need to update the module using the following steps:
- stop the Magic Mirror
- switch to the develop branch and install the new dependencies
cd ~/MagicMirror/modules/MMM-Strava git checkout develop && git pull npm install --production
- edit the MMM-Strava configuration in config.js and
- remove
strava_id
andaccess_token
options - add
client_id
andclient_secret
options. The values for these options should be copied from the My API Application page in your Strava profile
- remove
- restart the Magic Mirror
When updated correctly, the module should display a Client id unauthorised message. The module can be authorised using the following steps:
- Browse to http://localhost:8080/MMM-Strava/auth/ on the Magic Mirror. This can be done remotely if you have setup the
ipWhitelist
in the Magic Mirror - Select module and click Authorise
- If prompted, log in to Strava
- On the Strava Authorisation page, click Authorize
- Once the successful authorisation message appears, restart your Magic Mirror.
-
@ianperrin
From the new authorization process I’m getting a bad request from Strava:{ "message": "Bad Request", "errors": [ { "resource": "Application", "field": "redirect_uri", "code": "invalid" } ] }
I have the feeling that I have an error in my Strava API config.
There is a “website” and a “Callback domain” that I need to put in. Does this have to do anything with the address I’m using for the authentication process via /MMM-Strava/auth?EDIT: Can it be because I’m currently accessing the mirror through a ddns service, so the address is not localhost:8080 but something else?
-
@lavolp3 are you browsing to http://localhost:8080/MMM-Strava/auth/ and using the authorisation process there? If so, where is the bad request being displayed?
It should look something like this:
-
@ianperrin No I’m browsing from a laptop like always. So it’s http://magicmirror:8080/MMM-Strava/auth/.
Do you think that makes a difference? -
-
@ianperrin Did it again as described, but still a “Bad Request” Message. Maybe I’m doing something wrong: Error message says invalid redirect_uri, so I guess I need to play around with it a bit more.
-
@ianperrin OK now it works.
I set my ddns domain “xxxx.ddns.net” as callback domain in the Authentication profile.
Then it works. The link for the authorisation inquires that the request is being sent from inside that domain. I had set localhost as the callback domain and made the request from the ddns which in that specific case did not work.Maybe you could include a description for anyone trying to do the authentication from a browser not on the RasPi itself. You would need to set the callback domain appropriately.
-
@lavolp3 that makes sense, I understand your issue now. Good pick up and we’ll done for finding that solution. I’ll look to update the read me with notes for creating the application as well as authorising the modules.
In the meantime, let me know how the token refresh works, or if any other errors appear.