Module Position

[strawberry 3.141]

@maxbachmann i wouldn’t place that code in other modules, you can perform that from your module for every module, this isn’t magicmirror related. its pure dom manipulation.

[maxbachmann]

Ah did not know that ;) well yes then it’s definetly in my program. All my program does so far is subscribe to a mqtt broker, load some data and according to this show/hide modules. Now I want to add the possibility to move modules to different positions.
Can send the current code later

[maxbachmann]

@strawberry-3-141 so in general use all 3 commands and then it works in both senarios? where can I find the right ID for each module?

[strawberry 3.141]

@maxbachmann you can get all modules https://github.com/MichMich/MagicMirror/tree/master/modules#module-selection then iterate over them and when you find the module execute the cmds

const moduleToMove = 'clock';
const targetRegion = 'top.left';

MM.getModules().enumerate((module) => {
    if (module.name === moduleToMove) {
        const instance = document.getElementById(module.identifier);
        const region = document.querySelector(`div.region.${targetRegion} div.container`);
        region.appendChild(instance);
        region.style.display = 'block';
    }
});

something similar to this

[maxbachmann]

@strawberry-3-141 ty that works.

Added the possibility

region.insertBefore(instance, region.childNodes[0])

so I can prepend and append the module

[justjim1220]

@maxbachmann

If you look in your css folder you will find the main.css file. Open it and you will find all the regions. Compare them to where you have you modules set and it should help you figure it out.

[maxbachmann]

@justjim1220 it already works the way @strawberry-3-141 proposed :)
Only thing I am not quite sure about yet is when can I use const?
I have the code in socketmessagereceived. Can I use const in there when I do only give the variable one value each time it runs the function? Because for me it seems like the variables still exist when the function gets called again which would mean const does not work

[justjim1220]

@maxbachmann

Sorry, still kinda new with this, that is beyond my scope!

[maxbachmann]

@justjim1220 Same for me I am absolutely new to javascript. I generally know the system const because I use a lot of c++, but testing here seems like the variables actually get not deleted after SocketNotificationreceived function ends. And I have absolutely no clue on when to use the type let and which advantage it offers over var, because on some variables let works on others only var. const actually never worked in there.

I have my code here not fully ready yet:

socketNotificationReceived: function(notification, payload) {
    if (notification === 'HIDE_SHOW') {
	
	var obj = JSON.parse(payload.data.toString());
	
	var max = obj.slots.length;

	for (let i = 0; i < max; ++i){
                if (obj.slots[i].slotName === "HIDE" ||
                    obj.slots[i].slotName === "SHOW") {
                    var HideShow = obj.slots[i].slotName;
                }
            }

            for (let i = 0; i < max; ++i){
                if (obj.slots[i].slotName === "MODULE") {
                    var Module = obj.slots[i].value.value;
			break;
                }
            }
            var Message = HideShow + "_" + Module;

		
		const moduleToMove = 'clock';
		const targetRegion = 'top.left';
		
		MM.getModules().enumerate((module) => {
		    if (module.name === moduleToMove) {
		        const instance = document.getElementById(module.identifier);
		        const region = document.querySelector(`div.region.${targetRegion} div.container`);
		        region.appendChild(instance);
			//region.insertBefore(instance, region.childNodes[0])
		        region.style.display = 'block';
		    }
		});
      	this.loaded = true;
	this.sendNotification(Message);
    }

    if (notification === 'ERROR') {
      this.sendNotification('SHOW_ALERT', payload);
    }
  }

So at which positions would it be better to use const/let instead of var? And how is the performance of them? Because in c++ I definetly use const a lot for variables or member functions

[strawberry 3.141]

@maxbachmann short version: with es6 you should never use var. it has scope issues. const doesn’t work exactly like in other programming languages. It only prevents from assigning a new reference so strings integers booleans … are fixed. But objects and arrays can still be modified.

And you don’t want to keep this, it was only a placeholder for your notifications, thats why you thought is const always there.

const moduleToMove = 'clock';
const targetRegion = 'top.left';

you should also be carefull setting the variable Module as it is a global variable of MM.

I don’t get the part why you build the message string.

Also you should consider creating another if/else as if (notification === 'HIDE_SHOW') { has nothing todo with changing positions of modules.

Exactly what you are doing is bad it schould look more like this:

socketNotificationReceived: function(notification, payload) {
    if (notification === 'HIDE_SHOW') {
	
	const obj = JSON.parse(payload.data.toString());
	
	const max = obj.slots.length;

        let HideShow;
	for (let i = 0; i < max; ++i){
            if (obj.slots[i].slotName === "HIDE" ||
                obj.slots[i].slotName === "SHOW") {
                HideShow = obj.slots[i].slotName;
            }
        }

        let module;
        for (let i = 0; i < max; ++i){
            if (obj.slots[i].slotName === "MODULE") {
                module = obj.slots[i].value.value;
		break;
            }
        }
        // why do you build this message??? it's never used
        const Message = HideShow + "_" + module;

		
		const moduleToMove = 'clock';
		const targetRegion = 'top.left';
		
		MM.getModules().enumerate((module) => {
		    if (module.name === moduleToMove) {
		        const instance = document.getElementById(module.identifier);
		        const region = document.querySelector(`div.region.${targetRegion} div.container`);
		        region.appendChild(instance);
			//region.insertBefore(instance, region.childNodes[0])
		        region.style.display = 'block';
		    }
		});
      	this.loaded = true;
	this.sendNotification(Message);
    }

    if (notification === 'ERROR') {
      this.sendNotification('SHOW_ALERT', payload);
    }
  }