how to pull new element added to an array?

justjim1220

yeah, I was going by how the rest of the info (title, url, description, etc) is pulled from the feeds array, so thought it would be the same.

sdetweil

can u show where newItems is set?

justjim1220

@sdetweil

 start: function () {
        Log.info("Starting module: " + this.name);

        // Set locale.
        moment.locale(config.language);

        this.newsItems = [];
        this.loaded = false;
        this.activeItem = 0;
        this.scrollPosition = 0;

        this.registerFeeds();

		"use strict";

        this.isShowingDescription = this.config.showDescription;
    },

justjim1220

@sdetweil

this is the default MM newsfeed, I am trying to modify it to show different things.

justjim1220

@sdetweil

My last modification was this…

https://forum.magicmirror.builders/assets/uploads/files/1539306174825-screenshot-140.png

https://forum.magicmirror.builders/assets/uploads/files/1539306174825-screenshot-141.png

https://forum.magicmirror.builders/assets/uploads/files/1539306174825-screenshot-142.png

sdetweil

@justjim1220 the problem is that the newsItems array is set from the rest api to pull the entries from the source. THAT data does NOT contain the icon you want to use.

your feed DEFINITION does , but not the feed response data…

so, can u tell from an item which ‘feeds’ entry caused this entry to be in the data? (ie, tell its source)… and can you search the feeds to locate the feed definition from any data in the item?

once u can do that, then u can use the feed entry icon

justjim1220

@sdetweil

Not quite sure I am following you correctly…
Do you mean to pull the icon from the feeds source? the website?

justjim1220

@sdetweil

ok, so how would I be able to use the corresponding icons/images for the active feed showing if there isn’t any icon data in the rest API?

sdetweil

@justjim1220 you have to match up the feed definition (feeds array) with the element in the source response (newsItems array) somehow

the source does not send the icon back

justjim1220

@sdetweil

that’s because I don’t think the source has an icon to pull from it.

So, is there a way to put the icons in an image folder in the newsfeed directory and pull from there for each corresponding newsfeed?

justjim1220

@sdetweil

this is how I was able to modify the code to show a single icon and to get it to scroll across the screen

https://forum.magicmirror.builders/assets/uploads/files/1539381868184-screenshot-146.png

sdetweil

right… you hard coded it…

justjim1220

@sdetweil

So, is what I am wanting to do even possible?

sdetweil

@justjim1220 sure… just have to figure out how to find the feeds entry from the newsItem entry… you MAY/PROBABLY have to add something to the newsItem entries (every one) when they are placed in the newsItem array…

i can’t look at any of the rss code til thursday sometime…

justjim1220

@sdetweil

Is this what I am looking for?

0_1539748209164_Screenshot (383).png

sdetweil

Note that that data is not part of the item. What code moves the xml to the Json object you are accessing?

sdetweil

looking at the code on my phone, the fetcher.js needs another method to parse out the source icon.

parser.on("image", function(image){})

To set a variable with the icon url,
That u can use in the

parser.on("item", function(item)

To add the icon url to each item to be able to use it during the display process

A Former User

@justjim1220
But not all RSS would have that channel.image. that is optional.

justjim1220

@sdetweil @sean

SO, I changed this part of the fetcher, but, after reading your posts, I am not sure if this is what you are talking about…

parser.on("item", function(item) {

			var title = item.title;
			var image = item.image || item.logo || item.img || item.svg || "";
			var description = item.description || item.summary || item.content || "";
			var pubdate = item.pubdate || item.published || item.updated || item["dc:date"];
			var url = item.url || item.link || "";

			if (title && pubdate) {

				var regex = /(<([^>]+)>)/ig;
				description = description.toString().replace(regex, "");

				items.push({
					title: title,
					image: image,
					description: description,
					pubdate: pubdate,
					url: url,
				});

			} else if (logFeedWarnings) {
				console.log("Can't parse feed item:");
				console.log(item);
				console.log("Title: " + title);
				console.log("Image: " + image);
				console.log("Description: " + description);
				console.log("Pubdate: " + pubdate);
			}
		});

It is looking like you are telling me I need to add a new section to the fetcher similar to this, but starting with

parser.on("image", function(image){})
			var title = image.title;
			var image = image.image || image.logo || image.img || image.svg || "";
			var url = image.url || image.link || "";

and would I also need this part?

                        if (image&& url) {

				var regex = /(<([^>]+)>)/ig;
				description = description.toString().replace(regex, "");

				images.push({
					title: title,
					image: image,
					url: url,
				});

			} else if (logFeedWarnings) {
				console.log("Can't parse feed item:");
				console.log(item);
				console.log("Title: " + title);
				console.log("Image: " + image);
				console.log("Description: " + description);
				console.log("Pubdate: " + pubdate);
			}
		});

And, would this be the way to add the image url in the config…

                        {
                                imageUrl: "https://static01.nyt.com/images/misc/NYT_logo_rss_250x40.png",
                                title: "New York Times",
				url: "http://www.nytimes.com/services/xml/rss/nyt/HomePage.xml"
                        },
			{
                                imageUrl: "http://online.wsj.com/img/wsj_sm_logo.gif",
				title: "Wall St. Journal",
				url: "http://www.wsj.com/xml/rss/3_7085.xml"
			},
			{
                                imageUrl: "http://www.gannett-cdn.com/sites/usatnetwork/images/RSS_Syndication_Logo-USATN.png",
				title: "USA Today",
				url: "http://rssfeeds.usatoday.com/UsatodaycomNation-TopStories"
			},
			{
                                imageUrl: "https://news.bbcimg.co.uk/nol/shared/img/bbc_news_120x60.gif",
				title: "BBC World News",
				url: "http://feeds.bbci.co.uk/news/world/rss.xml#"
			}

Sorry, for all the questions, just really trying to learn all this…
AND, thanks for all your help!!! :smiling_face_with_sunglasses:

sdetweil

ok, then to use the definition in the feed entry
modify the node helper

			fetcher = new Fetcher(url, reloadInterval, encoding, config.logFeedWarnings);

			fetcher.onReceive(function(fetcher) {
                                // add code here to run thru the array of feed response items and add the icon url to each entry..
                                // the feed definition was passed in as parm to the containing method..   because this is a callback, you will probably have to bind the feed definition to this function
                                for( var item in fetcher.items())
                                {
                                     item.icon=this.feed_def.icon;
                                 }
				self.broadcastFeeds();
			}.bind({feed_def:feed}))