• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

how to pull new element added to an array?

Scheduled Pinned Locked Moved Solved Troubleshooting
57 Posts 4 Posters 20.3k Views 4 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • S Away
    sdetweil
    last edited by Oct 17, 2018, 2:39 PM

    Note that that data is not part of the item. What code moves the xml to the Json object you are accessing?

    Sam

    How to add modules

    learning how to use browser developers window for css changes

    S 1 Reply Last reply Oct 17, 2018, 4:29 PM Reply Quote 0
    • S Away
      sdetweil @sdetweil
      last edited by sdetweil Oct 17, 2018, 4:54 PM Oct 17, 2018, 4:29 PM

      looking at the code on my phone, the fetcher.js needs another method to parse out the source icon.

      parser.on("image", function(image){})
      

      To set a variable with the icon url,
      That u can use in the

      parser.on("item", function(item)
      

      To add the icon url to each item to be able to use it during the display process

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      1 Reply Last reply Reply Quote 0
      • ? Offline
        A Former User @justjim1220
        last edited by Oct 17, 2018, 4:56 PM

        @justjim1220
        But not all RSS would have that channel.image. that is optional.

        J 1 Reply Last reply Oct 17, 2018, 5:48 PM Reply Quote 1
        • J Offline
          justjim1220 Module Developer @Guest
          last edited by justjim1220 Oct 17, 2018, 5:56 PM Oct 17, 2018, 5:48 PM

          @sdetweil @sean

          SO, I changed this part of the fetcher, but, after reading your posts, I am not sure if this is what you are talking about…

          parser.on("item", function(item) {
          
          			var title = item.title;
          			var image = item.image || item.logo || item.img || item.svg || "";
          			var description = item.description || item.summary || item.content || "";
          			var pubdate = item.pubdate || item.published || item.updated || item["dc:date"];
          			var url = item.url || item.link || "";
          
          			if (title && pubdate) {
          
          				var regex = /(<([^>]+)>)/ig;
          				description = description.toString().replace(regex, "");
          
          				items.push({
          					title: title,
          					image: image,
          					description: description,
          					pubdate: pubdate,
          					url: url,
          				});
          
          			} else if (logFeedWarnings) {
          				console.log("Can't parse feed item:");
          				console.log(item);
          				console.log("Title: " + title);
          				console.log("Image: " + image);
          				console.log("Description: " + description);
          				console.log("Pubdate: " + pubdate);
          			}
          		});
          

          It is looking like you are telling me I need to add a new section to the fetcher similar to this, but starting with

          parser.on("image", function(image){})
          			var title = image.title;
          			var image = image.image || image.logo || image.img || image.svg || "";
          			var url = image.url || image.link || "";
          

          and would I also need this part?

                                  if (image&& url) {
          
          				var regex = /(<([^>]+)>)/ig;
          				description = description.toString().replace(regex, "");
          
          				images.push({
          					title: title,
          					image: image,
          					url: url,
          				});
          
          			} else if (logFeedWarnings) {
          				console.log("Can't parse feed item:");
          				console.log(item);
          				console.log("Title: " + title);
          				console.log("Image: " + image);
          				console.log("Description: " + description);
          				console.log("Pubdate: " + pubdate);
          			}
          		});
          

          And, would this be the way to add the image url in the config…

                                  {
                                          imageUrl: "https://static01.nyt.com/images/misc/NYT_logo_rss_250x40.png",
                                          title: "New York Times",
          				url: "http://www.nytimes.com/services/xml/rss/nyt/HomePage.xml"
                                  },
          			{
                                          imageUrl: "http://online.wsj.com/img/wsj_sm_logo.gif",
          				title: "Wall St. Journal",
          				url: "http://www.wsj.com/xml/rss/3_7085.xml"
          			},
          			{
                                          imageUrl: "http://www.gannett-cdn.com/sites/usatnetwork/images/RSS_Syndication_Logo-USATN.png",
          				title: "USA Today",
          				url: "http://rssfeeds.usatoday.com/UsatodaycomNation-TopStories"
          			},
          			{
                                          imageUrl: "https://news.bbcimg.co.uk/nol/shared/img/bbc_news_120x60.gif",
          				title: "BBC World News",
          				url: "http://feeds.bbci.co.uk/news/world/rss.xml#"
          			}
          

          Sorry, for all the questions, just really trying to learn all this…
          AND, thanks for all your help!!! :smiling_face_with_sunglasses:

          "Life's Too Short To Dance With Ugly People"
          Jim Hallock - 1995

          1 Reply Last reply Reply Quote 0
          • S Away
            sdetweil
            last edited by sdetweil Oct 17, 2018, 5:57 PM Oct 17, 2018, 5:55 PM

            ok, then to use the definition in the feed entry
            modify the node helper

            			fetcher = new Fetcher(url, reloadInterval, encoding, config.logFeedWarnings);
            
            			fetcher.onReceive(function(fetcher) {
                                            // add code here to run thru the array of feed response items and add the icon url to each entry..
                                            // the feed definition was passed in as parm to the containing method..   because this is a callback, you will probably have to bind the feed definition to this function
                                            for( var item in fetcher.items())
                                            {
                                                 item.icon=this.feed_def.icon;
                                             }
            				self.broadcastFeeds();
            			}.bind({feed_def:feed}))
            

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            J 1 Reply Last reply Oct 17, 2018, 6:08 PM Reply Quote 0
            • J Offline
              justjim1220 Module Developer @sdetweil
              last edited by Oct 17, 2018, 6:08 PM

              @sdetweil

              well, sort of lost me there, but also getting a headache.

              Gotta run some errands, I’ll look at it some more after a while.

              AGAIN, THANK YOU for all the help!!!

              "Life's Too Short To Dance With Ugly People"
              Jim Hallock - 1995

              1 Reply Last reply Reply Quote 0
              • S Away
                sdetweil
                last edited by sdetweil Oct 17, 2018, 11:23 PM Oct 17, 2018, 8:27 PM

                @justjim1220 said in how to pull new element added to an array?:

                var image = item.image || item.logo || item.img || item.svg || “”;

                that looks good, except as you note, these are optional in the response (item) data.

                do you want to use the configured url for the feed if not present?

                var image = item.image || item.logo || item.img || item.svg || xxxx.yyy.icon || "";
                

                the feed definition is passed into the fetcher function. except that routine could have ended seconds ago, when the parser.on(item) method is called (by the callback)…

                so, what should xxxx.yyy be? can’t use the parm feed directly, as the routine could have exited already…

                so, javascript gives you the ability to bind (connect) a variable with a routine when it is called asyncronously…

                when u bind the variable, it will be accessible in the context of the function, context = this,

                so, on the close brace of the function defined on the .on(), add the .bind() clause.

                inside the bind clause, you specify the name of the variable INSIDE the function, and connect it to the variable at the time the .on() definition is called… (ie ‘feed’)…

                so,

                }.bind({feed_var_in_function:feed})
                

                then when the function is called, you can get access to the variable using ‘this’…

                this.feed_var_in_function.icon, would be the icon defined for THIS feed

                therefore the stmt above would be

                var image = item.image || item.logo || item.img || item.svg || this.feed_var_in_function.icon || "";
                

                this says, use any of the optional images in the feed item, if present,
                else use the user defined feed icon,
                else nothing if not defined…

                Sam

                How to add modules

                learning how to use browser developers window for css changes

                J 1 Reply Last reply Oct 18, 2018, 12:22 AM Reply Quote 0
                • J Offline
                  justjim1220 Module Developer @sdetweil
                  last edited by Oct 18, 2018, 12:22 AM

                  @sdetweil

                  ok, so do I need to add it like this:

                  parser.on("image", function(image){})
                  			var title = image.title;
                  			var image = image.image || image.logo || image.img || image.svg || this.feed_var_in_function.icon || "";
                  			var url = image.url || image.link || "";
                  

                  Or, like this:

                  parser.on("image", function(image){})
                  			var title = image.title;
                  			var image = item.image || item.logo || item.img || item.svg || this.feed_var_in_function.icon || "";
                  			var url = image.url || image.link || "";
                  

                  "Life's Too Short To Dance With Ugly People"
                  Jim Hallock - 1995

                  1 Reply Last reply Reply Quote 0
                  • C Offline
                    cowboysdude Module Developer
                    last edited by Oct 18, 2018, 1:36 AM

                    Why are making this so hard?

                    J 1 Reply Last reply Oct 18, 2018, 1:37 AM Reply Quote 0
                    • J Offline
                      justjim1220 Module Developer @cowboysdude
                      last edited by Oct 18, 2018, 1:37 AM

                      @cowboysdude

                      GOD, I WISH I KNEW!!!

                      "Life's Too Short To Dance With Ugly People"
                      Jim Hallock - 1995

                      1 Reply Last reply Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 4
                      • 5
                      • 6
                      • 2 / 6
                      2 / 6
                      • First post
                        22/57
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy