MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    MMM-RNV

    Scheduled Pinned Locked Moved Transport
    9 Posts 2 Posters 5.3k Views 2 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • mcgM Offline
      mcg
      last edited by

      Hey @yawns, looks great!

      Even the differentiation between tram and bus, cool!
      I was surprised by the delay times as well, when I thought about building such a module (and thus starting to learn JS) I just had a rough look at the VRN API which doesn’t offer any real time data.

      I have two feature requests:

      • configurable number of shown connections
      • configurable direction (or destination)

      Cheers!

      yawnsY 1 Reply Last reply Reply Quote 1
      • yawnsY Offline
        yawns Moderator @mcg
        last edited by

        @mcg
        Hi, glad you like it.
        What do you mean with configurable direction?

        1 Reply Last reply Reply Quote 0
        • mcgM Offline
          mcg
          last edited by

          I mean that I dont want to see all connections leaving from that particular stop but just in one direction.
          E.g. if I lived near a final destination I would just want to see the city-bound connections.

          1 Reply Last reply Reply Quote 0
          • mcgM Offline
            mcg
            last edited by mcg

            Hey @yawns!
            I finally had a deeper look into the API and your code and felt free to adapt it a little according to my needs.

            I did the following things:

            • added the so called poles to be defined in the personal config
              this enables one to choose certain tracks/platforms at a particular stop (this was what i spoke about when I replied to your post the first time)
            • added a time offset, which it would take one to reach the acutal stop (by foot).
            • correction of the current time format from 12h to 24h, which led to an error when I tested the offset. (from hh --> HH)
            • edited the readme

            Because I’m completely new to Github I hope I did the most of it right till now. Guess the next step would be to create a pull request if you like, right?

            Cheers!

            1 Reply Last reply Reply Quote 3
            • yawnsY Offline
              yawns Moderator
              last edited by

              Looks good, I like your changes. Yes please, submit a pull request and I will add it to the main repository so other users can benefit from your changes

              1 Reply Last reply Reply Quote 0
              • mcgM Offline
                mcg
                last edited by

                Alright,
                i found a bug which led to still showing connections after the offset.

                Newest release has

                • offset bug fixed
                • new option to choose how many departures shall be shown (between 1 and 10)

                I’m gonna test this release a few days and then send a pull request :)

                1 Reply Last reply Reply Quote 1
                • mcgM Offline
                  mcg
                  last edited by

                  Alright, I sent you a pull request.


                  Additionally, I’m currently testing another new feature where

                  • delay is shown for all connections which have already started even if there is no delay.
                    0_1526053734526_8e0837d9-f492-4990-b3d1-26ee12c4f749-grafik.png
                  1 Reply Last reply Reply Quote 0
                  • 1 / 1
                  • First post
                    Last post
                  Enjoying MagicMirror? Please consider a donation!
                  MagicMirror created by Michael Teeuw.
                  Forum managed by Sam, technical setup by Karsten.
                  This forum is using NodeBB as its core | Contributors
                  Contact | Privacy Policy