@np27np27 do you mean you can still see the issue with that version? :(
If so, most likely it is not resolved. I will need to find some time to look into it again

@np27np27 hey, I have just realized I mistakenly pushed the code with some hardcoded test values. Those might be the reason for the wrong behavior.

Can you try pulling the code again and let me know?

@np27np27 ok :( thanks for the info. I’ll be taking another look.
I think as a workaround you can probably try to refresh the mirror, but I understand it is not the desired behavior…

@np27np27 you can switch back to the master branch and do a git pull.

It does not look like the Africa nation cup is supported by the APIs :(

There is a further new update available here (still under development)
https://github.com/0m4r/MMM-covid19/tree/feat/new-api-corona-lmao-ninja

I have added two new config properties: locale and yesterday - please refer to the https://github.com/0m4r/MMM-covid19/tree/feat/new-api-corona-lmao-ninja/README.md for the details ;)

@np27np27 I put in a fix, not sure it works 100% :P

I have noticed tho, my approach is not really the best, will need to re-think it and re-implement it. I’d like to reach a point where the API calls are done only if and when needed to reduce network traffic and avoid overloading the API service provider too.

@np27np27 thanks for the hint - I will be looking into it.

Good news! I have updated the module to swap the data provider to a new one (that seems to be more reliable and provides the most recent available data and, some additional ones too!)

The changes are still on a development branch, so if you are interested in trying them out you can do the following (assuming you are in your Magic Mirror module folder for MMM-covid19):

git fetch -p
git checkout feat/new-api-corona-lmao-ninja
git pull -r
npm install

the configuration does not require any update, but a few settings are now obsolete and not used, this is how the new configuration settings could be looking like:

countryCodes: ["DE", "IT", "US", "NZ", "UK", "FR", "IN", "ES", "BG", "GR"],
useScheduler: true,
schedulerConfig: '0 0 */1 * * */1', // update every hour, every day
updateInterval: 0.5 * 60 * 1000, // update every 30 seconds, only used if useScheduler: false

and here is a screenshot:

and here is the GitHub repo:
https://github.com/0m4r/MMM-covid19/tree/feat/new-api-corona-lmao-ninja

@np27np27 well, I hope so!
Let’s keep an eye on it and see if it really works or if it is just a feeling we have!
Thanks for the feedback!

@np27np27 I am checking right now the results for “Serie A” and they seem to update…

@np27np27 I’ll check that :(

@np27np27 if you pull once again, I did a quick fix to mark them in orange.
I will look into the API requests side of the things… but better too many than too few! :D

@np27np27

and can you see something like this in the logs:
MMM-SoccerLiveScore next request for league "Premier League (17)" on Tue Dec 14 2021 14:34:37 GMT+0100 (Central European Standard Time) for Round 17

@np27np27 I am sorry to hear that :(
you should try again from the feature/node-fetch .

if you see any errors, would you please cut&paste them in here so I can have a look at them?

would you also mind showing me your config for the module?

@np27np27 there are probably still some issue, but it seems to me it now updates correctly :)

@np27np27 can you try pulling the code once more? I did mess up the logic to re-issue the API requests, but I hopefully fixed it now!

@np27np27 said in MMM-SoccerLiveScore:

git checkout node-fetch

should be:

git checkout feature/node-fetch

@np27np27 can you try check out and run this branch:
https://github.com/0m4r/MMM-SoccerLiveScore/tree/feature/node-fetch

> cd [YOUR_PATH_TO_MMM-SoccerLiveScore]
> git fetch -p
> git checkout feature/node-fetch 
> git pull -r
> npm ci
> [RESTART MM]

I did do some major changes (removed request for node-fetch, and some other code improvements amongst which I hope to have fixed the problem of the refresh you reported)

@np27np27 alright - I will try to fix it, but it may take some time, I usually dedicate time to my side project on the weekend