Hey there
I created a recipe module to inspire myself what to cook next evening. Therefore I just copied the default newsfeed module and added some html blocks to show the image referenced by the rss entry.

Nice try but my developer’s heart is bleeding because copying code is always a bad idea.

What about adding this functionality to show images referenced in rss news feeds to the default newsfeed module and make it configurable to activate the images? I could add this feature and make a pull request, what do you think? So in this case everybody could use the newsfeed module to display anything and in cases of e.g. recipes to show an image as well.

BTW: Thank you very much for starting this absolutely great open source project and everybody for participating. I love my mirror!

Regards,
Stephan

Hi @strawberry-3-141
I am using and loving your module! Unfortunately I’ve found a bug with your module running together with the MMM-Carousel. I have three MMM-Soccer module configs, one for Germany, one for England and one for Spain. My idea was to show every table for 3 seconds and then move on to the next one.

But I encountered this problem: It always shows me the same league. Now a played with it and set the max_team value for these leagues to different values and it perfectly changes the amount of teams to the correct value, but always with the same teams for the same leagues.

So I guess the problem could be that when the show method gets called it does not reload the league (or get it out of a cache).

I tried to fix it but I am not a javasript guru so I didn’t find the problem code. Do you have an idea how to make the module reload the league data?

I hopoe you can help me!

Best regards,
Stephan

I would like to add modules more than once to my mirror but I encounterd some problems. I have two scenarios I would like to do with my mirror:

The first one is using the Newsfeed module twice. After I added the possibilty to show images from newsfeeds I would like to add it once as a newsticker in the bottom corner (without an image) and an second time in a top corner to show recipes with a tasty image. This runs almost fine, one strange this is that the seconds module freezes in “loading” mode until the second update iteration. After that iteration it runs fine.

The seconds scenario is using the MMM-Carousel module to display sport results. Therefore I add the MMM-NFL module once and the MMM-soccer three times to show the table from Spain, England and Germany. I would like to rotate between these 4 modules. Right now it shows only the NFL and one soccer module, the other two are lost.

I guess, the reason is that in config.js the modules do not have unique names, they just have a module name. So when you add a module several times this could lead to unexpected behavior.

What do you think guys, which way could be the best: Adding a id value in the config modules that uniquely defines a module? This would be a breaking change to the API where everybody has to adopt it. Or adding an alias value which could be optional and when not set it is equal to the module value?

Or are there maybe already custom modules that could fulfill my needs? I didn’t check the code yet, how easy this would be to implement. What do you think, has anybody similiar needs? Should I go for it?

Hi @roramirez
I just created a pull request, my first one ever! I hope I did everything right and you like it. Looking forward for any comments and enhancement tips.

Hey there
I created a recipe module to inspire myself what to cook next evening. Therefore I just copied the default newsfeed module and added some html blocks to show the image referenced by the rss entry.

Nice try but my developer’s heart is bleeding because copying code is always a bad idea.

What about adding this functionality to show images referenced in rss news feeds to the default newsfeed module and make it configurable to activate the images? I could add this feature and make a pull request, what do you think? So in this case everybody could use the newsfeed module to display anything and in cases of e.g. recipes to show an image as well.

BTW: Thank you very much for starting this absolutely great open source project and everybody for participating. I love my mirror!

Regards,
Stephan

And did you check the /home/pi/.pm2/logs log-files?

what urls are you using? the javascript script code says that when no news items are found, the Loading… is shown.

were you using the browser on your raspi or one on another computer? because both modules connecting to the internet are not working, this could indicate a problem with the internet connection or proxy

What happens when you call the urls from your calendar und news feed out of the config.js file directly in a browser? Do you see any content?