Read the statement by Michael Teeuw here.
MMM-PGA
-
@swvalenti Awesome. Glad it is working.
-
@mumblebaj module is stuck on loading but no errors in dev console?
-
@swvalenti Are you using the original module? Is this happening after upgrade to MM2.19? Did you do the normal git pull && npm install in the module folder? Is there any errors in the pm2 logs if you are using pm2 or in the console if you are using npm start?
-
@mumblebaj I am using your fork and it worked fine for 2.19 for couple weeks just stopped the other day.
-
@swvalenti I will have a look in the morning. It is almost midnight where I am. :-(
-
@swvalenti Seems like there was a major upgrade in the JSON return data. Loads of changes. Not going to be an easy task to work through them all. I do not have easy fixes for it. I will see if I have time to work through them.
-
@mumblebaj any easy way for me to figure this out, if I comment out that line it works.
[18.04.2023 11:31.09.632] [LOG] MMM-PGA retrieving Tournament Data [18.04.2023 11:31.09.633] [ERROR] Whoops! There was an uncaught exception... [18.04.2023 11:31.09.633] [ERROR] TypeError: Cannot read properties of undefined (reading 'displayName') at Request._callback (C:\Users\CCU Forensic Machine\MagicMirror\modules\MMM-PGA\ESPN.js:49:99) at self.callback (C:\Users\CCU Forensic Machine\MagicMirror\modules\MMM-PGA\node_modules\request\request.js:185:22) at Request.emit (node:events:513:28) [18.04.2023 11:38.48.117] [LOG] MMM-PGA retrieving FedEx Cup Standings [18.04.2023 11:38.48.185] [ERROR] Whoops! There was an uncaught exception... [18.04.2023 11:38.48.185] [ERROR] TypeError: Cannot read properties of undefined (reading 'querySelectorAll') at Request._callback (C:\Users\CCU Forensic Machine\MagicMirror\modules\MMM-PGA\FEDEXCUP.js:33:38) -
@swvalenti Can you show me what you changed? Did you comment out displayName in ESPN.js or the line with querySelectorAll in FEDEXCUP.js?
-
@mumblebaj just the espn.js sir
-
@swvalenti Does you line 49 look like the following?
tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.displayName : -
@mumblebaj said in MMM-PGA:
tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.displayName :
tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.athlete.displayName : "" -
@swvalenti Thanks for the above. Seem the data has changed. Change it to the following:
tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.displayName : ""I will make a change and deploy but there is more data that changed. Need to check the others as well.
-
@mumblebaj said in MMM-PGA:
tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.displayName : “”
changed it but still stuck on loading
-
@swvalenti Yeah, seems like it is a team tournament hence there is no individual athlete information. Busy looking at it.
-
@mumblebaj No worries bro appreciate the time let me know if I can be of help
-
@swvalenti OWGR is broken as well. Website changed and the code in there is completely out dated. So much issues I am not sure if I can fix them. It needs a complete re-write.
-
@mumblebaj oh man that sucks its my favorite module…I can pay ya…ha
-
@mumblebaj randomly started working again but def missing some stuff
-
S sdetweil referenced this topic on
-
Just FYI, I’ve taken over primary maintenance of this module. It is now available at https://github.com/dathbe/MMM-PGA, with a handful of bug fixes.
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login