[INFO] Be careful to use iCal sample of config.js

mumblebaj

@MMRIZE I grab mine off Office Holidays in case somebody is looking for an alternative.

ankonaskiff17

@sdetweil Where are you correcting this?
Reason I ask is because the default in Calender.js is set to 5 minutes and if you don’t change it in config.js doesn’t it fall back to the module default values?

It is likely most MM builders do very little to config.js regarding the calendar. When they do initial install of MM, the basic calendar module is loaded, calendar.js is just chugging along updating every 5 minutes out of sight.

sdetweil

@ankonaskiff17 yes, we will adjust timing for Saturday release to 7 days. I think we are trying to add interval by calendar {url}, instead of one setting for all calendars in this config instance.

sdetweil

@ankonaskiff17 good point on the default setting

ankonaskiff17

@sdetweil I went back and looked at an older MM thats been running quite some time to see if I somehow would have missed that setting because, being a holiday calendar it doesn’t change, period. Some things change such as Easter but annually. I’ve run into that update issue on other modules such as weather.

I saw that item posted on forum and first thing I did was look at my config.js file and nothing related to updates so immediately went to the module file and there it was, 5 minute update interval.

More like as more and more Magic Mirrors got built the upate requests were going up with each mirror. and since when a given mirror’s 5 minute cycle would time out I can imagine they were getting slammed.

MMRIZE

I think default 5 min is not so burden really (even with 3000 mirrors do so synchronously)
But a few cases definitely are misconfigured even unintentionally. Some people might make confusion, for example they thought 60 * 60 means 1 hour, but it is 3.6 seconds and it would probably make around 20 calls per minute.

BKeyport

@MMRIZE It could also be with as many MM systems out there a simple timing issue. every 5 minutes, bam 3000 systems flood CL with requests. Maybe start changing default to once a week on holiday calendar at most.

ankonaskiff17

@BKeyport @MMRIZE I think the problem is that calendar.js default fetch interval is set to 5 minutes.
When you set about to build a MM and you install the core system, Calendar.js fetchinterval is set to 5 minutes by default.

If I install MM AND I’m content with the presentation of the calendar AS IS and do nothing at all, calendar.js is going to reach for an update every 5 minutes.

BKeyport

@ankonaskiff17 … ahh, good point, forgot the fetch interval is not per item. Hey, @sdetweil - it’s your baby, you want to add a fetchInterval override variable per calendar, and default in the sample config.js to once a week or more for the holidays calendar? This would solve the issue CL is having with at least new installs…

As for the old ones, could we check to see if CL 's holiday calendar is being used, and inform or force an override for fetchInterval to solve for most?

(Just did a check and I’m not using CL’s holiday calendar, so whew)

sdetweil

@ankonaskiff17 we are changing the default to days I think. this for es u to make it faster if u want

I think the minimum should be 5 minutes