• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

MMM-Netatmo does not load

Scheduled Pinned Locked Moved Utilities
33 Posts 13 Posters 7.8k Views 14 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • T Offline
    tommys
    last edited by Oct 22, 2023, 4:54 PM

    I’m running nodejs v20.8.1 on Ubuntu 22.04 and most MagicMirror modules run fine, except for MMM-Netatmo. It seems to get stuck when fetch-ing the oauth2/token-request, though it receives a response with status 200, but then nothing seems to happen!?
    When I manually post the same request using curl from the command line, it works great and I get my access token, which I successfully can use using curl to get my api/getstationdata.
    The last thing I’m able to debug into is in the node-fetch’s worker.js file:

    process.stdin.on('end', function () {
      const input = JSON.parse(chunks.join(''))
      const request = shared.deserializeRequest(fetch, ...input)
    
      fetch(request)
        .then(response => response.buffer()
          .then(buffer => respond([
            buffer.toString('base64'),
            shared.serializeResponse(response)
          ]))
    
    

    I can see that shared is updated with at response-header, however, I cannot see the response-body data that is supposed to contain the access-token among other things. And, for me, not being a nodejs/javascript programmer, the app seems to hang with the only thing being shown in the MMM-Netatmo widget is “Loading” forever.

    What could be causing my problems?

    Of course, I have triple checked that my config settings are correct:

    {
        module: 'netatmo',
        position: 'top_center', 
        header: 'Netatmo',
        config: {
            clientId: 'xxx',
            clientSecret: 'yyy', 
            refresh_token: 'zzz', 
            moduleOrder: ["Inomhus","Utomhus"]
        }
    }
    

    Regards,
    /Tommy

    T 1 Reply Last reply Oct 30, 2023, 7:17 AM Reply Quote 0
    • T Offline
      tommys @tommys
      last edited by Oct 30, 2023, 7:17 AM

      @tommys
      Replying to myself since I finally have solved the problem! Netatmo is now loading fine on the latest versions of MM and MMM-Netatmo.
      The problem was actually caused by two independent problems: the module reordering algorithm and the sync-fetch library.
      The workaround I did to solve the first problem was simply to not set the moduleOrder config property, easy as that.
      The second workaround was a bit more involved, I completely removed the usage of the sync-fetch library in netatmo.js in favor of the default async version . That is, simply remove the line: const fetch = require(‘sync-fetch’), make the authenticate, loadData and socketNotificationReceived functions async, handle the promise object returned by fetch appropriately as well as the call to json().

      S C C L 4 Replies Last reply Oct 30, 2023, 5:55 PM Reply Quote 2
      • S Offline
        sdetweil @tommys
        last edited by sdetweil Dec 9, 2023, 12:29 PM Oct 30, 2023, 5:55 PM

        @tommys the reason for this is fetch is built in in the node 20.8 version used by the node helper.

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        1 Reply Last reply Reply Quote 0
        • C Offline
          CFenner @tommys
          last edited by Nov 6, 2023, 1:07 PM

          @tommys great that you solved the issue! Would you mind contributing that back into the repository?

          T 1 Reply Last reply Nov 6, 2023, 9:52 PM Reply Quote 0
          • T Offline
            tommys @CFenner
            last edited by Nov 6, 2023, 9:52 PM

            @CFenner normally I would say: Yes, absolutely! But… I’m not a javascript-developer and know very little about it and node.js.
            This is the first time I dipped my toe in this world (I’ve been working for 30 years as a C++ developer :grinning_face_with_sweat: ) so I just tried things until I got it working. I have probably done something non-idiomatic or worse, so I think it is better that someone more knowledgable do a proper fix. But I’m happy to answer questions if more info than I already provided is needed.
            Btw, a big thank you for your great Netatmo-module @CFenner! :folded_hands:

            1 Reply Last reply Reply Quote 0
            • W Offline
              wwats
              last edited by Dec 15, 2023, 4:32 PM

              Hello everybody, I have the same problem. Because I’m not an IT professional, I’m having trouble solving the problem with your instructions.
              The second workaround in particular is difficult:
              …I completely removed the usage of the sync-fetch library in netatmo.js in favor of the default async version . That is, simply remove the line: const fetch = require(‘sync-fetch’), make the authenticate, loadData and socketNotificationReceived functions async, handle the promise object returned by fetch appropriately as well as the call to json().

              • I can’t find the “const fetch” line in the netatmo.js file
              • how can I make functions asynchronous
              • the sentence “handle the promise object returned by fetch appropriately as well as the call to json().” I don’t really understand either

              Is it possible to make the instructions a bit more detailed? Or what is the best way to ensure that the great module works for me again?

              Thank you very much for your effort!

              1 Reply Last reply Reply Quote 0
              • C Offline
                cgillinger @tommys
                last edited by Jan 1, 2024, 6:42 PM

                @tommys I have the same problem, but while I can follow instructions and edit files, your description is a bit to advanced for me.

                Could you break it down, I would really like to get the module working again!

                C 1 Reply Last reply Jan 3, 2024, 1:31 PM Reply Quote 0
                • C Offline
                  CFenner @cgillinger
                  last edited by Jan 3, 2024, 1:31 PM

                  @cgillinger I merged a PR from @ottolote to replace the sync-fetch. Please try if that fixes the issue for you. It work for me now, but also did before that change using mm v2.26.

                  C L 2 Replies Last reply Jan 4, 2024, 10:17 AM Reply Quote 2
                  • C Offline
                    cgillinger @CFenner
                    last edited by Jan 4, 2024, 10:17 AM

                    @CFenner And just to report back here as well: Now the module works for me again! Thnx!

                    1 Reply Last reply Reply Quote 1
                    • L Offline
                      Laz @CFenner
                      last edited by Jan 16, 2024, 10:29 AM

                      @CFenner
                      Have you updated your module? Does it need to be reinstated or how to update it?

                      1 Reply Last reply Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 4
                      • 1 / 4
                      • First post
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy