MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Calendar shows late day events on next day but at correct time

    Scheduled Pinned Locked Moved Unsolved Troubleshooting
    35 Posts 4 Posters 7.1k Views 6 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • N Offline
      natmash
      last edited by

      BEGIN:VEVENT
      CREATED:20240904T053053Z
      DTEND;TZID=America/Chicago:20240910T211500
      DTSTAMP:20240925T005517Z
      DTSTART;TZID=America/Chicago:20240910T201500
      LAST-MODIFIED:20240925T005515Z
      LOCATION:Dance Class
      RELATED-TO;RELTYPE=X-CALENDARSERVER-RECURRENCE-SET:2D48CA37-FCE5-4E16-871
      9-1F47160BDBA3
      RRULE:FREQ=WEEKLY;UNTIL=20250601T011500Z
      SEQUENCE:3
      SUMMARY:Wife Barre Class
      UID:39669340-7AFD-4685-9BD6-6CE4B715486E
      X-APPLE-CREATOR-IDENTITY:com.apple.mobilecal
      END:VEVENT

      S 2 Replies Last reply Reply Quote 1
      • S Offline
        sdetweil @natmash
        last edited by

        @natmash thanks

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        1 Reply Last reply Reply Quote 0
        • N Offline
          natmash
          last edited by

          Barre Class, with dates: ["2024-09-11T01:15:00.000Z","2024-09-18T01:15:00.000Z","2024-09-25T01:15:00.000Z","2024-10-02T01:15:00.000Z","2024-10-09T01:15:00.000Z","2024-10-16T01:15:00.000Z","2024-10-23T01:15:00.000Z","2024-10-30T01:15:00.000Z","2024-11-06T01:15:00.000Z","2024-11-13T01:15:00.000Z","2024-11-20T01:15:00.000Z","2024-11-27T01:15:00.000Z","2024-12-04T01:15:00.000Z","2024-12-11T01:15:00.000Z","2024-12-18T01:15:00.000Z","2024-12-25T01:15:00.000Z","2025-01-01T01:15:00.000Z","2025-01-08T01:15:00.000Z","2025-01-15T01:15:00.000Z","2025-01-22T01:15:00.000Z","2025-01-29T01:15:00.000Z","2025-02-05T01:15:00.000Z","2025-02-12T01:15:00.000Z","2025-02-19T01:15:00.000Z","2025-02-26T01:15:00.000Z","2025-03-05T01:15:00.000Z","2025-03-12T01:15:00.000Z","2025-03-19T01:15:00.000Z","2025-03-26T01:15:00.000Z","2025-04-02T01:15:00.000Z","2025-04-09T01:15:00.000Z","2025-04-16T01:15:00.000Z","2025-04-23T01:15:00.000Z","2025-04-30T01:15:00.000Z","2025-05-07T01:15:00.000Z","2025-05-14T01:15:00.000Z","2025-05-21T01:15:00.000Z","2025-05-28T01:15:00.000Z"]
          [2024-09-28 11:26:06.920] [DEBUG] Rule has byweekday, checking for correction
          [2024-09-28 11:26:06.920] [DEBUG] West of GMT (tzOffset: 5) and hour=20 >= 24-5, Adding 1 day to Tue Sep 10 2024 20:15:00 GMT-0500 (Central Daylight Time)
          [2024-09-28 11:26:06.920] [DEBUG] West of GMT (tzOffset: 5) and hour=20 >= 24-5, Adding 1 day to Tue Sep 17 2024 20:15:00 GMT-0500 (Central Daylight Time)
          [2024-09-28 11:26:06.920] [DEBUG] West of GMT (tzOffset: 5) and hour=20 >= 24-5, Adding 1 day to Tue Sep 24 2024 20:15:00 GMT-0500 (Central Daylight Time)
          [2024-09-28 11:26:06.920] [DEBUG] West of GMT (tzOffset: 5) and hour=20 >= 24-5, Adding 1 day to Tue Oct 01 2024 20:15:00 GMT-0500 (Central Daylight Time)
          [2024-09-28 11:26:06.920] [DEBUG] West of GMT (tzOffset: 5) and hour=20 >= 24-5, Adding 1 day to Tue Oct 08 2024 20:15:00 GMT-0500 (Central Daylight Time)
          [2024-09-28 11:26:06.920] [DEBUG] West of GMT (tzOffset: 5) and hour=20 >= 24-5, Adding 1 day to Tue Oct 15 2024 20:15:00 GMT-0500 (Central Daylight Time)
          [2024-09-28 11:26:06.920] [DEBUG] West of GMT (tzOffset: 5) and hour=20 >= 24-5, Adding 1 day to Tue Oct 22 2024 20:15:00 GMT-0500 (Central Daylight Time)
          [2024-09-28 11:26:06.920] [DEBUG] West of GMT (tzOffset: 5) and hour=20 >= 24-5, Adding 1 day to Tue Oct 29 2024 20:15:00 GMT-0500 (Central Daylight Time)
          [2024-09-28 11:26:06.920] [DEBUG] West of GMT (tzOffset: 6) and hour=19 >= 24-6, Adding 1 day to Tue Nov 05 2024 19:15:00 GMT-0600 (Central Standard Time)
          
          S 2 Replies Last reply Reply Quote 0
          • S Offline
            sdetweil @natmash
            last edited by

            @natmash yes… code I put in to fix another bug, in the repeating rule parser… it used to return the day prior UTC date and right time… so I adjusted it.
            now in this one case it returns the correct UTC date…

            if I fix this it breaks other testcases…

            looking for another option

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            1 Reply Last reply Reply Quote 0
            • S Offline
              sdetweil @natmash
              last edited by

              @natmash so, I think I finally have a fix for this.
              Would you like to try it?

              Which MagicMirror version are you using?

              Sam

              How to add modules

              learning how to use browser developers window for css changes

              M 1 Reply Last reply Reply Quote 0
              • M Offline
                MarcLandis Module Developer @sdetweil
                last edited by

                @sdetweil I am going to test your fix with my calendar too, as it was the cause for the initial fix.

                S 1 Reply Last reply Reply Quote 0
                • S Offline
                  sdetweil @MarcLandis
                  last edited by

                  @MarcLandis you want it on 2.28 or 2.29?

                  Sam

                  How to add modules

                  learning how to use browser developers window for css changes

                  M 1 Reply Last reply Reply Quote 0
                  • M Offline
                    MarcLandis Module Developer @sdetweil
                    last edited by

                    @sdetweil 2.29 please

                    (2.28 is too old :) )

                    S 1 Reply Last reply Reply Quote 0
                    • S Offline
                      sdetweil @MarcLandis
                      last edited by

                      @MarcLandis understood, but I don’t want to force upgrade to test

                      Sam

                      How to add modules

                      learning how to use browser developers window for css changes

                      S 1 Reply Last reply Reply Quote 0
                      • S Offline
                        sdetweil @sdetweil
                        last edited by sdetweil

                        @MarcLandis @natmash

                        here is a test version of the fixes for all kinds of calendar date problems.

                        best to make a new folder and git clone there

                        git  clone https://github.com/sdetweil/MagicMirror
                        cd MagicMirror 
                        git checkout fixcaldates
                        npm run install-mm
                        

                        copy your config.js and custom.css from the prior folder
                        and the non-default modules you have installed…

                        this ONLY changes the default calendar
                        but DOES ship an updated node-ical library too

                        if you need to fall back, just rename the folders around again so that
                        your original is called MagicMirror

                        all the testcases for node-ical and MagicMirror execute successfully.

                        the ‘BIG’ change here is to get the local NON-TZ dates for the
                        rrule.between()

                        all the checking and conversion code is commented out or not used
                        the node-ical fixes are for excluded dates (exdate) values being adjusted for DST/STD time… waiting to submit that PR

                        one fix in calendar.js for checking if a past date was too far back,
                        but it never checked to see IF the event date was in the past… (before today) so it chopped off too many

                        and one change in calendarfetcher.js to put out a better diagnostic message of the parsed data… (exdate was excluded cause JSON stringify couldn’t convert the complex structure)

                        Sam

                        How to add modules

                        learning how to use browser developers window for css changes

                        M 1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 3
                        • 4
                        • 2 / 4
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy