MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Calendar shows late day events on next day but at correct time

    Scheduled Pinned Locked Moved Unsolved Troubleshooting
    35 Posts 4 Posters 7.1k Views 6 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • S Offline
      sdetweil @natmash
      last edited by

      @natmash yes… code I put in to fix another bug, in the repeating rule parser… it used to return the day prior UTC date and right time… so I adjusted it.
      now in this one case it returns the correct UTC date…

      if I fix this it breaks other testcases…

      looking for another option

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      1 Reply Last reply Reply Quote 0
      • S Offline
        sdetweil @natmash
        last edited by

        @natmash so, I think I finally have a fix for this.
        Would you like to try it?

        Which MagicMirror version are you using?

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        M 1 Reply Last reply Reply Quote 0
        • M Offline
          MarcLandis Module Developer @sdetweil
          last edited by

          @sdetweil I am going to test your fix with my calendar too, as it was the cause for the initial fix.

          S 1 Reply Last reply Reply Quote 0
          • S Offline
            sdetweil @MarcLandis
            last edited by

            @MarcLandis you want it on 2.28 or 2.29?

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            M 1 Reply Last reply Reply Quote 0
            • M Offline
              MarcLandis Module Developer @sdetweil
              last edited by

              @sdetweil 2.29 please

              (2.28 is too old :) )

              S 1 Reply Last reply Reply Quote 0
              • S Offline
                sdetweil @MarcLandis
                last edited by

                @MarcLandis understood, but I don’t want to force upgrade to test

                Sam

                How to add modules

                learning how to use browser developers window for css changes

                S 1 Reply Last reply Reply Quote 0
                • S Offline
                  sdetweil @sdetweil
                  last edited by sdetweil

                  @MarcLandis @natmash

                  here is a test version of the fixes for all kinds of calendar date problems.

                  best to make a new folder and git clone there

                  git  clone https://github.com/sdetweil/MagicMirror
                  cd MagicMirror 
                  git checkout fixcaldates
                  npm run install-mm
                  

                  copy your config.js and custom.css from the prior folder
                  and the non-default modules you have installed…

                  this ONLY changes the default calendar
                  but DOES ship an updated node-ical library too

                  if you need to fall back, just rename the folders around again so that
                  your original is called MagicMirror

                  all the testcases for node-ical and MagicMirror execute successfully.

                  the ‘BIG’ change here is to get the local NON-TZ dates for the
                  rrule.between()

                  all the checking and conversion code is commented out or not used
                  the node-ical fixes are for excluded dates (exdate) values being adjusted for DST/STD time… waiting to submit that PR

                  one fix in calendar.js for checking if a past date was too far back,
                  but it never checked to see IF the event date was in the past… (before today) so it chopped off too many

                  and one change in calendarfetcher.js to put out a better diagnostic message of the parsed data… (exdate was excluded cause JSON stringify couldn’t convert the complex structure)

                  Sam

                  How to add modules

                  learning how to use browser developers window for css changes

                  M 1 Reply Last reply Reply Quote 0
                  • M Offline
                    MarcLandis Module Developer @sdetweil
                    last edited by

                    @sdetweil I testet your branch and so far it looks good with my test calendar and also with my real ones.

                    S 2 Replies Last reply Reply Quote 1
                    • S Offline
                      sdetweil @MarcLandis
                      last edited by

                      @MarcLandis thanks. i still have some reported issues. so use it and let me know. will advise when i make nect updates

                      we wouldn’t release til jan anyhow, so we have time

                      Sam

                      How to add modules

                      learning how to use browser developers window for css changes

                      1 Reply Last reply Reply Quote 0
                      • S Offline
                        sdetweil @natmash
                        last edited by

                        @natmash please see my latest test update this entry is now added to the testcases run

                        (I had NOT fixed it before today)

                        Sam

                        How to add modules

                        learning how to use browser developers window for css changes

                        N 1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 3
                        • 4
                        • 2 / 4
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy