Calendar shows late day events on next day but at correct time

sdetweil

@natmash yes… code I put in to fix another bug, in the repeating rule parser… it used to return the day prior UTC date and right time… so I adjusted it.
now in this one case it returns the correct UTC date…

if I fix this it breaks other testcases…

looking for another option

sdetweil

@natmash so, I think I finally have a fix for this.
Would you like to try it?

Which MagicMirror version are you using?

MarcLandis

@sdetweil I am going to test your fix with my calendar too, as it was the cause for the initial fix.

sdetweil

@MarcLandis you want it on 2.28 or 2.29?

MarcLandis

@sdetweil 2.29 please

(2.28 is too old :) )

sdetweil

@MarcLandis understood, but I don’t want to force upgrade to test

sdetweil

@MarcLandis @natmash

here is a test version of the fixes for all kinds of calendar date problems.

best to make a new folder and git clone there

git  clone https://github.com/sdetweil/MagicMirror
cd MagicMirror 
git checkout fixcaldates
npm run install-mm

copy your config.js and custom.css from the prior folder
and the non-default modules you have installed…

this ONLY changes the default calendar
but DOES ship an updated node-ical library too

if you need to fall back, just rename the folders around again so that
your original is called MagicMirror

all the testcases for node-ical and MagicMirror execute successfully.

the ‘BIG’ change here is to get the local NON-TZ dates for the
rrule.between()

all the checking and conversion code is commented out or not used
the node-ical fixes are for excluded dates (exdate) values being adjusted for DST/STD time… waiting to submit that PR

one fix in calendar.js for checking if a past date was too far back,
but it never checked to see IF the event date was in the past… (before today) so it chopped off too many

and one change in calendarfetcher.js to put out a better diagnostic message of the parsed data… (exdate was excluded cause JSON stringify couldn’t convert the complex structure)

MarcLandis

@sdetweil I testet your branch and so far it looks good with my test calendar and also with my real ones.

sdetweil

@MarcLandis thanks. i still have some reported issues. so use it and let me know. will advise when i make nect updates

we wouldn’t release til jan anyhow, so we have time

sdetweil

@natmash please see my latest test update this entry is now added to the testcases run

(I had NOT fixed it before today)

sdetweil

@MarcLandis can you retest at your convenience

git pull and npm run install-mm

natmash

@sdetweil I pulled down and started it up. Indeed the entries show up on the correct days, but now the entries that were right time, wrong day, are right day, wrong time (offset).

sdetweil

@natmash did you do that pull before today? cause it was broken yesterday
not now…

and requires the updated node-ical ., so npm install too…

natmash

@sdetweil I pulled yesterday and again this morning, and I ran npm install as well.

Latest commit I have is 95db75ab17b1a258bb8969a31197acc4fcb37d73.

sdetweil

@natmash able ro recreate

natmash

@sdetweil For now I have done

if (hasByWeekdayRule && false)

(in order to change as little as possible) and my use cases work for now.

sdetweil

@natmash cool…

sdetweil

@MarcLandis @natmash

here is an updated test version of the fixes for all kinds of calendar date problems.

NOTE: the changed branch name
NOTE: this used the node-cal@0.19.0 library UNCHANGED

best to make a new folder and git clone there

git clone https://github.com/sdetweil/MagicMirror
cd MagicMirror
git checkout fixcaldates2 // <------ note this is a changed branch name
npm run install-mm
copy your config.js and custom.css from the prior folder
and the non-default modules you have installed…

this ONLY changes the default calendar
but DOES ship an updated node-ical library too

if you need to fall back, just rename the folders around again so that
your original is called MagicMirror

all the testcases for node-ical and MagicMirror execute successfully.

the ‘BIG’ change here is to get the local NON-TZ dates for the
rrule.between()

all the checking and conversion code is commented out or not used
the node-ical fixes are for excluded dates (exdate) values being adjusted for DST/STD time… waiting to submit that PR

one fix in calendar.js for checking if a past date was too far back,
but it never checked to see IF the event date was in the past… (before today) so it chopped off too many

and one change in calendarfetcher.js to put out a better diagnostic message of the parsed data… (exdate was excluded cause JSON stringify couldn’t convert the complex structure)

I added the tests you all have documented

please re-pull and checkout the new branch (I deleted the old branch)
and npm run install-mm again

natmash

@sdetweil That looks correct to me now!

sdetweil

@natmash awesome, thanks for the feedback…

have one moved recurring event problem yet…