MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Calendar shows late day events on next day but at correct time

    Scheduled Pinned Locked Moved Unsolved Troubleshooting
    35 Posts 4 Posters 7.1k Views 6 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • N Offline
      natmash @sdetweil
      last edited by

      @sdetweil I pulled down and started it up. Indeed the entries show up on the correct days, but now the entries that were right time, wrong day, are right day, wrong time (offset).

      S 1 Reply Last reply Reply Quote 0
      • S Offline
        sdetweil @natmash
        last edited by sdetweil

        @natmash did you do that pull before today? cause it was broken yesterday
        not now…

        and requires the updated node-ical ., so npm install too…

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        N 1 Reply Last reply Reply Quote 0
        • N Offline
          natmash @sdetweil
          last edited by

          @sdetweil I pulled yesterday and again this morning, and I ran npm install as well.

          Latest commit I have is 95db75ab17b1a258bb8969a31197acc4fcb37d73.

          S 1 Reply Last reply Reply Quote 0
          • S Offline
            sdetweil @natmash
            last edited by

            @natmash able ro recreate

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            N 1 Reply Last reply Reply Quote 0
            • N Offline
              natmash @sdetweil
              last edited by

              @sdetweil For now I have done

              if (hasByWeekdayRule && false)
              

              (in order to change as little as possible) and my use cases work for now.

              S 1 Reply Last reply Reply Quote 0
              • S Offline
                sdetweil @natmash
                last edited by

                @natmash cool…

                Sam

                How to add modules

                learning how to use browser developers window for css changes

                1 Reply Last reply Reply Quote 0
                • S Offline
                  sdetweil
                  last edited by

                  @MarcLandis @natmash

                  here is an updated test version of the fixes for all kinds of calendar date problems.

                  NOTE: the changed branch name
                  NOTE: this used the node-cal@0.19.0 library UNCHANGED

                  best to make a new folder and git clone there

                  git clone https://github.com/sdetweil/MagicMirror
                  cd MagicMirror
                  git checkout fixcaldates2 // <------ note this is a changed branch name
                  npm run install-mm
                  copy your config.js and custom.css from the prior folder
                  and the non-default modules you have installed…

                  this ONLY changes the default calendar
                  but DOES ship an updated node-ical library too

                  if you need to fall back, just rename the folders around again so that
                  your original is called MagicMirror

                  all the testcases for node-ical and MagicMirror execute successfully.

                  the ‘BIG’ change here is to get the local NON-TZ dates for the
                  rrule.between()

                  all the checking and conversion code is commented out or not used
                  the node-ical fixes are for excluded dates (exdate) values being adjusted for DST/STD time… waiting to submit that PR

                  one fix in calendar.js for checking if a past date was too far back,
                  but it never checked to see IF the event date was in the past… (before today) so it chopped off too many

                  and one change in calendarfetcher.js to put out a better diagnostic message of the parsed data… (exdate was excluded cause JSON stringify couldn’t convert the complex structure)

                  I added the tests you all have documented

                  please re-pull and checkout the new branch (I deleted the old branch)
                  and npm run install-mm again

                  Sam

                  How to add modules

                  learning how to use browser developers window for css changes

                  1 Reply Last reply Reply Quote 0
                  • N Offline
                    natmash
                    last edited by

                    @sdetweil That looks correct to me now!

                    S 1 Reply Last reply Reply Quote 0
                    • S Offline
                      sdetweil @natmash
                      last edited by

                      @natmash awesome, thanks for the feedback…

                      have one moved recurring event problem yet…

                      Sam

                      How to add modules

                      learning how to use browser developers window for css changes

                      S 1 Reply Last reply Reply Quote 0
                      • S Offline
                        sdetweil @sdetweil
                        last edited by sdetweil

                        @natmash posted another update, moved event at end of day

                        really need to add another, moved to diff time, and duration(done)

                        also added testcases for moved( before and after original) AND deleted recurrences

                        Sam

                        How to add modules

                        learning how to use browser developers window for css changes

                        N 1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 3
                        • 4
                        • 3 / 4
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy