birthdaylist - discontinued ?

sdetweil

@rkorell will have to review again . later

rkorell

@sdetweil Thanks.
Take your time.
This is definitely not urgent!

Ralf

sdetweil

@rkorell I just pushed some fixes for the update cycle

give it a try…
git pull
to update

rkorell

@sdetweil , Cool!
Thanks a lot.

pi@smarthome:~/MagicMirror/modules/birthdaylist $ git pull
hint: Pulling without specifying how to reconcile divergent branches is
hint: discouraged. You can squelch this message by running one of the following
hint: commands sometime before your next pull:
hint:
hint:   git config pull.rebase false  # merge (the default strategy)
hint:   git config pull.rebase true   # rebase
hint:   git config pull.ff only       # fast-forward only
hint:
hint: You can replace "git config" with "git config --global" to set a default
hint: preference for all repositories. You can also pass --rebase, --no-rebase,
hint: or --ff-only on the command line to override the configured default per
hint: invocation.
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (1/1), done.
remote: Total 3 (delta 2), reused 3 (delta 2), pack-reused 0 (from 0)
Unpacking objects: 100% (3/3), 584 bytes | 97.00 KiB/s, done.
From https://github.com/sdetweil/birthdaylist
   0c16aeb..e4013e9  master     -> origin/master
Updating 0c16aeb..e4013e9
Fast-forward
 birthdaylist.js | 31 +++++++++++++++++++------------
 1 file changed, 19 insertions(+), 12 deletions(-)

Can I now remove the debug-attributes?
Warmest regards,
Ralf

sdetweil

@rkorell yes, or you can leave them on for a little while

rkorell

@sdetweil OK; will do.
Thanks.
Ralf

sdetweil

@rkorell see any remaining issues?

if not, you can turn off both debug settings for next time you start MagicMirror

rkorell

@sdetweil :-)
Just yesterday I made some other minor changes and with this I‘ve deactivated the debug parameters for your module.
Will keep this in my eyes and report back, if problem re-appears or not.
Thanks so far !
Ralf

sdetweil

@rkorell awesome, thanks for the feedback

rkorell

Dear Sam, @sdetweil ,

Just for your information - no action necessary:

Unfortunately problem re-appears if I take the debug and debugging option out.

But: No worries - with these options enabled, birthdaylist doesn’t disappear, so for me it “works” …

Thanks for your great work!
Ralf