Read the statement by Michael Teeuw here.
resume()
-
This post is deleted! -
@johnnyboy No you haven’t offended me. Not jumping on anyone… I’m just a very direct person and I tend to say what I mean.
So don’t be offended I’m just simply asking you or anyone else what do you suggest gets done?
-
This post is deleted! -
@johnnyboy I would rather have suggestions to fix it rather then agree… that should have taken up on the https://github.com/MichMich/MagicMirror site…
-
This post is deleted! -
@johnnyboy Good, if it helps I’m all for it :)
-
This post is deleted! -
No intention to complain here, so no reason to argue about that.
IMO, the two most obvious solutions are
- changing the behaviour, i.e. implement a check whether the module was visible before the call
- changing the description in the documentation so that it matches the behaviour
The question is, how do you solve something like this here? Who decides which solution should be preferred and how do I trigger a fix (I dont want to dive into the main core code myself). Do you usually open an issue on github in such cases? Also, the author of this peace of code may have relevant information, but (as usual in open-source projects) its nearly impossible to find out who to contact…
-
@Anhalter42 Yes, open an issue on github or if you already have made changes to either the documentation or written code that does your first suggestion then you would suggest a Pull Request to implement the changes you’ve made
