• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

resume()

Scheduled Pinned Locked Moved Development
12 Posts 4 Posters 5.0k Views 3 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • J Offline
    johnnyboy @cowboysdude
    last edited by Apr 26, 2017, 10:18 PM

    This post is deleted!
    C 1 Reply Last reply Apr 26, 2017, 10:20 PM Reply Quote 0
    • C Offline
      cowboysdude Module Developer @johnnyboy
      last edited by Apr 26, 2017, 10:20 PM

      @johnnyboy I would rather have suggestions to fix it rather then agree… that should have taken up on the https://github.com/MichMich/MagicMirror site…

      J 1 Reply Last reply Apr 26, 2017, 10:28 PM Reply Quote 1
      • J Offline
        johnnyboy @cowboysdude
        last edited by Apr 26, 2017, 10:28 PM

        This post is deleted!
        C 1 Reply Last reply Apr 26, 2017, 10:29 PM Reply Quote 0
        • C Offline
          cowboysdude Module Developer @johnnyboy
          last edited by Apr 26, 2017, 10:29 PM

          @johnnyboy Good, if it helps I’m all for it :)

          J 1 Reply Last reply Apr 26, 2017, 10:32 PM Reply Quote 2
          • J Offline
            johnnyboy @cowboysdude
            last edited by Apr 26, 2017, 10:32 PM

            This post is deleted!
            1 Reply Last reply Reply Quote 1
            • A Offline
              Anhalter42
              last edited by Apr 27, 2017, 1:43 PM

              No intention to complain here, so no reason to argue about that.

              IMO, the two most obvious solutions are

              1. changing the behaviour, i.e. implement a check whether the module was visible before the call
              2. changing the description in the documentation so that it matches the behaviour

              The question is, how do you solve something like this here? Who decides which solution should be preferred and how do I trigger a fix (I dont want to dive into the main core code myself). Do you usually open an issue on github in such cases? Also, the author of this peace of code may have relevant information, but (as usual in open-source projects) its nearly impossible to find out who to contact…

              B 1 Reply Last reply Apr 27, 2017, 2:01 PM Reply Quote 0
              • B Offline
                broberg Project Sponsor @Anhalter42
                last edited by Apr 27, 2017, 2:01 PM

                @Anhalter42 Yes, open an issue on github or if you already have made changes to either the documentation or written code that does your first suggestion then you would suggest a Pull Request to implement the changes you’ve made

                1 Reply Last reply Reply Quote 0
                • 1
                • 2
                • 1 / 2
                1 / 2
                • First post
                  10/12
                  Last post
                Enjoying MagicMirror? Please consider a donation!
                MagicMirror created by Michael Teeuw.
                Forum managed by Sam, technical setup by Karsten.
                This forum is using NodeBB as its core | Contributors
                Contact | Privacy Policy