• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

Calendar module fetchInterval

Scheduled Pinned Locked Moved Development
12 Posts 4 Posters 7.3k Views 4 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • S Offline
    strawberry 3.141 Project Sponsor Module Developer @bhepler
    last edited by May 3, 2017, 5:26 PM

    @bhepler I’m the same oppinion as you are, probably didn’t explain it well. I can’t see a point why you would care to fetch less frequent than a day.

    Please create a github issue if you need help, so I can keep track

    B 1 Reply Last reply May 3, 2017, 8:59 PM Reply Quote 1
    • B Offline
      bhepler Module Developer @strawberry 3.141
      last edited by May 3, 2017, 8:59 PM

      @strawberry-3.141 Aha! Yeah, I misunderstood. “less than a day” = “less frequently than at least once per day”, as opposed to my interpretation. My interpretation was “a frequency interval of less than one day”.

      Interesting question: Does the calculation that writes out the “xx days” string only occur on the fetch? For example, if I have an event in four days and I don’t perform a fetch for a week, will it correctly change the text to read “day after tomorrow” at the appropriate time?

      If I were only showing holidays on my calendar then such a thing might make sense. How often do holidays change, right?

      1 Reply Last reply Reply Quote 0
      • C Offline
        cohron @Anhalter42
        last edited by May 4, 2017, 1:42 PM

        @Anhalter42 Definately, and excellent point about not changing the existing option name. I’m hoping to implement a (swimming) pool module in the next couple of months. I haven’t coded (VB) in over a decade so i am reading up about Github (great concept btw). Not sure if i need to branch or pull request or what just yet. I think i can handle learning JS and use the existing modules to reference. This will be a great exercise for me before i jump into full coding.

        A 1 Reply Last reply May 4, 2017, 1:51 PM Reply Quote 0
        • A Offline
          Anhalter42 @cohron
          last edited by May 4, 2017, 1:51 PM

          @cohron Just in case this helps you:
          If you want to change something / contribute to an existing project you have to fork it, change what you want to change and create a Pull-Request (which then gets reviewed and accepted/rejected).
          For developing your own module you just need to create a new project, i think. In case you didn’t see it, there is a handy template module you could use as base.

          C 1 Reply Last reply May 6, 2017, 1:37 PM Reply Quote 0
          • C Offline
            cohron @Anhalter42
            last edited by May 6, 2017, 1:37 PM

            @Anhalter42 I spend some time going through the calendar module code, i can read it fairly well, for the syntax i dont understand there is always google. After review, I see why there are no separate fetchInterval’s for each calendar. Each calendar’s events are added to an array, then sorted together also the dom (html table) is created from scratch on each interval. Without a tremendous restructuring of code, setting up separate interval timers, persisting the ical events array, etc. the value to adding this is limited.

            Your comments help me immensely, thank you. I reviewed the template module, i’l start playing with that and do a Hello World module exercise when i return home at the end of the month.

            1 Reply Last reply Reply Quote 1
            • 1
            • 2
            • 2 / 2
            2 / 2
            • First post
              12/12
              Last post
            Enjoying MagicMirror? Please consider a donation!
            MagicMirror created by Michael Teeuw.
            Forum managed by Sam, technical setup by Karsten.
            This forum is using NodeBB as its core | Contributors
            Contact | Privacy Policy