• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

MMM-cryptocurrency - v1.4

Scheduled Pinned Locked Moved Utilities
77 Posts 21 Posters 84.3k Views 25 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • K Offline
    Klizzy Module Developer
    last edited by May 11, 2017, 1:00 AM

    hello @matteodanelli , thank you for you work!
    I submitted a pull request to your Repo and it now has multi currency support, translations, styling and Formatting.
    Tomorrow i wanted to add some more comments to explain more parts of the code.
    You can add it to you code if you want to. I just wanted to finish my MagicMirror and have an overview on multiple currencies. Thats the reason why i could no longer wait 😅

    Here you can see it https://github.com/matteodanelli/MMM-cryptocurrency/pull/1

    Here is the forked repo with the charges if you want to test it:
    https://github.com/Klizzy/MMM-cryptocurrency

    Social
    Twitter
    Github

    Working on the following Modules:

    • MMM-Vrr
    • MMM-cryptocurrency
    1 Reply Last reply Reply Quote 1
    • M Offline
      matteodanelli
      last edited by May 15, 2017, 7:25 PM

      Project updated with multiple currencies support and percentage change in the last 24 hours.
      Thank you @Klizzy for you contribution!

      1 Reply Last reply Reply Quote 1
      • S Offline
        SpecialRob
        last edited by May 21, 2017, 4:11 PM

        Hello

        I just git cloned the newest version and updated the config file as per your instructions. (21MAY17) It is working perfectly and pulling the current data.

        I was snooping through the various js files and don’t see how to add the header line above the currency listing

        CRYPTO CURRENCY (Dim text with a line below it)

        Is this a config option somewhere?


        K 1 Reply Last reply May 21, 2017, 5:05 PM Reply Quote 0
        • K Offline
          Klizzy Module Developer @SpecialRob
          last edited by May 21, 2017, 5:05 PM

          @SpecialRob
          do you mean a dividing line between the table header and data, or do you don’t have any data in the Table header (Currency, Price, 24h Change) ?

          a dividing line is not implemented at the moment. But today i finished another feature for this module, so i can add the dividing line. If @matteodanelli accepts my pull request you can update it in a couple of days.

          If you don’t have any data in the table header, i need to know in which language settings you’re running the mirror.

          Social
          Twitter
          Github

          Working on the following Modules:

          • MMM-Vrr
          • MMM-cryptocurrency
          S 1 Reply Last reply May 21, 2017, 5:53 PM Reply Quote 0
          • S Offline
            SpecialRob @Klizzy
            last edited by May 21, 2017, 5:53 PM

            @Klizzy

            Thanks for the reply

            No, I do not have any table header data at all (english), nor a dividing line like the graphic shown for the module.

            It just jumps to a table listing the currency and price.

            Now that I am adding more and more stuff to my screen, it would be nice to have separators to keep it uncluttered. Not a huge deal, just my OCD flaring up ;)

            M 1 Reply Last reply May 21, 2017, 6:44 PM Reply Quote 0
            • M Offline
              matteodanelli @SpecialRob
              last edited by May 21, 2017, 6:44 PM

              Hi @SpecialRob,
              I think I didn’t get the point.
              In my module, there is not a line separator between header and data.
              Also, language of the module is set to english and you don’t see header values? So strange :)

              Can you please post a screenshot of what you see?
              Looking forward to help you.

              1 Reply Last reply Reply Quote 0
              • M Offline
                matteodanelli
                last edited by May 21, 2017, 7:57 PM

                Hello guys,
                I’ve updated project making optional the possibility to show currency changes in time.
                Also, you can select which interval to see between one of the following: 1 hour, 1 day or 1 week. None of them is required.

                Leave me feedback ;)

                K 1 Reply Last reply May 21, 2017, 8:15 PM Reply Quote 0
                • S Offline
                  SpecialRob
                  last edited by May 21, 2017, 7:59 PM

                  I moved the module back to the right side under the weather and the header data now shows up. Weird.

                  This is truly amazing work! thanks

                  M 1 Reply Last reply May 21, 2017, 8:00 PM Reply Quote 0
                  • M Offline
                    matteodanelli @SpecialRob
                    last edited by May 21, 2017, 8:00 PM

                    @SpecialRob Yes weird. But thank you for reporting it.
                    I’ll investigate.

                    1 Reply Last reply Reply Quote 0
                    • K Offline
                      Klizzy Module Developer @matteodanelli
                      last edited by May 21, 2017, 8:15 PM

                      @matteodanelli nice work!
                      just in time for my recent changes ☺️
                      (you get the pull request in a couple of minutes).

                      I created a second display option with less information overall, but with icons.
                      I had to do this, because i have many modules on the Mirror and therefor the readability overall decreased with so many informations.

                      But now we can simply choose between more details or the “compact” version.
                      Here is a little Sneakpeak, until i finish the changes of the Readme accordingly to my changes: 0_1495397731334_logoView.png

                      Social
                      Twitter
                      Github

                      Working on the following Modules:

                      • MMM-Vrr
                      • MMM-cryptocurrency
                      1 Reply Last reply Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 4
                      • 5
                      • 6
                      • 7
                      • 8
                      • 1 / 8
                      1 / 8
                      • First post
                        10/77
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy