MMM-cryptocurrency - v1.4

[Klizzy]

@SpecialRob
do you mean a dividing line between the table header and data, or do you don’t have any data in the Table header (Currency, Price, 24h Change) ?

a dividing line is not implemented at the moment. But today i finished another feature for this module, so i can add the dividing line. If @matteodanelli accepts my pull request you can update it in a couple of days.

If you don’t have any data in the table header, i need to know in which language settings you’re running the mirror.

[SpecialRob]

@Klizzy

Thanks for the reply

No, I do not have any table header data at all (english), nor a dividing line like the graphic shown for the module.

It just jumps to a table listing the currency and price.

Now that I am adding more and more stuff to my screen, it would be nice to have separators to keep it uncluttered. Not a huge deal, just my OCD flaring up ;)

[matteodanelli]

Hi @SpecialRob,
I think I didn’t get the point.
In my module, there is not a line separator between header and data.
Also, language of the module is set to english and you don’t see header values? So strange :)

Can you please post a screenshot of what you see?
Looking forward to help you.

[matteodanelli]

Hello guys,
I’ve updated project making optional the possibility to show currency changes in time.
Also, you can select which interval to see between one of the following: 1 hour, 1 day or 1 week. None of them is required.

Leave me feedback ;)

[SpecialRob]

I moved the module back to the right side under the weather and the header data now shows up. Weird.

This is truly amazing work! thanks

[matteodanelli]

@SpecialRob Yes weird. But thank you for reporting it.
I’ll investigate.

[Klizzy]

@matteodanelli nice work!
just in time for my recent changes ☺️
(you get the pull request in a couple of minutes).

I created a second display option with less information overall, but with icons.
I had to do this, because i have many modules on the Mirror and therefor the readability overall decreased with so many informations.

But now we can simply choose between more details or the “compact” version.
Here is a little Sneakpeak, until i finish the changes of the Readme accordingly to my changes:

[fox]

Very nice !
Thank you for doing this.

[olexs]

Hey,

thanks for this module! Exactly what I wanted for my mirror.

I took the liberty of implementing two new features, pull requests are up on Github:

1. Show weekly price graphs from coinmarketcap: https://github.com/matteodanelli/MMM-cryptocurrency/pull/6
   

2. Round the prices to a total number of significant digits, to keep a higher resolution on low-value prices: https://github.com/matteodanelli/MMM-cryptocurrency/pull/7
   
   The property is set to 5 in the example. Note how BTC and ETH are both still showing two decimals, but XRP is showing 4, for a total of 5 or more digits.

Any comments are welcome! I tried to keep your coding conventions intact, though it wasn’t much code that I added :)

[matteodanelli]

@olexs Amazing work!
Thanks for pull requests! Already merged :)
Thank you so much!