MMM-cryptocurrency - v1.4

matteodanelli

@hazmartin Hi, I am working on it and I look forward to have it implemented very soon.
I’ll ping you when ready.

Klizzy

hello @matteodanelli , thank you for you work!
I submitted a pull request to your Repo and it now has multi currency support, translations, styling and Formatting.
Tomorrow i wanted to add some more comments to explain more parts of the code.
You can add it to you code if you want to. I just wanted to finish my MagicMirror and have an overview on multiple currencies. Thats the reason why i could no longer wait 😅

Here you can see it https://github.com/matteodanelli/MMM-cryptocurrency/pull/1

Here is the forked repo with the charges if you want to test it:
https://github.com/Klizzy/MMM-cryptocurrency

matteodanelli

Project updated with multiple currencies support and percentage change in the last 24 hours.
Thank you @Klizzy for you contribution!

SpecialRob

Hello

I just git cloned the newest version and updated the config file as per your instructions. (21MAY17) It is working perfectly and pulling the current data.

I was snooping through the various js files and don’t see how to add the header line above the currency listing

CRYPTO CURRENCY (Dim text with a line below it)

Is this a config option somewhere?

Klizzy

@SpecialRob
do you mean a dividing line between the table header and data, or do you don’t have any data in the Table header (Currency, Price, 24h Change) ?

a dividing line is not implemented at the moment. But today i finished another feature for this module, so i can add the dividing line. If @matteodanelli accepts my pull request you can update it in a couple of days.

If you don’t have any data in the table header, i need to know in which language settings you’re running the mirror.

SpecialRob

@Klizzy

Thanks for the reply

No, I do not have any table header data at all (english), nor a dividing line like the graphic shown for the module.

It just jumps to a table listing the currency and price.

Now that I am adding more and more stuff to my screen, it would be nice to have separators to keep it uncluttered. Not a huge deal, just my OCD flaring up ;)

matteodanelli

Hi @SpecialRob,
I think I didn’t get the point.
In my module, there is not a line separator between header and data.
Also, language of the module is set to english and you don’t see header values? So strange :)

Can you please post a screenshot of what you see?
Looking forward to help you.

matteodanelli

Hello guys,
I’ve updated project making optional the possibility to show currency changes in time.
Also, you can select which interval to see between one of the following: 1 hour, 1 day or 1 week. None of them is required.

Leave me feedback ;)

SpecialRob

I moved the module back to the right side under the weather and the header data now shows up. Weird.

This is truly amazing work! thanks

matteodanelli

@SpecialRob Yes weird. But thank you for reporting it.
I’ll investigate.

Klizzy

@matteodanelli nice work!
just in time for my recent changes ☺️
(you get the pull request in a couple of minutes).

I created a second display option with less information overall, but with icons.
I had to do this, because i have many modules on the Mirror and therefor the readability overall decreased with so many informations.

But now we can simply choose between more details or the “compact” version.
Here is a little Sneakpeak, until i finish the changes of the Readme accordingly to my changes:

fox

Very nice !
Thank you for doing this.

olexs

Hey,

thanks for this module! Exactly what I wanted for my mirror.

I took the liberty of implementing two new features, pull requests are up on Github:

Show weekly price graphs from coinmarketcap: https://github.com/matteodanelli/MMM-cryptocurrency/pull/6
Round the prices to a total number of significant digits, to keep a higher resolution on low-value prices: https://github.com/matteodanelli/MMM-cryptocurrency/pull/7

The property is set to 5 in the example. Note how BTC and ETH are both still showing two decimals, but XRP is showing 4, for a total of 5 or more digits.

Any comments are welcome! I tried to keep your coding conventions intact, though it wasn’t much code that I added :)

matteodanelli

@olexs Amazing work!
Thanks for pull requests! Already merged :)
Thank you so much!

fox

i love the module. thank you !

But i dont get logo working. it stays always at “detail” and i also enabled graph, but they are not shown.
any existing bug? thx

olexs

@fox Can you post your module configuration from config.js? And have you pulled the latest code (master branch from https://github.com/matteodanelli/MMM-cryptocurrency)?

Klizzy

@fox please get the latest release of this Module from Github and replace the folder on your Mirror with the new one. Because you have to Update it manually if you want the graph or newer features.
If you use git, you can just do “git pull origin master” in the console.

@olexs thank you for your awesome work!

I tried for some time to implement the graph but i couldn’t find a solution…

@matteodanelli
I added some features and submitted an pull request.

Colored logos (optional)
additional logo support for Nem and Stratis
Graph Support for Stratis
now gets the top25 results of coinmareket

It would be nice if the currencies are sorted by total market volume (like on coin market). At the moment its ordered by the definitions in the config section.
Maybe someone has more time as i in the next days? ☺️

And what do you guys think if we start to add release notes / change log to the readme?

s199

Hello
thank you for this addon :) it works fine and looks nice.
Is it possible to add an option to set a certain amount for each coin ? Some coin are really low in value like Dogecoin and the price for ONE single coin is always on 0. (ex 1000 dogecoin so at least its worth something :)
Also is it possible to use BTC as main currency, so everything is converted in BTC insted of USD or EUR ?
thanks a lot
++

edit : now that i think about it, ideally there should be the price BTC > USD (or EURO etc) and then all the other crypto u want converted in BTC. that would make more sens as BTC is the only way to trade these alts coin. two different coin convertion then :)

matteodanelli

@s199 At the moment, service which provides data is not able to convert in BTC, but only to a specified set of currencies, none virtual.
For the Dogecoin request. It could make sense but it requires a bit of configuration and so I need some time to develop it. But I’ll do.

For what I know, you can trade every crypto currency in EUR or USD or any other, not only BTC.

rmeskill

For anyone who’s having issues getting a graph to work for lesser-known/non-included, it relies on a proprietary ID value for a currency within coinmarketcap.com. In order to this to work you’ll need to find that value and define it within the MMM-cryptocurrency.js file.

Maybe there’s an easier way, but I got it working by going to coinmarketcap.com, finding the currency I wanted, then right clicking on the small inline graph and clicking ‘open IMAGE in a new tab’. That’ll come up with an url like this one for Dash: https://files.coinmarketcap.com/generated/sparklines/131.png.

Now, within the MMM-cryptocurrency.js file you’ll need to create a reference to this ID:

sparklineIds: {
                        bitcoin: 1,
...
                        dash: 131,
...
                        }

Reboot your mirror and all should work