MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Weatherunderground - currently - hourly - daily - configurable

    Scheduled Pinned Locked Moved Troubleshooting
    126 Posts 26 Posters 208.5k Views 13 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • yo-lessY Offline
      yo-less Module Developer
      last edited by

      My bad, code should have been:

      	var hourlyTime = new Date();
      	hourlyTime.setHours(hourlyforecast.FCTTIME.hour,00,00);
      	
      	if (hourlyTime > sunset || hourlyTime < sunrise) {
      					
      	this.hourlyforecast.push({
      
      		hour:    this.thour,
      		maxTemp: this.tmaxTemp,
      		minTemp: this.tminTemp,
      		icon:    this.config.iconTableNight[hourlyforecast.icon],
      		pop:	 hourlyforecast.pop,
      		mm:	 this.tmm
      	});
      	
      	} else {
      					
      	this.hourlyforecast.push({
      
      		hour:    this.thour,
      		maxTemp: this.tmaxTemp,
      		minTemp: this.tminTemp,
      		icon:    this.config.iconTableDay[hourlyforecast.icon],
      		pop:	 hourlyforecast.pop,
      		mm:	 this.tmm
      	}); 
      	}
      }
      }
      
      1 Reply Last reply Reply Quote 0
      • RedNaxR Offline
        RedNax Module Developer
        last edited by

        Hi,

        Thanks for debugging :D Added (a version) of this in the develop branch!

        yo-lessY 1 Reply Last reply Reply Quote 0
        • yo-lessY Offline
          yo-less Module Developer @RedNax
          last edited by

          @RedNax Glad to hear I could add some thoughts to the project, love your module!

          1 Reply Last reply Reply Quote 0
          • yo-lessY Offline
            yo-less Module Developer
            last edited by

            Quick question. Today I updated my mirror to version 2.0.4 via git pull. Afterwards the umbrella weather icon didn’t work any more as @MichMich has updated the weather font. Is this expected behavior or am I simply not getting another step I should take after updating? I have now manually copied the old files into the vendor/weather-icons folder and now it’s working again, but I suspect this is not what I should be doing ^^.

            1 Reply Last reply Reply Quote 0
            • RedNaxR Offline
              RedNax Module Developer
              last edited by

              Actually the weatherfont update in 2.0.4 is actually my doing… Should nstill work as expected when you’ve pulled the latest Wunderground module… You could also switch to the one in the development branch which takes advantage of having the weathericons now being part of the main framework.

              yo-lessY 1 Reply Last reply Reply Quote 0
              • yo-lessY Offline
                yo-less Module Developer @RedNax
                last edited by

                @RedNax Alright, thanks for the information. I have meddled so much with your code that a fresh pull would reverse all my customizations. But I’ll have a look at the development branch to get the weather module to pull the icons from its own folder.

                Could you explain to me why the new weather fonts include fewer icon definitions?

                RedNaxR 1 Reply Last reply Reply Quote 0
                • RedNaxR Offline
                  RedNax Module Developer @yo-less
                  last edited by

                  @yo-less Do they? They’re taken straight from http://weathericons.io/ which isn’t under my control. What’s missing?

                  1 Reply Last reply Reply Quote 0
                  • yo-lessY Offline
                    yo-less Module Developer
                    last edited by

                    @RedNax No, it seems they don’t, sorry. I just rechecked and the wi-umbrella definition is there. Strangely, though, when I performed a “git pull” in the MM main folder, my umbrellas in the Weather Underground module disappeared and I had to manually overwrite the css file in the vendor folder with the older version. I must have made some other changes to the folder prior to that, because in the github repository everything seems to be fine.

                    RedNaxR 1 Reply Last reply Reply Quote 0
                    • RedNaxR Offline
                      RedNax Module Developer @yo-less
                      last edited by

                      @yo-less Did you also pull the MM 2.0.4 main framework? That’s where the icons went… Then again, when you did heavy modding… ;) Care to share screenshots of your version?

                      yo-lessY 1 Reply Last reply Reply Quote 0
                      • yo-lessY Offline
                        yo-less Module Developer @RedNax
                        last edited by yo-less

                        @RedNax I went to my home/pi/MagicMirror folder and typed in “git pull”, which is when it updated. If there is an additional step to update the main framework, please let me know.

                        Sure, the adjustments I have made so far are mostly based around the idea that information should only be presented if it is relevant (or actually existent at all)

                        • Only show precipitation if the probability for rain and the expected precipitation is above 0 % / mm
                        • Only show the umbrella icon if there is a day with precipitation in the forecast table
                        • Only show windspeed if it is above 0 kph.
                        • I’ve removed the windspeed icon and changed it to a text line like this: 12 km/h + wind direction icon
                        • In the forecast table the forecast temperature for any given day is shown until sunrise of that day (As I have the hourly forecasts I don’t really need the forecast for the day after sunrise, so generally I have my forecast table start the day after today - In the time between midnight and sunrise, this isn’t all that great though as it means that I only see the forecast until, say 10am, shortly after midnight)
                        • I’ve added some spaces to unclutter the layout
                        • I’ve changed the short version of the days to all caps

                        Here’s a screenshot of my layout:

                        0_1471294763580_MM-Wunderground.png

                        What I’m planning to add:

                        • 7am temperature in the forecast table

                        Here’s why: Where I live it can sometimes get pretty cold in the morning, but within hours it’s humid and hot and sometimes it gets cold later in the evening so a simple quote of the daily high and low doesn’t really represent the days all that well. And if you know that it’s mild in the morning and hot in the afternoon you can dress differently than when it’s cold in the morning and then hot for the rest of the day. Not sure if that is all too helpful for others out there ^^.

                        C 1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 7
                        • 8
                        • 9
                        • 10
                        • 11
                        • 12
                        • 13
                        • 9 / 13
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy