• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

Reverse Lookup MMM-FRITZ-Box-Callmonitor - help needed

Scheduled Pinned Locked Moved Development
16 Posts 4 Posters 6.3k Views 3 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • P Offline
    pinsdorf Module Developer
    last edited by Feb 27, 2018, 10:21 AM

    Hi @AxLed, great to see your progress!

    There are a few remarks on testing that come to mind:

    • I personally like to develop the module on my Windows PC using VisualStudio Code and additional tooling from the Internet as I need it. For this you have to install the MagicMirror on your PC. @Mykle1 has a nice walkthrough document for doing so.
    • MM has a development mode. Start MM (with your to be tested module) with the command npm start dev. This starts a browser UI for MM and in addition shows you the loaded HTML, CSS, source code, etc. In the browser’s source window you can set breakpoints and once they get hit, the program execution pauses and you have time to inspect variables. Please note that you don’t have to stop and start MM all the time with the command above. Just change source code in your programming editor, save it, and reload the MM browser (F5). This works both on Raspberry Pi and Windows PC.
    • If you want to test part of your code in isolation, then you can simply write a small helper program debug.js which calls your test subject’s methods the way you need it. You find this approach in the debug.js of calendar module to test the calendar fetcher component. In this case you do not start MM, but just execute your helper program with node debug.js.
    • You can write a real (automated) test suite, but this may go a little beyond your current task. A test suite is helpful when you do test driven development and/or when you want to guarantee that a future change does not break expected behaviour.
    1 Reply Last reply Reply Quote 0
    • P Offline
      pinsdorf Module Developer
      last edited by Feb 27, 2018, 10:35 AM

      Oh, one idea for your module. The calendar has a dedicated calendar fetcher as mentioned in my previous post. This may be interesting for your reverse lookup as well. Other people may want to use other online phone books, e.g. for different countries, and by configuring the right reverse lookup fetcher they could do so. Maybe have a look at the code of the calendar fetcher and the node helper where it is being called. However, IMHO you should first get your module working as it is. This is a suggestion for a future extension.

      1 Reply Last reply Reply Quote 0
      • A Offline
        AxLed Module Developer
        last edited by Feb 27, 2018, 5:22 PM

        @pirnsdorf

        Thanks for the information, so i started one of my MM-Dev-Environments (Ubuntu 16.04) and run MM with npm start dev, unfortunatelly i can not mark node_helper.js, as i only see the MODULNAME.js and the MODULNAME.css.

        The part of code i want to debug is in node_helper.js, how can i do this?
        Screenshot:
        0_1519752147187_dev1.JPG

        AxLED

        1 Reply Last reply Reply Quote 0
        • P Offline
          pinsdorf Module Developer
          last edited by Feb 28, 2018, 10:32 AM

          Hmm, this is weird. The original MMM-FRITZ-Box-Callmonitor comes with a node_helper.js. Are you sure you did not delete it by accident resp. forgot to copy it to your dev environment? Moreover package.json and the README.md are missing.

          Are you familiar with git? I’d advice that you fork the MMM-FRITZ-Box-Callmonitor into your own GitHub account and make all your changes there. This would also allow me to read your latest code after each git commit. From this forked repository there is an easy way to get your improvement back into the original repository once you are done.

          1 Reply Last reply Reply Quote 0
          • A Offline
            AxLed Module Developer
            last edited by Mar 1, 2018, 12:24 PM

            Hi pinsdorf,
            all mentioned files are in the folder MMM-FRITZ-Box-Callmonitor but on debugging, i only can choose from the ones above (see my screenshot).

            I will follow your suggestion with git, if my code adaptation has passed the beta phase, as i still have some problems.

            1 Reply Last reply Reply Quote 0
            • A Offline
              AxLed Module Developer
              last edited by Mar 1, 2018, 12:27 PM

              I almost made it, for debugging i went this way (as i dont know any better so far):

              • Clientside: Browser with debugging feature
              • Serverside (like node_helper.js): console.log on every important location in the code

              My workaround (so far):
              I cloned the function getName to getName2 and use Reverselookup of phonenumbers only in getName2.
              I changed the call of getName to getName2 in following places:
              Line 80-98:

              //Incoming call
              		monitor.on("inbound", function(call) {
              			//If caller is not empty
              			if (call.caller != "") {
              				self.sendSocketNotification("call", self.getName2(call.caller));
              			};
              		});
              
              		//Call accepted
              		monitor.on("connected", function(call) {
              			self.sendSocketNotification("connected", self.getName2(call.caller));
              		});
              
              		//Caller disconnected
              		monitor.on("disconnected", function(call) {
              			//send clear command to interface
              			self.sendSocketNotification("disconnected", {"caller": self.getName2(call.caller), "duration": call.duration});
              		});
              console.log(this.name + " is waiting for incoming calls.");
              

              Reasons why i did this workaround: loadCallList
              This function is called initialy, when you start MM and everytime you get a call. I dont understand, why loadCallList goes through all calls from the fritzbox journal in the past (infinitely), no matter what configuration options of the module you choosed. This gives me an "Socket hang up" error on reverse lookup after 100 requests. Now you know why i did this workaround.

              Regards

              AxLED

              1 Reply Last reply Reply Quote 0
              • B Offline
                barnosch
                last edited by Mar 1, 2018, 2:11 PM

                cool feature, i will definitely upgrade to that version, if it is running well
                thumbsup
                and now the but…
                is this really necessary these days?
                I don’t know any of my friends or our generation who really publicate their phonenumber in the public phonebook.
                Mobile numbers especially not.
                So it is only helpful for bigger companies, right?

                Y 1 Reply Last reply Mar 1, 2018, 2:26 PM Reply Quote 0
                • Y Offline
                  yawns Moderator @barnosch
                  last edited by Mar 1, 2018, 2:26 PM

                  @barnosch
                  Not necessarily. Even smaller companies (those without one base number and dozens of extensions) do add their phone number to public phonebooks. My phone solution does use online lookup and lots of craftspeople who called during our house building phase where identified on the phone showing “Dachdecker Hildebrandt” (for example).

                  1 Reply Last reply Reply Quote 1
                  • A Offline
                    AxLed Module Developer
                    last edited by Mar 4, 2018, 5:42 PM

                    @pinsdorf
                    i created a fork, i am not sure if i did everything right (i checked some readme before and keeped on that), details see: https://github.com/Ax-LED/MMM-FRITZ-Box-Callmonitor/pull/1/files

                    There is also a working beta of the reverse lookup feature.

                    I know the code is still quick n dirty.

                    AxLED

                    1 Reply Last reply Reply Quote 0
                    • P Offline
                      pinsdorf Module Developer
                      last edited by Mar 8, 2018, 8:34 PM

                      Hey @AxLed, sorry for the late reply. I’ve had a look at your code. It looks very good. Well done, man! Functionality is there. Certainly, you can do some cleanup as you say, but that is secondary. It is great that you have extended this module with such nice magic.

                      One suggestion I made earlier is putting the lookup at the online phone book (dasoertliche.de) & parsing into its own module. This would allow others to write phonebook lookup modules for their own country. I’m happy to do this change on your code base.

                      You did all the (sometimes confusing) Git stuff right: you forked from the original repository, checked out your repository, made changes, committed and pushed them back into your repository. There was just one step too much, which is the pull request. You typically make a pull request in the person’s repository that you have forked from to tell the original author ‘hey, here is cool new stuff that you may want to have in the original repository’. I would suggest that you accept or remove your own pull request.

                      If you want me to extract a module for the phonebook lookup & parsing, I can work on the latest version of your repository and either push directly to your repo (if you grant me write access) or I send my own pull request to you.

                      1 Reply Last reply Reply Quote 0
                      • 1
                      • 2
                      • 1 / 2
                      1 / 2
                      • First post
                        10/16
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy