MMM-PC-Stats

justjim1220

jim@jim-Aspire-4520:~/MagicMirror$ sensors
k8temp-pci-00c3
Adapter: PCI adapter
Core0 Temp:   +69.0°C  
Core0 Temp:   +67.0°C  
Core1 Temp:   +69.0°C  
Core1 Temp:   +68.0°C  

acpitz-virtual-0
Adapter: Virtual device
temp1:        +71.0°C  (crit = +100.0°C)

nouveau-pci-0090
Adapter: PCI adapter
GPU core:     +1.20 V  (min =  +1.00 V, max =  +1.20 V)
temp1:        +64.0°C  (high = +95.0°C, hyst =  +3.0°C)
                       (crit = +105.0°C, hyst =  +2.0°C)
                       (emerg = +135.0°C, hyst =  +5.0°C)

Mykle1

@justjim1220

Ok, I see it. In dev tools you can expand the output to see the tree

justjim1220

@mykle1

there is a lot of things to expand, how much do you need?

Objectacpitz-virtual-0: Virtual device: temp1: name: "temp1"type: "temperature"value: 80__proto__: Objectconstructor: ƒ Object()arguments: (...)assign: ƒ assign()caller: (...)create: ƒ create()defineProperties: ƒ defineProperties()defineProperty: ƒ defineProperty()entries: ƒ entries()freeze: ƒ freeze()getOwnPropertyDescriptor: ƒ getOwnPropertyDescriptor()getOwnPropertyDescriptors: ƒ getOwnPropertyDescriptors()getOwnPropertyNames: ƒ getOwnPropertyNames()getOwnPropertySymbols: ƒ getOwnPropertySymbols()getPrototypeOf: ƒ getPrototypeOf()is: ƒ is()isExtensible: ƒ isExtensible()isFrozen: ƒ isFrozen()isSealed: ƒ isSealed()keys: ƒ keys()length: 1name: "Object"preventExtensions: ƒ preventExtensions()prototype: {constructor: ƒ, __defineGetter__: ƒ, __defineSetter__: ƒ, hasOwnProperty: ƒ, __lookupGetter__: ƒ, …}seal: ƒ seal()setPrototypeOf: ƒ setPrototypeOf()values: ƒ values()__proto__: ƒ ()[[FunctionLocation]]: <unknown>hasOwnProperty: ƒ hasOwnProperty()isPrototypeOf: ƒ isPrototypeOf()propertyIsEnumerable: ƒ propertyIsEnumerable()toLocaleString: ƒ toLocaleString()toString: ƒ toString()valueOf: ƒ valueOf()__defineGetter__: ƒ __defineGetter__()__defineSetter__: ƒ __defineSetter__()__lookupGetter__: ƒ __lookupGetter__()__lookupSetter__: ƒ __lookupSetter__()get __proto__: ƒ __proto__()set __proto__: ƒ __proto__()__proto__: Objectconstructor: ƒ Object()hasOwnProperty: ƒ hasOwnProperty()isPrototypeOf: ƒ isPrototypeOf()propertyIsEnumerable: ƒ propertyIsEnumerable()toLocaleString: ƒ toLocaleString()toString: ƒ toString()valueOf: ƒ valueOf()__defineGetter__: ƒ __defineGetter__()__defineSetter__: ƒ __defineSetter__()__lookupGetter__: ƒ __lookupGetter__()__lookupSetter__: ƒ __lookupSetter__()get __proto__: ƒ __proto__()set __proto__: ƒ __proto__()__proto__: Objectk8temp-pci-00c3: PCI adapter: __proto__: Objectconstructor: ƒ Object()hasOwnProperty: ƒ hasOwnProperty()isPrototypeOf: ƒ isPrototypeOf()propertyIsEnumerable: ƒ propertyIsEnumerable()toLocaleString: ƒ toLocaleString()toString: ƒ toString()valueOf: ƒ valueOf()__defineGetter__: ƒ __defineGetter__()__defineSetter__: ƒ __defineSetter__()__lookupGetter__: ƒ __lookupGetter__()__lookupSetter__: ƒ __lookupSetter__()get __proto__: ƒ __proto__()set __proto__: ƒ __proto__()__proto__: Objectconstructor: ƒ Object()hasOwnProperty: ƒ hasOwnProperty()isPrototypeOf: ƒ isPrototypeOf()propertyIsEnumerable: ƒ propertyIsEnumerable()toLocaleString: ƒ toLocaleString()toString: ƒ toString()valueOf: ƒ valueOf()__defineGetter__: ƒ __defineGetter__()__defineSetter__: ƒ __defineSetter__()__lookupGetter__: ƒ __lookupGetter__()__lookupSetter__: ƒ __lookupSetter__()get __proto__: ƒ __proto__()set __proto__: ƒ __proto__()nouveau-pci-0090: PCI adapter: {GPU core: {…}, temp1: {…}}__proto__: Object__proto__: constructor: ƒ Object()hasOwnProperty: ƒ hasOwnProperty()isPrototypeOf: ƒ isPrototypeOf()propertyIsEnumerable: ƒ propertyIsEnumerable()toLocaleString: ƒ toLocaleString()toString: ƒ toString()valueOf: ƒ valueOf()__defineGetter__: ƒ __defineGetter__()__defineSetter__: ƒ __defineSetter__()__lookupGetter__: ƒ __lookupGetter__()__lookupSetter__: ƒ __lookupSetter__()get __proto__: ƒ __proto__()set __proto__: ƒ __proto__()

justjim1220

@mykle1

It looks like this is the line it is having a problem with…

    var core0TempCheck = Sensors["coretemp-isa-0000"]['ISA adapter']['Core 0'];

particularly with: [‘ISA adapter’]

Mykle1

@justjim1220

I know the line that is the problem. Listen, I’m tired. If you’ll let me TeamViewer into your machine tomorrow I’ll fix it. Doing it this way is very tedious

justjim1220

@mykle1

Absolutely.
No Problem.
Just let me know when.

justjim1220

is there something I need to set up on this end for TeamViewer?

justjim1220

@mykle1

And, your gonna have to let me know how to do a screen shot of just a certain part of the screen, or how to crop the image. A lot different than Windows.

Mykle1

@justjim1220

This is what you need to change in the main js

		// Check if core0 has temp sensor
        var core0TempCheck = Sensors["acpitz-virtual-0"]; // ['ISA adapter']['Core 0'];
		if (typeof core0TempCheck !== 'undefined'){

        var core0Temp = document.createElement("div");
        core0Temp.classList.add("small", "bright", "core0Temp");
        core0Temp.innerHTML = Sensors["acpitz-virtual-0"]["Virtual device"].temp1.value + " &nbsp  @  &nbsp "
						    + Sensors["acpitz-virtual-0"]["Virtual device"].temp1.value + "&deg;C";
        wrapper.appendChild(core0Temp);
        }

        // ["acpitz-virtual-0"]["Virtual device"].temp1.value


		// Check if core1 has temp sensor
        var core1TempCheck = Sensors["acpitz-virtual-0"]; // ['ISA adapter']['Core 1'];
		if (typeof core1TempCheck !== 'undefined'){

        var core1Temp = document.createElement("div");
        core1Temp.classList.add("small", "bright", "core1Temp");
        core1Temp.innerHTML = Sensors["acpitz-virtual-0"]["Virtual device"].temp2.value + " &nbsp  @  &nbsp "
						    + Sensors["acpitz-virtual-0"]["Virtual device"].temp2.value + "&deg;C";
        wrapper.appendChild(core1Temp);
        }

Mykle1

Now leave me alone. I’m going to bed. :-)

justjim1220

@mykle1 ok

justjim1220

@mykle1 YES SIR!!!

justjim1220

@mykle1

This is what I ended up with:

for (var i = 0, len = Stats.cpu.threads.length; i < len; i++) {

		var Element = document.createElement("div");
		Element.classList.add("large", "bright", "usage");
		Element.innerHTML = Stats.cpu.threads[i].name + " &nbsp  @  &nbsp " + Number(Math.round(Stats.cpu.threads[i].usage+"e2")+"e-2") + "%";
		wrapper.appendChild(Element);



		// ["acpitz-virtual-0"]["Virtual device"].temp1.value

		// Check if core0 has temp sensor
		var core0TempCheck = Sensors["acpitz-virtual-0"]["Virtual device"];
			if (typeof core0TempCheck !== 'undefined'){
			// core0Temp
			var core0Temp = document.createElement("div");
			core0Temp.classList.add("large", "bright", "core0Temp");
			core0Temp.innerHTML = Stats.cpu.threads[i].name + " &nbsp  @  &nbsp " + Sensors["acpitz-virtual-0"]["Virtual device"].temp1.value + "°C";
			wrapper.appendChild(core0Temp);
		}
	}

this is the output:
0_1540410083724_Screenshot from 2018-10-24 13-45-54.png

justjim1220

@mykle1

So, when I use the code you sent last night, It gives error regarding .temp2.value

being that the ‘Virtual device’ only has 1 output value.

My changes will always show the ‘temp value’ as the same for all CPU’s

When I run ‘sensors’ in MM, it showed a ‘Core0 Temp’ and a ‘Core1 Temp’, It actually showed 2 temps for each one.

jim@jim-Aspire-4520:~/MagicMirror$ sensors
k8temp-pci-00c3
Adapter: PCI adapter
Core0 Temp:   +69.0°C  
Core0 Temp:   +67.0°C  
Core1 Temp:   +69.0°C  
Core1 Temp:   +68.0°C  

acpitz-virtual-0
Adapter: Virtual device
temp1:        +71.0°C  (crit = +100.0°C)

nouveau-pci-0090
Adapter: PCI adapter
GPU core:     +1.20 V  (min =  +1.00 V, max =  +1.20 V)
temp1:        +64.0°C  (high = +95.0°C, hyst =  +3.0°C)
                       (crit = +105.0°C, hyst =  +2.0°C)
                       (emerg = +135.0°C, hyst =  +5.0°C)

With this being a Dual Core CPU, why can’t I get it to use the ‘PCI adapter’ to give the output?

justjim1220

@mykle1

Another question…

How can be changed to show F°?

Not really a big deal, mostly just curious… :upside-down_face:

yawns

@justjim1220 said in MMM-PC-Stats:

@mykle1

Another question…

How can be changed to show F°?

Not really a big deal, mostly just curious… :upside-down_face:

Just run sensors -f, at least this is working in debian, so I guess it should work in raspbian too

Or, if you just want to convert Celcius to Fahrenheit, add some code to Mykles module like this temp = ((temp/5)*9)+32 ;)
But then again, you could add a config option to toggle between Fahrenheit and Celsius and submit a pull request