Opening hours for stores/places thru Google API

evroom

@Menturan said in Opening hours for stores/places thru Google API:

What do you think?

Hi,

Wanted to give it a try.
By coincidence went to a place that was closed and this module could have saved me the trip.

My first thought was: really ?

1. yarn install

But I know it is under development and you do this voluntary, so I cannot really complain (never submitted a single module myself).
I do like Mich’s General Advise.
https://github.com/MichMich/MagicMirror/tree/master/modules

Most if not all modules use git clone and an occasional npm install

$ git clone https://github.com/Menturan/MMM-OpeningHours.git
$ npm install

I was so stubborn to install it this way, as I do not want to find out how yarn works.
I got it running to the point where on the MM I see:
Loading opening hours ...
The pm2 logs does not give an error or warning or so.
I see it converted my place id to a real address, so it means that my Google API key is okay.

I will try it again with the debug parameter on, but can you tell me what I should see when the opening times are fetched (in pm2 logs) ?
And perhaps really need yarn ?
But then an explanation is needed; a plain yarn install won’t do.

So, thanks for the module, but would be nice to get it working.

htilly

Hi,

Regarding yarn or npm is just a matter of package managers. As far as I understand you could probably happily do what you described using npm if that feels better.

now, for the data. I installed it and had the same problem as you describe. First of, make sure that you do have a Google API registered and working. Assuming that you have this, my installation started to work after a reboot of the Raspberry Pi.
I guess that it will not initiate a new API call after changing the config for MagicMirror.

And to be clear, I have not coded this. I’m the one that requested the feature, and I simply love the delivery. Exactly what I wanted!!

BR
Tilly

evroom

Rebooted.
No change.

I do get this error:

0|mm  | [5:13:03 PM] - MMM-OpeningHours : Starting helper:  MMM-OpeningHours
0|mm  | Sockets connected & modules started ...
0|mm  | Launching application.
0|mm  | (node:2342) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'refs' of undefined
0|mm  | (node:2342) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I suppose the API key is right, as it finds the (street)name.
And it increases the usage counter for Google Places for my account.

But no opening times.
On Google Maps opening times are visible for this ID.

0|mm  |   json:
0|mm  |    { html_attributions: [],
0|mm  |      result: { name: 'Laufamholzstraße 76' },
0|mm  |      status: 'OK' },
0|mm  |   requestUrl: 'https://maps.googleapis.com/maps/api/place/details/json?fields=name%2Copening_hours&language=en&placeid=ChIJ9SpsbxZYn0cRhBEv4PE_Tvs&key=<key>',
0|mm  |   query:
0|mm  |    { fields: 'name,opening_hours',
0|mm  |      language: 'en',
0|mm  |      placeid: 'ChIJ9SpsbxZYn0cRhBEv4PE_Tvs',
0|mm  |      key: '<key>' } }

And I do not see a mapping between place id, street name and the name of the place.

htilly

I tried it and it seems to be something strange with the PlaceID.
Try this ID instead:
ChIJl7ycbxZYn0cRqZwkVTJ3Rzw

Should be the same place.

/Tilly

evroom

@htilly said in Opening hours for stores/places thru Google API:

Try this ID instead:

Thanks for spending time on it.

Strange, but it works.
The Place finder really says “ChIJ9SpsbxZYn0cRhBEv4PE_Tvs”, how did you find “ChIJl7ycbxZYn0cRqZwkVTJ3Rzw” ??

0_1553893557312_Screenshot 2019-03-29 at 22.04.51.png

evroom

Just FYI
Simple test if both API key and place ID are okay using curl.

This returns both name & opening_hours (as it should be):

$ curl "https://maps.googleapis.com/maps/api/place/details/json?fields=name,opening_hours&language=en&placeid=ChIJl7ycbxZYn0cRqZwkVTJ3Rzw&key="API_KEY"

In my case, it returned only the name:

$ curl "https://maps.googleapis.com/maps/api/place/details/json?fields=name,opening_hours&language=en&placeid=ChIJ9SpsbxZYn0cRhBEv4PE_Tvs&key="API_KEY"

Still confused why the place ID from Place Finder seems a bit off.

Bloham

Hi Guys,
(This is my first post :P but I have problems with this amazing module so I hope you could help)
I have basically the same problem as evroom. My API is working (I do get the requested information at least with the link: "https://maps.googleapis.com/maps/api/place/details/json?fields=name,opening_hours&language=en&placeid=....
I installed it with npm install and the module is just saying “Loading Opening Hours”.
I just set debug: "true", but i don’t know where to find the debug file ^^ (I’m pretty new to all of this)
Any idea for a fix? And this module is amazing (when it works) We always struggle to know if a certain shop is still open xD
Best, Ben

PROBLEM SOLVED:
At least for me, I just had to wait until after midnight and the data got fetched again and is showing now everything properly. So for everyone with the same problem, maybe just wait until the next day :)

mumblebaj

@Menturan Thanks for a great module. I had the module working for a two weeks but for the past few days it has stopped working. So, I have been working through the issue and after stopping and starting the mirror I am getting results returned but it is not being sent to the screen. Is there a reason for this?

[09:48:50] - DEBUG - MMM-OpeningHours : Sending to frontend - [{"name":"Makro Store Crown Mines","opening_hours":{"open_now":true,"periods":[{"close":{"day":0,"time":"1400"},"open":{"day":0,"time":"0900"}},{"close":{"day":1,"time":"1730"},"open":{"day":1,"time":"0830"}},{"close":{"day":2,"time":"1730"},"open":{"day":2,"time":"0830"}},{"close":{"day":3,"time":"1730"},"open":{"day":3,"time":"0830"}},{"close":{"day":4,"time":"1730"},"open":{"day":4,"time":"0830"}},{"close":{"day":5,"time":"1730"},"open":{"day":5,"time":"0830"}},{"close":{"day":6,"time":"1600"},"open":{"day":6,"time":"0800"}}],"weekday_text":["Monday: 8:30 AM â 5:30 PM","Tuesday: 8:30 AM â 5:30 PM","Wednesday: 8:30 AM â 5:30 PM","Thursday: 8:30 AM â 5:30 PM","Friday: 8:30 AM â 5:30 PM","Saturday: 8:00 AM â 4:00 PM","Sunday: 9:00 AM â 2:00 PM"]},"place_id":"ChIJl8h2VlIJlR4Rn5311bQlcXQ"},{"name":"Builders Warehouse Glen Eagles","opening_hours":{"open_now":true,"periods":[{"close":{"day":0,"time":"1600"},"open":{"day":0,"time":"0800"}},{"close":{"day":1,"time":"1800"},"open":{"day":1,"time":"0700"}},{"close":{"day":2,"time":"1800"},"open":{"day":2,"time":"0700"}},{"close":{"day":3,"time":"1800"},"open":{"day":3,"time":"0700"}},{"close":{"day":4,"time":"1800"},"open":{"day":4,"time":"0700"}},{"close":{"day":5,"time":"1800"},"open":{"day":5,"time":"0700"}},{"close":{"day":6,"time":"1700"},"open":{"day":6,"time":"0700"}}],"weekday_text":["Monday: 7:00 AM â 6:00 PM","Tuesday: 7:00 AM â 6:00 PM","Wednesday: 7:00 AM â 6:00 PM","Thursday: 7:00 AM â 6:00 PM","Friday: 7:00 AM â 6:00 PM","Saturday: 7:00 AM â 5:00 PM","Sunday: 8:00 AM â 4:00 PM"]},"place_id":"ChIJB0lb_mgPlR4Rje4UAMJnOvY"},null,null]

tcsevens

It doesn’t seem to work anymore, black screen for me, do you have a solution?

sdetweil

@tcsevens see this
https://forum.magicmirror.builders/topic/15778/fix-for-black-screen-in-2-16-and-later