MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Alert module display_time

    Scheduled Pinned Locked Moved Bug Hunt
    4 Posts 3 Posters 3.2k Views 2 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • PiepsP Offline
      Pieps
      last edited by

      Hi @MichMich ,

      I just wanted to tell you that there is a fault in the config part of your readme of the alert module.

      The display time is described in seconds but its really expressed in milliseconds. So on default, the alert is shown for 3.5ms … nothing ;-)

      I’m sure that a lot of the users did found this by herself, but for the noobs it could be confusion.

      Best wishes
      Pieps

      MichMichM 1 Reply Last reply Reply Quote 0
      • MichMichM Offline
        MichMich @Pieps
        last edited by

        @Pieps Feel free to send a PR with the fix. Or if that’s too difficult, feel free to point me to the right file containing the error (+ line number). I’ll fix is.

        Thanks!

        strawberry 3.141S 1 Reply Last reply Reply Quote 0
        • strawberry 3.141S Offline
          strawberry 3.141 Project Sponsor Module Developer @MichMich
          last edited by

          @MichMich https://github.com/MichMich/MagicMirror/tree/master/modules/default/alert in the readme it says seconds but the implementation is based on milliseconds

          Please create a github issue if you need help, so I can keep track

          1 Reply Last reply Reply Quote 0
          • MichMichM Offline
            MichMich
            last edited by

            Fixed: https://github.com/MichMich/MagicMirror/blob/develop/modules/default/alert/README.md

            1 Reply Last reply Reply Quote 0

            Hello! It looks like you're interested in this conversation, but you don't have an account yet.

            Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.

            With your input, this post could be even better 💗

            Register Login
            • 1 / 1
            • First post
              Last post
            Enjoying MagicMirror? Please consider a donation!
            MagicMirror created by Michael Teeuw.
            Forum managed by Sam, technical setup by Karsten.
            This forum is using NodeBB as its core | Contributors
            Contact | Privacy Policy