MMM-Random Fact

cowboysdude

I will look at it again tonight they may have changed the api… stay tuned.

cowboysdude

I just tested mine and it’s working fine… I reuploaded mine to make sure there are no errors in the one on Github…

Also here is my config:

      {
        disabled: f,
        module: 'MMM-rfacts',
        position: 'top_left', 
       },

The language selection is taken directly from your language selected in the config file… I switched mine to ‘de’ and it worked fine. So what I would do if I were you is to delete it all and do the git clone thing and then run npm install in the MMM-rfacts dir …

lavolp3

@cowboysdude
Thanks dude :-), will try it out later today

lavolp3

Hi guys.
I’ve tried to get this module working again and am still failing.
I was able to find out the following:
My general config is mentioning
language: 'de'
When I set this to en, the module works.
With language de, it does not give a translated fact.

Now the above mentioned “unhandled promise rejection” warning is not the problem.
You can solve this issue by adding a .catch() phrase after the .this in the promise part to catch and process a rejected promise.

Since the translate() function does not properly work, the promise gets rejected, and since there is no rejection handing in the code, we get the “unhandled rejection” warning. I’ll try to set up a solution and send a PR.

The translation problem with this module apparently lies in the google-translate-api.
I was able to console.log the error message
at /home/pi/MagicMirror/modules/MMM-rfacts/node_modules/google-translate-api/index.js:106:17 at <anonymous> at process._tickCallback (internal/process/next_tick.js:188:7) code: 'BAD_REQUEST' }

This error is well known for the google-translate-api since 2018.

The question is:
Does this module work for anyone in another language? (and if yes: WHY?)

lavolp3

Well…
“Eureka!”

Apparently the problem is solved using this hack. There seems to be an issue with the google-translate-api npm module that some users solved with a fork.
@cowboysdude look at it and let me know what you think.
If the issue/solution is confirmed a workaround would be to have a working fork installed via npm.

(need to get back to work now!!..)

lavolp3

It’s odd that noone else seems to have the translation problem.

However, I have just pushed a PR including a promise.catch function in case translation does not work.
This module still only works with the “manipulated” google-translate-api" for me.

Love your module, @cowboysdude . Many great facts received in recent months.

lavolp3

@cowboysdude
I’m afraid the link is broken in your module.
Directly visiting http://www.fayd.org/api/fact.xml redirects to a facebook page.

Node_helper.js returns a promise rejection because there’s no body element to be fetched.
Can you please check?

cowboysdude

@lavolp3 Thank you!! That is very interesting and I will look into that right now!!! Will let you know.

I looked…looks like I’ll have to rewrite parts of it and I will and repost as soon as it’s done…later tonight :)

cowboysdude

@lavolp3 I have it working… it’ll be a day or so to upload it as I do have one very strange error that I want to correct :)

cowboysdude

@lavolp3

https://github.com/cowboysdude/MMM-rfacts

New api, tested and working :)

chassain 0

@cowboysdude hello,

Sorry but nothing to display after new install. Only “obtenir un fait…” (french)

Stoffbeuteluwe

@cowboysdude Sorry nothing is showing… only (Eine Tatsache bekommen) German

cowboysdude

@Stoffbeuteluwe Not sure why it’s working here… so if you can PM me and I’ll have you try something to see if it’s the api or something else. Thanks

chassain 0

@cowboysdude hello,

what can we do to check ? thanks…i have update (latest and stable) npm and the same result

lavolp3

@cowboysdude Dude you’re ignoring all the debugging!
(After including debug logs) I got the response code 503 from the API

[2020-04-23 10:35:54.046] [LOG]    10:35:54 <log> Wrong response code: 503 (/home/pi/MagicMirror/modules/MMM-rfacts/node_helper.js:47 Request._callback)
[2020-04-23 10:35:54.054] [LOG]    10:35:54 <log> {"statusCode":503,"body":"<!DOCTYPE html>\n<html>\n<head>\n<meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n<meta charset=\"utf-8\">\n<title>Application Error</title>\n<script src=\"/cdn-cgi/apps/head/mRZC9wXQsm0r4xm9M3hblvWOKNw.js\"></script><style media=\"screen\">\n\t\t  html,body,iframe {\n\t\t\tmargin: 0;\n\t\t\tpadding: 0;\n\t\t  }\n\t\t  html,body {\n\t\t\theight: 100%;\n\t\t\toverflow: hidden;\n\t\t  }\n\t\t  iframe {\n\t\t\twidth: 100%;\n\t\t\theight: 100%;\n\t\t\tborder: 0;\n\t\t  }\n\t\t</style>\n</head>\n<body>\n<iframe src=\"//www.herokucdn.com/error-pages/application-error.html\"></iframe>\n</body>\n</html>","headers":{"date":"Thu, 23 Apr 2020 08:35:53 GMT","content-type":"text/html; charset=utf-8","transfer-encoding":"chunked","connection":"close","set-cookie":["__cfduid=dba2fb4d60e085d460cd31721c37883191587630953; expires=Sat, 23-May-20 08:35:53 GMT; path=/; domain=.sameerkumar.website; HttpOnly; SameSite=Lax; Secure"],"cache-control":"no-cache, no-store","cf-cache-status":"DYNAMIC","expect-ct":"max-age=604800, report-uri=\"https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct\"","server":"cloudflare","cf-ray":"588640f1695a0026-LHR","cf-request-id":"0247c6eadf000000267690a200000001"},"request":{"uri":{"protocol":"https:","slashes":true,"auth":null,"host":"useless-facts.sameerkumar.website","port":443,"hostname":"useless-facts.sameerkumar.website","hash":null,"search":null,"query":null,"pathname":"/api","path":"/api","href":"https://useless-facts.sameerkumar.website/api"},"method":"GET","headers":{}}} (/home/pi/MagicMirror/modules/MMM-rfacts/node_helper.js:48 Request._callback)
[2020-04-23 10:35:54.064] [LOG]    10:35:54 <log> null (/home/pi/MagicMirror/modules/MMM-rfacts/node_helper.js:49 Request._callback)

I guess my pre-posters have a similar experience.

lavolp3

@cowboysdude @chassain-0 @Stoffbeuteluwe
Its obviously an API problem. The API page returns an Application Error.
I guess we need another API.

How about this one?
https://uselessfacts.jsph.pl/random.json
It seems to use (at least) the german source “neon”.
I was actually looking for that for some time because neon has published a range of books called “useless facts”. FOund it accidentally just now.

It could be implemented and then translated from the source language to the user language.
If it uses all of neon’s facts there quite a lot.

If you don’t want to use this source, no problem, then I’d build an own module.

chassain 0

@lavolp3 we can use this for the moment…and see after…the modul is so fine that i can 't work without :)//how integrate this new api ?

lavolp3

@chassain-0 I have it working but changed lots of things on the frontend and in node_helper.js. So need to check the changes again.

lavolp3

@lavolp3
PR sent
https://github.com/cowboysdude/MMM-rfacts/pull/12

It seems I have done a bit too much JS programming in recent months… Lol.

@cowboysdude have a look at it and let me know what you think.

chassain 0

@lavolp3 It works fine for me (in french) with the changes manualy